Replaced extension notes by semitone offsets.

Author: icalvo

packages/string-fingerings/fingerings.spec.ts

@@ -156,7 +156,7 @@ const bassExtension = {
     {
       name: 'E',
       openNote: nn('E1'),
-      additionalOpenNotes: [nn('D#1'), nn('D1'), nn('C#1'), nn('C1')]
+      additionalOpenSemitones: [-1,-2,-3,-4],
     },
     {
       name: 'A',

packages/string-fingerings/fingerings.ts

@@ -111,8 +111,8 @@ function* stopsForString<TString extends InstrumentString>(
   if (!instrumentString) return;
   const openNote = instrumentString.openNote as number
   const stopIndex = noteNumber - openNote
-  const additionalOpenNotes = instrumentString.additionalOpenNotes ?? []
-
+  const additionalOpenSemitones = instrumentString.additionalOpenSemitones ?? []
+  const additionalOpenNotes = additionalOpenSemitones.map((s) => s + openNote)
   if (stopIndex < 0 && !additionalOpenNotes.includes(noteNumber)) {
     console.debug(`${noteName(noteNumber)} is too low for ${instrumentString.name} string`)
     return

packages/string-fingerings/types.ts

@@ -31,9 +31,7 @@ export interface InstrumentString {
     /** Open string note as a MIDI number (middle C = 60) */
     openNote: number
     /** Additional open strings, as semitone offsets from the open string */
-    additionalOpenSemitones: number[]
-    /** Additional open strings, as a MIDI number (for low range extensions) */
-    additionalOpenNotes?: number[]
+    additionalOpenSemitones?: number[]
     /** Maximum number of semitones that can be stopped over the open string */
     stops?: number
 }