linting fixes

Author: nehresma

lib/ice_cube/validations/by_set_pos_helper.rb

@@ -26,7 +26,7 @@ def interval_bounds(interval_type, step_time, week_start: nil)
         start_day_of_week = TimeUtil.sym_to_wday(week_start)
         step_time_day_of_week = step_time_date.wday
         days_delta = step_time_day_of_week - start_day_of_week
-        days_to_start = days_delta >= 0 ? days_delta : 7 + days_delta
+        days_to_start = (days_delta >= 0) ? days_delta : 7 + days_delta
         start_of_week_date = step_time_date - days_to_start
         end_of_week_date = start_of_week_date + 6
         [
@@ -69,9 +69,9 @@ def interval_bounds(interval_type, step_time, week_start: nil)
     def build_filtered_schedule(rule, start_time, interval_start)
       # Strip BYSETPOS/COUNT/UNTIL so the candidate set is complete, and avoid
       # recursive BYSETPOS evaluation when we rebuild the temporary rule.
-      filtered_hash = rule.to_hash.reject { |key, _| [:by_set_pos, :count, :until].include?(key) }
+      filtered_hash = rule.to_hash.except(:by_set_pos, :count, :until)
       if filtered_hash[:validations]
-        filtered_hash[:validations] = filtered_hash[:validations].reject { |key, _| key == :by_set_pos }
+        filtered_hash[:validations] = filtered_hash[:validations].except(:by_set_pos)
         filtered_hash.delete(:validations) if filtered_hash[:validations].empty?
       end
 
@@ -81,11 +81,11 @@ def build_filtered_schedule(rule, start_time, interval_start)
       # We must anchor the temp schedule to the interval boundary for expanded units,
       # while preserving DTSTART's value for implicit (non-expanded) units.
       v = rule.validations
-      expands_day   = v[:day] || v[:day_of_month] || v[:day_of_week] || v[:day_of_year]
+      expands_day = v[:day] || v[:day_of_month] || v[:day_of_week] || v[:day_of_year]
       expands_month = v[:month_of_year]
-      expands_hour  = v[:hour_of_day]
-      expands_min   = v[:minute_of_hour]
-      expands_sec   = v[:second_of_minute]
+      expands_hour = v[:hour_of_day]
+      expands_min = v[:minute_of_hour]
+      expands_sec = v[:second_of_minute]
 
       # Anchor date: determine based on which date components are expanded.
       # WeeklyRule is special: "day" expansion means weekdays within the week.
@@ -115,8 +115,8 @@ def build_filtered_schedule(rule, start_time, interval_start)
       # This ensures the candidate set starts at the interval boundary for expanded
       # units while preserving implicit time-of-day anchors from DTSTART.
       hour = expands_hour ? interval_start.hour : start_time.hour
-      min  = expands_min  ? interval_start.min  : start_time.min
-      sec  = expands_sec  ? interval_start.sec  : start_time.sec
+      min = expands_min ? interval_start.min : start_time.min
+      sec = expands_sec ? interval_start.sec : start_time.sec
 
       # Preserve sub-second precision from DTSTART to ensure occurrences.index(step_time)
       # can find exact matches when DTSTART has fractional seconds.

lib/ice_cube/validations/daily_by_set_pos.rb

@@ -3,7 +3,7 @@ module Validations::DailyBySetPos
     def by_set_pos(*by_set_pos)
       by_set_pos.flatten!
       by_set_pos.each do |set_pos|
-        unless (-366..366).include?(set_pos) && set_pos != 0
+        unless (-366..366).cover?(set_pos) && set_pos != 0
           raise ArgumentError, "Expecting number in [-366, -1] or [1, 366], got #{set_pos} (#{by_set_pos})"
         end
       end

lib/ice_cube/validations/hourly_by_set_pos.rb

@@ -3,7 +3,7 @@ module Validations::HourlyBySetPos
     def by_set_pos(*by_set_pos)
       by_set_pos.flatten!
       by_set_pos.each do |set_pos|
-        unless (-366..366).include?(set_pos) && set_pos != 0
+        unless (-366..366).cover?(set_pos) && set_pos != 0
           raise ArgumentError, "Expecting number in [-366, -1] or [1, 366], got #{set_pos} (#{by_set_pos})"
         end
       end

lib/ice_cube/validations/minutely_by_set_pos.rb

@@ -3,7 +3,7 @@ module Validations::MinutelyBySetPos
     def by_set_pos(*by_set_pos)
       by_set_pos.flatten!
       by_set_pos.each do |set_pos|
-        unless (-366..366).include?(set_pos) && set_pos != 0
+        unless (-366..366).cover?(set_pos) && set_pos != 0
           raise ArgumentError, "Expecting number in [-366, -1] or [1, 366], got #{set_pos} (#{by_set_pos})"
         end
       end

lib/ice_cube/validations/monthly_by_set_pos.rb

@@ -1,10 +1,9 @@
 module IceCube
-
   module Validations::MonthlyBySetPos
     def by_set_pos(*by_set_pos)
       by_set_pos.flatten!
       by_set_pos.each do |set_pos|
-        unless (-366..366).include?(set_pos) && set_pos != 0
+        unless (-366..366).cover?(set_pos) && set_pos != 0
           raise ArgumentError, "Expecting number in [-366, -1] or [1, 366], got #{set_pos} (#{by_set_pos})"
         end
       end
@@ -15,7 +14,6 @@ def by_set_pos(*by_set_pos)
     end
 
     class Validation
-
       attr_reader :rule, :by_set_pos
 
       def initialize(by_set_pos, rule)
@@ -45,7 +43,7 @@ def validate(step_time, start_time)
         # occurrence to positive/negative positions.
         occurrences = new_schedule.occurrences_between(start_of_month, end_of_month)
         index = occurrences.index(step_time)
-        if index == nil
+        if index.nil?
           1
         else
           positive_set_pos = index + 1
@@ -73,7 +71,5 @@ def build_ical(builder)
 
       nil
     end
-
   end
-
 end

lib/ice_cube/validations/secondly_by_set_pos.rb

@@ -3,7 +3,7 @@ module Validations::SecondlyBySetPos
     def by_set_pos(*by_set_pos)
       by_set_pos.flatten!
       by_set_pos.each do |set_pos|
-        unless (-366..366).include?(set_pos) && set_pos != 0
+        unless (-366..366).cover?(set_pos) && set_pos != 0
           raise ArgumentError, "Expecting number in [-366, -1] or [1, 366], got #{set_pos} (#{by_set_pos})"
         end
       end

lib/ice_cube/validations/weekly_by_set_pos.rb

@@ -3,7 +3,7 @@ module Validations::WeeklyBySetPos
     def by_set_pos(*by_set_pos)
       by_set_pos.flatten!
       by_set_pos.each do |set_pos|
-        unless (-366..366).include?(set_pos) && set_pos != 0
+        unless (-366..366).cover?(set_pos) && set_pos != 0
           raise ArgumentError, "Expecting number in [-366, -1] or [1, 366], got #{set_pos} (#{by_set_pos})"
         end
       end
@@ -14,7 +14,6 @@ def by_set_pos(*by_set_pos)
     end
 
     class Validation
-
       attr_reader :rule, :by_set_pos
 
       def initialize(by_set_pos, rule)

lib/ice_cube/validations/yearly_by_set_pos.rb

@@ -1,11 +1,9 @@
 module IceCube
-
   module Validations::YearlyBySetPos
-
     def by_set_pos(*by_set_pos)
       by_set_pos.flatten!
       by_set_pos.each do |set_pos|
-        unless (-366..366).include?(set_pos) && set_pos != 0
+        unless (-366..366).cover?(set_pos) && set_pos != 0
           raise ArgumentError, "Expecting number in [-366, -1] or [1, 366], got #{set_pos} (#{by_set_pos})"
         end
       end
@@ -16,11 +14,9 @@ def by_set_pos(*by_set_pos)
     end
 
     class Validation
-
       attr_reader :rule, :by_set_pos
 
       def initialize(by_set_pos, rule)
-
         @by_set_pos = by_set_pos
         @rule = rule
       end
@@ -48,7 +44,7 @@ def validate(step_time, start_time)
         occurrences = new_schedule.occurrences_between(start_of_year, end_of_year)
 
         index = occurrences.index(step_time)
-        if index == nil
+        if index.nil?
           1
         else
           positive_set_pos = index + 1