Tests work.

Author: philipmjohnson

README.md

@@ -13,6 +13,7 @@ This application provides an example of form processing with the following featu
   * Individual twitter bootstrap-specific [helper templates](https://github.com/ics-software-engineering/play-example-form/tree/master/app/views/bootstrap)
   * Separation of [form backing classes](https://github.com/ics-software-engineering/play-example-form/tree/master/app/views/formdata) from [model classes](https://github.com/ics-software-engineering/play-example-form/tree/master/app/models).
   * All validation done through a [validate() method](https://github.com/ics-software-engineering/play-example-form/blob/master/app/views/formdata/StudentFormData.java#L57-123).
+  * Testing with Fluentlenium.
 
 The design of this example differs in two significant ways from the traditional Play form processing examples. 
 

app/views/bootstrap/radiobuttons.scala.html

@@ -8,7 +8,7 @@
       <input
         type="radio"
         name="@field.name"
-        id="@field.id"
+        id="@buttonName"
         value="@buttonName"
         @if(buttonName == field.value.getOrElse("")) {checked} />
       @buttonName

app/views/bootstrap/select.scala.html

@@ -9,7 +9,7 @@
       @if(isMultiple) {multiple="multiple"}>
       @if(!isMultiple) {<option class="blank" value="">Please select a value</option>}
       @for((optionName, isSelected) <- optionMap) {
-        <option value="@optionName" @if(isSelected) {selected}>@optionName</option>
+        <option id="@optionName" value="@optionName" @if(isSelected) {selected}>@optionName</option>
       }
     </select>
     <p class="help-block">@help</p>

test/tests/ViewTest.java

@@ -57,7 +57,7 @@ public void invoke(TestBrowser browser) {
     });
   }
 
-  /** Test submission of a filled out form. */
+  /** Test submission of a manually filled out form. */
   @Test
   public void testIndexPageFormFilledSubmission() {
     running(testServer(testPort, fakeApplication(inMemoryDatabase())), HTMLUNIT, new Callback<TestBrowser>() {
@@ -69,10 +69,13 @@ public void invoke(TestBrowser browser) {
         indexPage.setName("Ronald D. Moore");
         indexPage.setPassword("Battlestar Galactica");
         indexPage.selectHobby("Surfing");
+        indexPage.selectHobby("Biking");
         indexPage.selectGradeLevel("Freshman");
         indexPage.selectGPA("4.0");
+        indexPage.selectMajor("Physics");
+        indexPage.selectMajor("Mathematics");
         indexPage.submit();
-        //System.out.println(browser.pageSource());
+        //System.out.println(browser.pageSource());  // useful for debugging.
         assertThat(indexPage.hasSuccessMessage()).isTrue();
       }
     });

test/tests/pages/IndexPage.java

@@ -1,17 +1,25 @@
 package tests.pages;
 
 import static org.fluentlenium.core.filter.FilterConstructor.withId;
-import static org.fluentlenium.core.filter.FilterConstructor.withText;
 import org.fluentlenium.core.FluentPage;
 import org.openqa.selenium.WebDriver;
 
+/**
+ * Implements the page object pattern for the index page of this application. 
+ * See: https://github.com/FluentLenium/FluentLenium#what-is-fluentlenium-
+ * And: http://ics-software-engineering.github.io/play-example-fluentlenium/
+ */
 public class IndexPage extends FluentPage {
   private String url;
-  private WebDriver webDriver;
 
+  /**
+   * Construct the page. Note that you must always pass a studentID.  
+   * @param webDriver The driver.
+   * @param port The port.
+   * @param studentID The ID. Use 0 to get a blank form.
+   */
   public IndexPage(WebDriver webDriver, int port, int studentID) {
     super(webDriver);
-    this.webDriver = webDriver;
     this.url = "http://localhost:" + port + "/?id=" + studentID;
   }
 
@@ -36,19 +44,19 @@ public void setPassword(String password) {
   }
 
   public void selectHobby(String hobby) {
-    find("div", withId("hobbies")).find("input", withText(hobby)).click();
+    find("div", withId("hobbies")).find("input", withId(hobby)).click();
   }
 
   public void selectGradeLevel(String level) {
-    find("div", withId("levels"));
+    find("div", withId("levels")).find("input", withId(level)).click();
   }
 
   public void selectGPA(String gpa) {
-    find("select", withId("gpa")).find("option", withText(gpa)).click();
+    find("select", withId("gpa")).find("option", withId(gpa)).click();
   }
 
   public void selectMajor(String major) {
-    find("select", withId("majors")).find("option", withText(major)).click();
+    find("select", withId("majors")).find("option", withId(major)).click();
   }
 
   public void submit() {
@@ -60,17 +68,10 @@ public void cancel() {
   }
 
   public boolean hasSuccessMessage() {
-    return (this.webDriver.getPageSource().contains("success-message")) && 
-           (findFirst("div", withId("success-message")).isDisplayed());
+    return findFirst("div", withId("success-message")) != null;
   }
 
   public boolean hasErrorMessage() {
-    return (this.webDriver.getPageSource().contains("error-message")) &&
-           (findFirst("div", withId("error-message")).isDisplayed());
+    return findFirst("div", withId("error-message")) != null;
   }
-
-
-
-  
-  
 }