Skip to content

Commit ed31da7

Browse files
committed
use preverb whenever possible
1 parent 90103e2 commit ed31da7

2 files changed

Lines changed: 24 additions & 20 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ NOTE: Before publishing:
1616
The latest on-development version can be accessed by building the source code.
1717
On this on-development version, things can be broken.
1818

19+
- Preverbs are now used whenever possible making use of "be" e.g. "I try to be
20+
good" and "I may be good".
1921
- Implement nasin sitelen kalama pi linja lili a.k.a. cartouche tally marks.
2022
- Implement a bunch of words from the new UCSUR specification. This doesn't mean
2123
these will be recognized, only Linku is used for inclusion criteria. However,

src/translator2/phrase.ts

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -271,26 +271,28 @@ function preverb(
271271
break;
272272
}
273273
return { ...verb, subjectComplement, emphasis };
274-
} else if (
275-
verb.predicateType === "verb" && predicate.type === "verb" &&
276-
predicate.verb.type === "simple"
277-
) {
278-
const first = predicate.verb.verb[0];
279-
// TODO: filter out modal verb when found in the middle
280-
const predicateVerb: English.AdverbVerb = {
281-
preAdverbs: first.preAdverbs,
282-
verb: first.verb,
283-
postAdverb: null,
284-
};
285-
return {
286-
...predicate.verb,
287-
verb: [
288-
...verb.verb,
289-
predicateVerb,
290-
...predicate.verb.verb.slice(1),
291-
],
292-
emphasis,
293-
};
274+
} else if (verb.predicateType === "verb") {
275+
const predicateAsVerb = phraseAsVerb(predicate);
276+
if (predicateAsVerb.type === "simple") {
277+
const first = predicateAsVerb.verb[0];
278+
// TODO: filter out modal verb when found in the middle
279+
const verbForPreverb: English.AdverbVerb = {
280+
preAdverbs: first.preAdverbs,
281+
verb: first.verb,
282+
postAdverb: null,
283+
};
284+
return {
285+
...predicateAsVerb,
286+
verb: [
287+
...verb.verb,
288+
verbForPreverb,
289+
...predicateAsVerb.verb.slice(1),
290+
],
291+
emphasis,
292+
};
293+
} else {
294+
return null;
295+
}
294296
} else {
295297
return null;
296298
}

0 commit comments

Comments
 (0)