Skip to content

Commit 642591a

Browse files
committed
fix dropdown menu transition
1 parent 4e6a78e commit 642591a

2 files changed

Lines changed: 10 additions & 15 deletions

File tree

web-components/nav-header/nav-header.css

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -153,12 +153,13 @@ form div > img {
153153

154154
.dropdown-menu {
155155
background-color: #282828;
156-
height: 0em;
156+
max-height: 0;
157157
z-index: 120;
158158
transition: all 0.3s ease;
159159
overflow: hidden;
160160
position: absolute;
161-
}
161+
transition: all 0.35s linear;
162+
}
162163

163164
.dropdown-menu a p {
164165
font-size: 0.8125em;
@@ -169,7 +170,7 @@ form div > img {
169170
}
170171

171172
.show-menu {
172-
height: 35em;
173+
max-height: 60em;
173174
}
174175

175176
.menu {
@@ -180,23 +181,21 @@ form div > img {
180181
}
181182

182183
.menu div {
183-
display: grid;
184-
height: 30em;
185-
grid-template-columns: 1fr;
186-
grid-template-rows: 4em repeat(5, 1fr);
187-
/* align-items: center; */
184+
display: flex;
185+
flex-flow: column nowrap;
186+
gap: 0.2em;
188187
margin: 0em 1em;
189188
}
190189

191190
.menu div h3 {
192-
align-self: center;
193191
padding-left: 0.2em;
194192
}
195193

196194
.menu div a {
197195
align-self: start;
198196
padding: 0.8em;
199197
transition: 0.3s;
198+
width: 100%;
200199
}
201200

202201
.menu div a:hover {
@@ -234,10 +233,4 @@ form div > img {
234233
top: 0.3125em;
235234
width: auto;
236235
z-index: 3000;
237-
}
238-
239-
@media screen and (max-width: 89em) {
240-
.show-menu {
241-
height: 42em;
242-
}
243236
}

web-components/nav-header/nav-header.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,14 @@ function createComponent(html) {
117117
// Update display of dropdown menu based on checked state
118118
if (checkedState) {
119119
dropdownMenu.classList.add('show-menu');
120+
// dropdownMenu.style.maxHeight = '60em';
120121
// Make menu items focusable
121122
for (let i = 0; i < menuItems.length; i++) {
122123
menuItems[i].tabIndex = '0';
123124
}
124125
} else {
125126
dropdownMenu.classList.remove('show-menu');
127+
// dropdownMenu.style.maxHeight = '0em';
126128
// Make menu items non-focusable
127129
for (let i = 0; i < menuItems.length; i++) {
128130
menuItems[i].tabIndex = '-1';

0 commit comments

Comments
 (0)