Skip to content

Commit 779789a

Browse files
committed
update menu size and item names
1 parent 65aca11 commit 779789a

3 files changed

Lines changed: 18 additions & 5 deletions

File tree

web-components/nav-header/nav-header.css

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,10 @@ form div > img {
168168
position: absolute;
169169
}
170170

171+
.show-menu {
172+
height: 35em;
173+
}
174+
171175
.menu {
172176
display: grid;
173177
grid-template-columns: repeat(4, 1fr);
@@ -230,4 +234,11 @@ form div > img {
230234
top: 0.3125em;
231235
width: auto;
232236
z-index: 3000;
237+
}
238+
239+
@media screen and (max-width: 89em) {
240+
.show-menu {
241+
height: 42em;
242+
}
243+
233244
}

web-components/nav-header/nav-header.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ <h4>IBM <b>IMS Central</b></h4>
3939
<div>
4040
<h3>Learn</h3>
4141
<a href="ims-videos.html" tabindex="-1">
42-
<h5>Videos</h5>
42+
<h5>IMS videos</h5>
4343
<p>Choose from hundreds of educational videos on IMS components, functions, and tools.</p>
4444
</a>
4545
<a href="ims-education.html" tabindex="-1">
46-
<h5>Courses</h5>
46+
<h5>IMS courses</h5>
4747
<p>Get in-depth IMS education with these self-paced courses and instructor-led classes and earn digital badges.</p>
4848
</a>
4949
<a href="ims-repos.html" tabindex="-1">
50-
<h5>Repos on GitHub</h5>
50+
<h5>IMS repos on GitHub</h5>
5151
<p>Get code samples and tutorials on IMS components, workflows, Java, and more.</p>
5252
</a>
5353
</div>

web-components/nav-header/nav-header.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,13 +116,15 @@ function createComponent(html) {
116116
menuToggle.checked = checkedState;
117117
// Update display of dropdown menu based on checked state
118118
if (checkedState) {
119-
dropdownMenu.style.height = '35em';
119+
dropdownMenu.classList.add('show-menu');
120+
// dropdownMenu.style.height = '35em';
120121
// Make menu items focusable
121122
for (let i = 0; i < menuItems.length; i++) {
122123
menuItems[i].tabIndex = '0';
123124
}
124125
} else {
125-
dropdownMenu.style.height = '0em';
126+
dropdownMenu.classList.remove('show-menu');
127+
// dropdownMenu.style.height = '0em';
126128
// Make menu items non-focusable
127129
for (let i = 0; i < menuItems.length; i++) {
128130
menuItems[i].tabIndex = '-1';

0 commit comments

Comments
 (0)