Skip to content

Commit 6242850

Browse files
florisvdhfalkmielke
authored andcommitted
Update pull_request_template.md
While reviewing #356, the instructions of the PR template for reviewing seem to no longer work to render the site from the GHA artifact. With these changes, it seems to work again though, using python -m http.server 8887
1 parent 2f614a0 commit 6242850

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/pull_request_template.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ This provides a way to preview how these updates will look on the website, usefu
3838
### Instructions to preview the updated website
3939

4040
1) On the PR page, you can find a "details" link under "checks - On PR, build the site and ...". Go there, click on the top link in the left sidebar ("Summary"), and download the generated artifact at the bottom of the page.
41-
2) Decompress it and make sure the target directory is called 'tutorials' (you may need to rename it)
42-
3) From the parent directory (just above the `tutorials` folder you created/renamed), run `python -m http.server 8887`, _or_ launch the Google Chrome [Web Server app](https://chrome.google.com/webstore/detail/web-server-for-chrome/ofhbbkphhbklhfoeikjpcbhemlocgigb) and point it at the parent directory.
43-
4) Point your browser to http://localhost:8887/tutorials.
41+
2) Decompress it into a target directory.
42+
3) From the target directory, run `python -m http.server 8887`, _or_ launch the Google Chrome [Web Server app](https://chrome.google.com/webstore/detail/web-server-for-chrome/ofhbbkphhbklhfoeikjpcbhemlocgigb) and point it at the target directory.
43+
4) Point your browser to http://0.0.0.0:8887.
4444
5) Review the updated website. As a contributor, you can push extra commits to update the PR. As a reviewer, you can accept/refuse/comment the PR.
4545

4646
**Note: for step 3, you can use any other simple HTTP server to serve the current directory if you don't have a Python 3 environment or Google Chrome available.**

0 commit comments

Comments
 (0)