-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathapi-handler_test.go
More file actions
514 lines (456 loc) · 21.5 KB
/
api-handler_test.go
File metadata and controls
514 lines (456 loc) · 21.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
package prapi
import (
"bytes"
"context"
"encoding/json"
"errors"
"net/http"
"net/http/httptest"
"strconv"
"strings"
"testing"
"time"
"github.com/google/uuid"
"github.com/indexdata/crosslink/broker/common"
"github.com/indexdata/crosslink/broker/events"
pr_db "github.com/indexdata/crosslink/broker/patron_request/db"
"github.com/indexdata/crosslink/broker/patron_request/proapi"
prservice "github.com/indexdata/crosslink/broker/patron_request/service"
"github.com/indexdata/crosslink/broker/test/mocks"
"github.com/indexdata/crosslink/iso18626"
"github.com/jackc/pgx/v5"
"github.com/jackc/pgx/v5/pgtype"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
)
var mockEventBus = new(MockEventBus)
var mockEventRepo = new(mocks.MockEventRepositorySuccess)
var symbol = "ISIL:REQ"
var lendingString = string(prservice.SideLending)
var proapiBorrowingSide = proapi.Side(prservice.SideBorrowing)
var proapiLendingSide = proapi.Side(prservice.SideLending)
func validIllRequest() iso18626.Request {
return iso18626.Request{
BibliographicInfo: iso18626.BibliographicInfo{
Title: "Test title",
},
ServiceInfo: &iso18626.ServiceInfo{
ServiceType: iso18626.TypeServiceTypeCopy,
},
}
}
func TestGetId(t *testing.T) {
assert.True(t, getId("") != "")
assert.Equal(t, "id1", getId("id1"))
}
func TestGetDbText(t *testing.T) {
text := "v1"
result := getDbText(&text)
assert.True(t, result.Valid)
assert.Equal(t, "v1", result.String)
result = getDbText(nil)
assert.False(t, result.Valid)
}
func TestGetPatronRequests(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
params := proapi.GetPatronRequestsParams{
Side: &lendingString,
Symbol: &symbol,
}
handler.GetPatronRequests(rr, req, params)
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestGetPatronRequestsNoSymbol(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
params := proapi.GetPatronRequestsParams{
Side: &lendingString,
}
handler.GetPatronRequests(rr, req, params)
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "symbol must be specified")
}
func TestGetPatronRequestsWithLimits(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
offset := proapi.Offset(10)
limit := proapi.Limit(10)
cql := "state = NEW"
params := proapi.GetPatronRequestsParams{
Side: &lendingString,
Symbol: &symbol,
Offset: &offset,
Limit: &limit,
Cql: &cql,
}
handler.GetPatronRequests(rr, req, params)
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestGetPatronRequestsWithRequesterReqId(t *testing.T) {
repo := new(PrRepoCapture)
handler := NewPrApiHandler(repo, mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
requesterReqID := "req-123"
params := proapi.GetPatronRequestsParams{
Side: &lendingString,
Symbol: &symbol,
RequesterReqId: &requesterReqID,
}
handler.GetPatronRequests(rr, req, params)
assert.Equal(t, http.StatusOK, rr.Code)
if assert.NotNil(t, repo.cql) {
assert.Contains(t, *repo.cql, "requester_req_id = req-123")
assert.Contains(t, *repo.cql, "side = lending")
assert.Contains(t, *repo.cql, "supplier_symbol = ISIL:REQ")
}
}
func TestPostPatronRequests(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
id := "1"
toCreate := proapi.CreatePatronRequest{
Id: &id,
RequesterSymbol: &symbol,
IllRequest: validIllRequest(),
}
jsonBytes, err := json.Marshal(toCreate)
assert.NoError(t, err, "failed to marshal patron request")
req, err := http.NewRequest("POST", "/", bytes.NewBuffer(jsonBytes))
assert.NoError(t, err, "failed to create request")
rr := httptest.NewRecorder()
tenant := proapi.Tenant("test-lib")
handler.PostPatronRequests(rr, req, proapi.PostPatronRequestsParams{XOkapiTenant: &tenant})
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestPostPatronRequestsMissingSymbol(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
toCreate := proapi.PatronRequest{Id: "1"}
jsonBytes, err := json.Marshal(toCreate)
assert.NoError(t, err, "failed to marshal patron request")
req, err := http.NewRequest("POST", "/", bytes.NewBuffer(jsonBytes))
assert.NoError(t, err, "failed to create request")
rr := httptest.NewRecorder()
tenant := proapi.Tenant("test-lib")
handler.PostPatronRequests(rr, req, proapi.PostPatronRequestsParams{XOkapiTenant: &tenant})
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "symbol must be specified")
}
func TestPostPatronRequestsInvalidJson(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("POST", "/", bytes.NewBuffer([]byte("a\": v\"")))
rr := httptest.NewRecorder()
tenant := proapi.Tenant("test-lib")
handler.PostPatronRequests(rr, req, proapi.PostPatronRequestsParams{XOkapiTenant: &tenant})
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "invalid character")
}
func TestPostPatronRequestsInvalidIllRequestShape(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
jsonBytes := []byte(`{
"id":"1",
"requesterSymbol":"` + symbol + `",
"illRequest":{"header":"invalid"}
}`)
req, err := http.NewRequest("POST", "/", bytes.NewBuffer(jsonBytes))
assert.NoError(t, err, "failed to create request")
rr := httptest.NewRecorder()
tenant := proapi.Tenant("test-lib")
handler.PostPatronRequests(rr, req, proapi.PostPatronRequestsParams{XOkapiTenant: &tenant})
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "illRequest")
}
func TestDeletePatronRequestsIdNotFound(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("POST", "/", nil)
rr := httptest.NewRecorder()
handler.DeletePatronRequestsId(rr, req, "2", proapi.DeletePatronRequestsIdParams{Symbol: &symbol})
assert.Equal(t, http.StatusNotFound, rr.Code)
}
func TestDeletePatronRequestsIdMissingSymbol(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("POST", "/", nil)
rr := httptest.NewRecorder()
handler.DeletePatronRequestsId(rr, req, "2", proapi.DeletePatronRequestsIdParams{})
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "symbol must be specified")
}
func TestDeletePatronRequestsIdError(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("POST", "/", nil)
rr := httptest.NewRecorder()
handler.DeletePatronRequestsId(rr, req, "1", proapi.DeletePatronRequestsIdParams{Symbol: &symbol})
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestDeletePatronRequestsId(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("POST", "/", nil)
rr := httptest.NewRecorder()
handler.DeletePatronRequestsId(rr, req, "3", proapi.DeletePatronRequestsIdParams{Symbol: &symbol, Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestDeletePatronRequestsIdDeleted(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("POST", "/", nil)
rr := httptest.NewRecorder()
handler.DeletePatronRequestsId(rr, req, "4", proapi.DeletePatronRequestsIdParams{Symbol: &symbol, Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusNoContent, rr.Code)
}
func TestGetPatronRequestsIdMissingSymbol(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("POST", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsId(rr, req, "2", proapi.GetPatronRequestsIdParams{})
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "symbol must be specified")
}
func TestGetPatronRequestsIdNotFound(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("POST", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsId(rr, req, "2", proapi.GetPatronRequestsIdParams{Symbol: &symbol})
assert.Equal(t, http.StatusNotFound, rr.Code)
}
func TestGetPatronRequestsId(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("POST", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsId(rr, req, "1", proapi.GetPatronRequestsIdParams{Symbol: &symbol})
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestGetPatronRequestsIdActions(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdActions(rr, req, "3", proapi.GetPatronRequestsIdActionsParams{Symbol: &symbol, Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusOK, rr.Code)
assert.Equal(t, "{\"actions\":[]}\n", rr.Body.String())
}
func TestGetPatronRequestsIdActionsNoSymbol(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdActions(rr, req, "3", proapi.GetPatronRequestsIdActionsParams{Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "symbol must be specified")
}
func TestGetPatronRequestsIdActionsDbError(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdActions(rr, req, "1", proapi.GetPatronRequestsIdActionsParams{Symbol: &symbol, Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestGetPatronRequestsIdActionsNotFoundBecauseOfSide(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdActions(rr, req, "3", proapi.GetPatronRequestsIdActionsParams{Symbol: &symbol, Side: &proapiLendingSide})
assert.Equal(t, http.StatusNotFound, rr.Code)
assert.Contains(t, rr.Body.String(), "not found")
}
func TestPostPatronRequestsIdActionNoSymbol(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.PostPatronRequestsIdAction(rr, req, "3", proapi.PostPatronRequestsIdActionParams{Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "symbol must be specified")
}
func TestPostPatronRequestsIdActionDbError(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.PostPatronRequestsIdAction(rr, req, "1", proapi.PostPatronRequestsIdActionParams{Symbol: &symbol, Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestPostPatronRequestsIdActionNotFoundBecauseOfSide(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.PostPatronRequestsIdAction(rr, req, "3", proapi.PostPatronRequestsIdActionParams{Symbol: &symbol, Side: &proapiLendingSide})
assert.Equal(t, http.StatusNotFound, rr.Code)
assert.Contains(t, rr.Body.String(), "not found")
}
func TestPostPatronRequestsIdActionErrorParsing(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", strings.NewReader("{"))
rr := httptest.NewRecorder()
handler.PostPatronRequestsIdAction(rr, req, "3", proapi.PostPatronRequestsIdActionParams{Symbol: &symbol, Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "unexpected EOF")
}
func TestGetPatronRequestsIdEventsNoSymbol(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdEvents(rr, req, "3", proapi.GetPatronRequestsIdEventsParams{Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "symbol must be specified")
}
func TestGetPatronRequestsIdEventsDbError(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdEvents(rr, req, "1", proapi.GetPatronRequestsIdEventsParams{Symbol: &symbol, Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestGetPatronRequestsIdEventsNotFoundBecauseOfSide(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdEvents(rr, req, "3", proapi.GetPatronRequestsIdEventsParams{Symbol: &symbol, Side: &proapiLendingSide})
assert.Equal(t, http.StatusNotFound, rr.Code)
assert.Contains(t, rr.Body.String(), "not found")
}
func TestGetPatronRequestsIdEventsErrorGettingEvents(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, new(mocks.MockEventRepositoryError), common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdEvents(rr, req, "3", proapi.GetPatronRequestsIdEventsParams{Symbol: &symbol, Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestGetPatronRequestsIdNotificationsNoSymbol(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdNotifications(rr, req, "3", proapi.GetPatronRequestsIdNotificationsParams{Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusBadRequest, rr.Code)
assert.Contains(t, rr.Body.String(), "symbol must be specified")
}
func TestGetPatronRequestsIdNotificationsDbError(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdNotifications(rr, req, "1", proapi.GetPatronRequestsIdNotificationsParams{Symbol: &symbol, Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestGetPatronRequestsIdNotificationsNotFoundBecauseOfSide(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdNotifications(rr, req, "3", proapi.GetPatronRequestsIdNotificationsParams{Symbol: &symbol, Side: &proapiLendingSide})
assert.Equal(t, http.StatusNotFound, rr.Code)
assert.Contains(t, rr.Body.String(), "not found")
}
func TestGetPatronRequestsIdNotificationsErrorGettingEvents(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, new(mocks.MockEventRepositoryError), common.NewTenant(""), 10)
req, _ := http.NewRequest("GET", "/", nil)
rr := httptest.NewRecorder()
handler.GetPatronRequestsIdNotifications(rr, req, "3", proapi.GetPatronRequestsIdNotificationsParams{Symbol: &symbol, Side: &proapiBorrowingSide})
assert.Equal(t, http.StatusInternalServerError, rr.Code)
assert.Contains(t, rr.Body.String(), "DB error")
}
func TestParseAndValidateIllRequestAndBuildDbPatronRequest(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
ctx := common.CreateExtCtxWithArgs(context.Background(), &common.LoggerArgs{})
creationTime := time.Now()
id := uuid.NewString()
reqWithID := &proapi.CreatePatronRequest{
Id: &id,
RequesterSymbol: &symbol,
IllRequest: validIllRequest(),
}
illRequest, requesterReqID, err := handler.parseAndValidateIllRequest(ctx, reqWithID, creationTime)
assert.NoError(t, err)
assert.Equal(t, id, requesterReqID)
pr := buildDbPatronRequest(reqWithID, nil, pgtype.Timestamp{Valid: true, Time: creationTime}, requesterReqID, illRequest)
assert.Equal(t, id, pr.ID)
assert.True(t, pr.CreatedAt.Valid)
assert.True(t, pr.RequesterReqID.Valid)
assert.Equal(t, id, pr.RequesterReqID.String)
assert.False(t, pr.SupplierSymbol.Valid)
reqWithoutID := &proapi.CreatePatronRequest{RequesterSymbol: &symbol}
_, _, err = handler.parseAndValidateIllRequest(ctx, reqWithoutID, creationTime)
assert.Error(t, err)
assert.True(t, errors.Is(err, errInvalidPatronRequest))
}
func TestParseAndValidateIllRequestInvalidRequesterSymbol(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
ctx := common.CreateExtCtxWithArgs(context.Background(), &common.LoggerArgs{})
invalidSymbol := "REQ"
_, _, err := handler.parseAndValidateIllRequest(ctx, &proapi.CreatePatronRequest{RequesterSymbol: &invalidSymbol}, time.Now())
assert.Error(t, err)
assert.True(t, errors.Is(err, errInvalidPatronRequest))
}
func TestParseAndValidateIllRequestInvalidBrokerSymbol(t *testing.T) {
handler := NewPrApiHandler(new(PrRepoError), mockEventBus, mockEventRepo, common.NewTenant(""), 10)
ctx := common.CreateExtCtxWithArgs(context.Background(), &common.LoggerArgs{})
previousBrokerSymbol := brokerSymbol
brokerSymbol = "BROKER"
defer func() {
brokerSymbol = previousBrokerSymbol
}()
_, _, err := handler.parseAndValidateIllRequest(ctx, &proapi.CreatePatronRequest{
RequesterSymbol: &symbol,
IllRequest: validIllRequest(),
}, time.Now())
assert.Error(t, err)
assert.Contains(t, err.Error(), "invalid BROKER_SYMBOL")
}
type PrRepoError struct {
mock.Mock
pr_db.PgPrRepo
counter int64
}
type PrRepoCapture struct {
PrRepoError
cql *string
}
func (r *PrRepoCapture) ListPatronRequests(ctx common.ExtendedContext, args pr_db.ListPatronRequestsParams, cql *string) ([]pr_db.PatronRequest, int64, error) {
r.cql = cql
return []pr_db.PatronRequest{}, 0, nil
}
func (r *PrRepoError) WithTxFunc(ctx common.ExtendedContext, fn func(repo pr_db.PrRepo) error) error {
return fn(r)
}
func (r *PrRepoError) GetPatronRequestById(ctx common.ExtendedContext, id string) (pr_db.PatronRequest, error) {
switch id {
case "2":
return pr_db.PatronRequest{}, pgx.ErrNoRows
case "3", "4":
return pr_db.PatronRequest{ID: id, State: prservice.BorrowerStateNew, Side: prservice.SideBorrowing, RequesterSymbol: pgtype.Text{String: symbol, Valid: true}}, nil
default:
return pr_db.PatronRequest{}, errors.New("DB error")
}
}
func (r *PrRepoError) ListPatronRequests(ctx common.ExtendedContext, args pr_db.ListPatronRequestsParams, cql *string) ([]pr_db.PatronRequest, int64, error) {
return []pr_db.PatronRequest{}, 0, errors.New("DB error")
}
func (r *PrRepoError) UpdatePatronRequest(ctx common.ExtendedContext, params pr_db.UpdatePatronRequestParams) (pr_db.PatronRequest, error) {
return pr_db.PatronRequest{}, errors.New("DB error")
}
func (r *PrRepoError) CreatePatronRequest(ctx common.ExtendedContext, params pr_db.CreatePatronRequestParams) (pr_db.PatronRequest, error) {
return pr_db.PatronRequest{}, errors.New("DB error")
}
func (r *PrRepoError) DeletePatronRequest(ctx common.ExtendedContext, id string) error {
if id == "4" {
return nil
}
return errors.New("DB error")
}
func (r *PrRepoError) GetNextHrid(ctx common.ExtendedContext, prefix string) (string, error) {
r.counter++
return strings.ToUpper(prefix) + "-" + strconv.FormatInt(r.counter, 10), nil
}
func (r *PrRepoError) GetNotificationsByPrId(ctx common.ExtendedContext, prId string) ([]pr_db.Notification, error) {
return []pr_db.Notification{}, errors.New("DB error")
}
type MockEventBus struct {
mock.Mock
events.EventBus
}