fix: digits overflow

Author: indriApollo

Lib/BelgianStructuredCommunication.csproj

@@ -6,7 +6,7 @@
         <Nullable>enable</Nullable>
         <RootNamespace>IndriApollo.BelgianStructuredCommunication</RootNamespace>
         <IsPackable>true</IsPackable>
-        <Version>1.0.1</Version>
+        <Version>1.1.0</Version>
     </PropertyGroup>
 
     <PropertyGroup>

Lib/Communication.cs

@@ -6,11 +6,11 @@ namespace IndriApollo.BelgianStructuredCommunication;
 
 public partial class Communication : IParsable<Communication>
 {
-    public uint Digits { get; }
+    public ulong Digits { get; }
     public byte CheckSum { get; }
     public bool ValidChecksum { get; }
 
-    public Communication(uint digits) : this(digits.ToString("D10"))
+    public Communication(ulong digits) : this(digits.ToString("D10"))
     {
     }
 
@@ -25,7 +25,7 @@ public Communication(string digits, string? checksum = null)
         if (digits.Length != 10)
             throw new ArgumentException("Digits must be 10 characters", nameof(digits));
 
-        Digits = uint.Parse(digits, NumberStyles.None, CultureInfo.InvariantCulture);
+        Digits = ulong.Parse(digits, NumberStyles.None, CultureInfo.InvariantCulture);
 
         var computedCheckSum = ComputeCheckSum(Digits);
         CheckSum = checksum is not null
@@ -89,7 +89,7 @@ public static bool TryParse([NotNullWhen(true)] string? s, IFormatProvider? prov
         return true;
     }
 
-    private static byte ComputeCheckSum(uint digits)
+    private static byte ComputeCheckSum(ulong digits)
     {
         return (byte)(digits % 97);
     }
@@ -104,5 +104,5 @@ public override string ToString()
     private static partial Regex CommunicationRegex();
 }
 
-public class InvalidChecksumException(byte expected, byte actual, uint digits)
+public class InvalidChecksumException(byte expected, byte actual, ulong digits)
     : Exception($"Expected {expected:D2} but got {actual:D2} for {digits:D10}");

Tests/CommunicationTests.cs

@@ -6,15 +6,17 @@ namespace Tests;
 public class CommunicationTests
 {
     [Theory]
-    [InlineData("+++ 085 / 1927 / 54115 +++")]
-    [InlineData("+++085/1927/54115+++")]
-    [InlineData("085192754115")]
-    public void GivenWellFormattedCommunication_WhenParse_ThenSuccess(string communicationStr)
+    [InlineData("+++ 085 / 1927 / 54115 +++", 851927541, 15)]
+    [InlineData("+++085/1927/54115+++", 851927541, 15)]
+    [InlineData("085192754115", 851927541, 15)]
+    [InlineData("999999999948", 9999999999, 48)]
+    public void GivenWellFormattedCommunication_WhenParse_ThenSuccess(string communicationStr,
+        ulong expectedDigits, byte expectedCheckSum)
     {
         var communication = Communication.Parse(communicationStr);
 
-        Assert.Equal((uint)851927541, communication.Digits);
-        Assert.Equal(15, communication.CheckSum);
+        Assert.Equal(expectedDigits, communication.Digits);
+        Assert.Equal(expectedCheckSum, communication.CheckSum);
         Assert.True(communication.ValidChecksum);
     }