Check constraint for empty strings by default, allow override with AllowEmptyString

Author: peldax

src/Attribute/AllowEmptyString.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace CoolBeans\Attribute;
+
+#[\Attribute(\Attribute::TARGET_PROPERTY)]
+final class AllowEmptyString
+{
+}

src/Attribute/UniqueConstraint.php

@@ -7,7 +7,4 @@
 #[\Attribute(\Attribute::TARGET_PROPERTY)]
 final class UniqueConstraint
 {
-    public function __construct()
-    {
-    }
 }

src/Command/SqlGeneratorCommand.php

@@ -406,6 +406,16 @@ private static function getCheck(\ReflectionProperty $property, string $beanName
             $return[] = self::INDENTATION . 'CONSTRAINT `' . $constraintName . '` CHECK (' . $attribute->newInstance()->expression . ')';
         }
 
+        $type = $property->getType();
+
+        if ($type instanceof \ReflectionNamedType &&
+            $type->isBuiltin() &&
+            $type->getName() === 'string' &&
+            \count($property->getAttributes(\CoolBeans\Attribute\AllowEmptyString::class)) === 0) {
+            $constraintName = 'check_' . $beanName . '_' . $property->getName() . '_string_not_empty';
+            $return[] = self::INDENTATION . 'CONSTRAINT `' . $constraintName . '` CHECK (`' . $property->name . '` != \'\')';
+        }
+
         return $return;
     }
 

tests/Unit/Command/SqlGeneratorCommandTest.php

@@ -27,6 +27,9 @@ public function testSimple() : void
 
             CONSTRAINT `check_SimpleBean2_0` CHECK (IF(`col3` = 'abc', `col4` IS NOT NULL, TRUE)),
             CONSTRAINT `check_SimpleBean2_col3_0` CHECK (CHAR_LENGTH(`col3`) > 3),
+            CONSTRAINT `check_SimpleBean2_col3_string_not_empty` CHECK (`col3` != ''),
+            CONSTRAINT `check_SimpleBean2_col4_string_not_empty` CHECK (`col4` != ''),
+            CONSTRAINT `check_SimpleBean2_col6_string_not_empty` CHECK (`col6` != ''),
 
             PRIMARY KEY (`id`)
         )
@@ -44,6 +47,11 @@ public function testSimple() : void
 
             CONSTRAINT `unique_SimpleBeanAttribute_col3` UNIQUE (`col3`),
 
+            CONSTRAINT `check_SimpleBeanAttribute_col3_string_not_empty` CHECK (`col3` != ''),
+            CONSTRAINT `check_SimpleBeanAttribute_col4_string_not_empty` CHECK (`col4` != ''),
+            CONSTRAINT `check_SimpleBeanAttribute_col5_string_not_empty` CHECK (`col5` != ''),
+            CONSTRAINT `check_SimpleBeanAttribute_col6_string_not_empty` CHECK (`col6` != ''),
+
             PRIMARY KEY (`id`)
         )
             CHARSET = `utf8mb4`
@@ -119,6 +127,8 @@ public function testSimple() : void
             CONSTRAINT `unique_AttributeBean_col5` UNIQUE (`col5`),
             CONSTRAINT `unique_AttributeBean_col6` UNIQUE (`col6`),
 
+            CONSTRAINT `check_AttributeBean_code_string_not_empty` CHECK (`code` != ''),
+
             PRIMARY KEY (`code`)
         )
             CHARSET = `utf8mb4`
@@ -144,6 +154,11 @@ public function testSimple() : void
         
             FOREIGN KEY (`simple_bean_2_id`) REFERENCES `simple_bean_2`(`id`) ON UPDATE RESTRICT ON DELETE RESTRICT,
 
+            CONSTRAINT `check_SimpleBean1_col3_string_not_empty` CHECK (`col3` != ''),
+            CONSTRAINT `check_SimpleBean1_col4_string_not_empty` CHECK (`col4` != ''),
+            CONSTRAINT `check_SimpleBean1_col5_string_not_empty` CHECK (`col5` != ''),
+            CONSTRAINT `check_SimpleBean1_col6_string_not_empty` CHECK (`col6` != ''),
+
             PRIMARY KEY (`id`)
         )
             CHARSET = `utf8mb4`

tests/Unit/TestBean/SimpleBean2.php

@@ -15,6 +15,7 @@ final class SimpleBean2 extends \CoolBeans\Bean
     #[\CoolBeans\Attribute\CheckConstraint('CHAR_LENGTH(`col3`) > 3')]
     public string $col3;
     public ?string $col4;
+    #[\CoolBeans\Attribute\AllowEmptyString]
     public ?string $col5 = null;
     public ?string $col6 = 'default';
     public \DateTime $col8;

tests/Unit/TestBean/SimpleBeanClassAttribute.php

@@ -14,9 +14,13 @@ final class SimpleBeanClassAttribute extends \CoolBeans\Bean
     private int $col1;
     protected string $col2 = 'default';
     public \CoolBeans\PrimaryKey\IntPrimaryKey $id;
+    #[\CoolBeans\Attribute\AllowEmptyString]
     public string $col3;
+    #[\CoolBeans\Attribute\AllowEmptyString]
     public ?string $col4;
+    #[\CoolBeans\Attribute\AllowEmptyString]
     public ?string $col5 = null;
+    #[\CoolBeans\Attribute\AllowEmptyString]
     public ?string $col6 = 'default';
     public \DateTime $col8;
     public \Nette\Utils\DateTime $col9;

tests/Unit/TestBean/SimpleBeanClassAttribute2.php

@@ -13,9 +13,13 @@ final class SimpleBeanClassAttribute2 extends \CoolBeans\Bean
     private int $col1;
     protected string $col2 = 'default';
     public \CoolBeans\PrimaryKey\IntPrimaryKey $id;
+    #[\CoolBeans\Attribute\AllowEmptyString]
     public string $col3;
+    #[\CoolBeans\Attribute\AllowEmptyString]
     public ?string $col4;
+    #[\CoolBeans\Attribute\AllowEmptyString]
     public ?string $col5 = null;
+    #[\CoolBeans\Attribute\AllowEmptyString]
     public ?string $col6 = 'default';
     public \DateTime $col8;
     public \Nette\Utils\DateTime $col9;