Fix UnmergeMergedRooms creating up-exits in dropzones below segmented rooms

initsu · initsu · commit 21f2e8433bc3 · 2025-11-25T13:05:17.000+01:00
diff --git a/RandomizerCore/Sidescroll/CoordinatePalaceGenerator.cs b/RandomizerCore/Sidescroll/CoordinatePalaceGenerator.cs
@@ -245,12 +245,18 @@ private static void UnmergeMergedRooms(Palace palace, RoomPool roomPool)
                 if (newPrimaryRoom.HasDownExit)
                 {
                     newPrimaryRoom.Down = primaryRoom.Down;
-                    primaryRoom.Down.Up = newPrimaryRoom;
+                    if (primaryRoom.Down.HasUpExit)
+                    {
+                        primaryRoom.Down.Up = newPrimaryRoom;
+                    }
                 }
                 else if (secondaryRoom.HasDownExit)
                 {
                     secondaryRoom.Down = primaryRoom.Down;
-                    primaryRoom.Down.Up = secondaryRoom;
+                    if (primaryRoom.Down.HasUpExit)
+                    {
+                        primaryRoom.Down.Up = secondaryRoom;
+                    }
                 }
             }
             if (primaryRoom.Left != null)

Original file line number	Diff line number	Diff line change
`@@ -245,12 +245,18 @@ private static void UnmergeMergedRooms(Palace palace, RoomPool roomPool)`
`245`	`245`	`if (newPrimaryRoom.HasDownExit)`
`246`	`246`	`{`
`247`	`247`	`newPrimaryRoom.Down = primaryRoom.Down;`
`248`		`- primaryRoom.Down.Up = newPrimaryRoom;`
	`248`	`+ if (primaryRoom.Down.HasUpExit)`
	`249`	`+ {`
	`250`	`+ primaryRoom.Down.Up = newPrimaryRoom;`
	`251`	`+ }`
`249`	`252`	`}`
`250`	`253`	`else if (secondaryRoom.HasDownExit)`
`251`	`254`	`{`
`252`	`255`	`secondaryRoom.Down = primaryRoom.Down;`
`253`		`- primaryRoom.Down.Up = secondaryRoom;`
	`256`	`+ if (primaryRoom.Down.HasUpExit)`
	`257`	`+ {`
	`258`	`+ primaryRoom.Down.Up = secondaryRoom;`
	`259`	`+ }`
`254`	`260`	`}`
`255`	`261`	`}`
`256`	`262`	`if (primaryRoom.Left != null)`