Skip to content

Commit b440f54

Browse files
stofrobocoder
authored andcommitted
Fix the setup for uploads in the CI tests
Older selenium versions support a non-standard feature to upload a file to the runner, which is used by the Mink driver when available. Newer Selenium versions implementing the W3C protocol don't support this anymore. Attaching a file to a file input requires using a file path that already exists on the runner. this configures the Mink testsuite to properly share the fixtures with the docker image of the runner.
1 parent 184c8c4 commit b440f54

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
- name: Start Selenium & Mink test server
4444
run: |
4545
mkdir logs
46-
docker run --net host --name selenium --volume /dev/shm:/dev/shm --shm-size 2g "selenium/standalone-firefox:${{ matrix.selenium }}" &> logs/selenium.log &
46+
docker run --net host --name selenium --volume /dev/shm:/dev/shm --volume ./vendor/mink/driver-testsuite/web-fixtures:/fixtures --shm-size 2g "selenium/standalone-firefox:${{ matrix.selenium }}" &> logs/selenium.log &
4747
vendor/bin/mink-test-server &> logs/mink-test-server.log &
4848
while ! nc -z localhost 4444 </dev/null; do echo Waiting for remote driver to start...; sleep 1; done
4949
while ! nc -z localhost 8002 </dev/null; do echo Waiting for PHP server to start...; sleep 1; done
@@ -56,3 +56,4 @@ jobs:
5656
SELENIUM_VERSION: ${{ matrix.selenium }}
5757
WEB_FIXTURES_BROWSER: firefox
5858
TEST_MACHINE_BASE_PATH: ${{ github.workspace }}/vendor/mink/driver-testsuite/web-fixtures/
59+
DRIVER_MACHINE_BASE_PATH: /fixtures/

0 commit comments

Comments
 (0)