Merge pull request #56 from intercreate/fix/mtu-defaults

fix: use smpclient upstream mtu defaults

Author: JPHutchins

smpmgr/common.py

@@ -34,7 +34,7 @@ class TransportDefinition:
 class Options:
     timeout: float
     transport: TransportDefinition
-    mtu: int
+    mtu: int | None
 
 
 def get_custom_smpclient(options: Options, smp_client_cls: Type[TSMPClient]) -> TSMPClient:
@@ -59,13 +59,8 @@ def get_custom_smpclient(options: Options, smp_client_cls: Type[TSMPClient]) ->
             options.transport.ble,
         )
     elif options.transport.ip is not None:
-        logger.info(
-            f"Initializing SMPClient with the SMPUDPTransport, {options.transport.ip=} and MTU 1024"
-        )
-        return smp_client_cls(
-            SMPUDPTransport(1024),
-            options.transport.ip,
-        )
+        logger.info(f"Initializing SMPClient with the SMPUDPTransport, {options.transport.ip=}")
+        return smp_client_cls(SMPUDPTransport(), options.transport.ip)
     else:
         typer.echo(
             f"A transport option is required; "

smpmgr/main.py

@@ -80,11 +80,13 @@ def options(
         2.0,
         help="Transport timeout in seconds; how long to wait for initial connection and requests.",
     ),
-    mtu: int = typer.Option(
-        4096,
+    mtu: int
+    | None = typer.Option(
+        None,
         help=(
             "Maximum transmission unit supported by the SMP server serial transport."
-            "  Ignored for BLE transport since the BLE connection will report MTU."
+            " Will default to smpclient upstream value."
+            " Ignored for BLE transport since the BLE connection will report MTU."
         ),
     ),
     loglevel: LogLevel = typer.Option(None, help="Debug log level"),