update

Author: detain

.claude/skills/add-event-handler/SKILL.md

@@ -26,14 +26,14 @@ description: Adds a new GitHub event type case to the switch block in `web/githu
        $Url     = $Entity['html_url'] ?? '';
        $Title   = $Entity['title']   ?? $Entity['name'] ?? '';
 
-       $ChatMsg = "🔔 [{$User}](https://github.com/{$User}) **{$Action}** "
+       $ChatMsg = "\u{1F514} [{$User}](https://github.com/{$User}) **{$Action}** "
                 . "[{$Title}]({$Url}) "
                 . "in [{$RepositoryName}](https://github.com/{$RepositoryName}).";
 
        // Optional: append body preview (max 500 chars)
        if (!empty($Entity['body'])) {
            $ChatMsg .= "\n\n> " . substr($Entity['body'], 0, 500)
-                    . (strlen($Entity['body']) > 500 ? "…" : "");
+                    . (strlen($Entity['body']) > 500 ? "\u2026" : "");
        }
 
        $Msg['text'] = $ChatMsg;
@@ -71,7 +71,7 @@ description: Adds a new GitHub event type case to the switch block in `web/githu
 6. **Add a test fixture** under `tests/events/<event_name>/`:
    - `payload.json` — raw GitHub webhook payload (copy from GitHub delivery logs or docs)
    - `type.txt` — event name only, e.g. `your_event` (no trailing newline needed; `trim()` is applied)
-   - Note: `expected.bin` / `discord.json` are consumed by `IrcConverter`/`DiscordConverter` tests, not by `web/github.php` — add them only if those converters also need updating.
+   - `expected_text.txt` — expected chat message text; run `vendor/bin/phpunit tests/GithubMessageBuilderTest.php`, capture actual output, write to file
 
 7. **Run quality checks** to verify no syntax errors or style violations:
    ```bash
@@ -94,20 +94,20 @@ description: Adds a new GitHub event type case to the switch block in `web/githu
        $Url       = $Milestone['html_url'] ?? '';
        $Title     = $Milestone['title'] ?? '';
 
-       $ChatMsg = "🏁 [{$User}](https://github.com/{$User}) **{$Action}** "
+       $ChatMsg = "\u{1F3C1} [{$User}](https://github.com/{$User}) **{$Action}** "
                 . "milestone [{$Title}]({$Url}) "
                 . "in [{$RepositoryName}](https://github.com/{$RepositoryName}).";
 
        if (!empty($Milestone['description'])) {
            $ChatMsg .= "\n\n> " . substr($Milestone['description'], 0, 500)
-                    . (strlen($Milestone['description']) > 500 ? "…" : "");
+                    . (strlen($Milestone['description']) > 500 ? "\u2026" : "");
        }
 
        $Msg['text'] = $ChatMsg;
        SendToChat('notifications', $Msg, $useRC, $useTeams);
        break;
    ```
-3. Created `tests/events/milestone/payload.json` and `tests/events/milestone/type.txt` containing `milestone`.
+3. Created `tests/events/milestone/payload.json`, `tests/events/milestone/type.txt` (`milestone`), and `tests/events/milestone/expected_text.txt`.
 4. Ran `vendor/bin/phpstan analyse` — no errors.
 
 **Result:** `milestone` events POST to Rocket Chat and Teams with action, linked title, and optional description preview.
@@ -122,4 +122,4 @@ description: Adds a new GitHub event type case to the switch block in `web/githu
 
 - **Event still hits `default:`**: The `$EventType` string comes from the `X-GitHub-Event` header. Verify your `case` string matches exactly (lowercase, underscores) — e.g. `'pull_request'` not `'pullRequest'`.
 
-- **`SendToChat` returns `false` silently**: The channel key `'notifications'` must exist in both `$chatChannels['rocketchat']` and `$chatChannels['teams']` in `src/config.php`. If the URL is missing, curl will fail with HTTP 0.
+- **`SendToChat` returns `false` silently**: The channel key `'notifications'` must exist in both `$chatChannels['rocketchat']` and `$chatChannels['teams']` in `src/config.php`. If the URL is missing, curl will fail with HTTP 0.

.claude/skills/add-test-fixture/SKILL.md

@@ -1,37 +1,31 @@
 ---
 name: add-test-fixture
-description: Creates a new test event fixture directory under tests/events/{event_name}/ with payload.json, type.txt, expected.bin, and discord.json. Use when user says 'add test for X event', 'create fixture', 'test event payload', or needs to add files to tests/events/. Do NOT use for modifying existing fixtures or writing unit tests that don't involve GitHub webhook payloads.
+description: Creates a new test event fixture directory under tests/events/{event_name}/ with payload.json, type.txt, and expected_text.txt. Use when user says 'add test for X event', 'create fixture', 'test event payload', or needs to add files to tests/events/. Do NOT use for modifying existing fixtures or writing unit tests that don't involve GitHub webhook payloads.
 ---
 # Add Test Fixture
 
 ## Critical
 
-- Every fixture directory requires **all four files** — `EventTest.php:64` calls `file_get_contents` on all four unconditionally; missing any will cause a fatal test error:
+- Every fixture directory requires **three files** — `GithubMessageBuilderTest.php` reads all three; missing any will cause a fatal test error:
   ```
   tests/events/deployment/type.txt
   tests/events/deployment/payload.json
-  tests/events/deployment/expected.bin
-  tests/events/deployment/discord.json
+  tests/events/deployment/expected_text.txt
   ```
-- `expected.bin` contains IRC color codes (non-printable bytes) — **never hand-write it**. Use the generation workflow in Step 4.
-- The value in `tests/events/deployment/type.txt` must match the `X-GitHub-Event` header value exactly (e.g. `push`, `pull_request`, `ping`) — no trailing newline issues; `EventTest.php:61` trims it.
+- `expected_text.txt` contains plain-text chat message output — **generate it by running the test harness**, not by hand.
+- The value in `tests/events/deployment/type.txt` must match the `X-GitHub-Event` header value exactly (e.g. `push`, `pull_request`, `ping`) — no trailing newline issues; the test trims it.
 
 ## Instructions
 
 1. **Create the fixture directory.**
-   ```bash
-   mkdir tests/events/deployment
-   ```
    Use the GitHub event name as the directory name (e.g. `deployment`, `workflow_dispatch`). For action variants, append `_{action}` (e.g. `pull_request_merged`, `issue_closed`). Verify no existing directory with that name exists under `tests/events/`.
 
 2. **Write the event type file.**
-   ```bash
-   echo -n 'deployment' > tests/events/deployment/type.txt
-   ```
    Content is the bare event type only — no action suffix, no newline required (the test trims it). Matches the value GitHub sends in the `X-GitHub-Event` HTTP header.
+   Write `deployment` to `tests/events/deployment/type.txt`.
 
 3. **Write the payload file.**
-   Save a real GitHub webhook payload to `tests/events/deployment/payload.json`. Mirror the formatting of existing fixtures — tabs for indentation, escaped forward-slashes (`\/`), `JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES` style:
+   Save a real GitHub webhook payload to `tests/events/deployment/payload.json`. Mirror the formatting of existing fixtures — tabs for indentation, `JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES` style:
    ```json
    {
    	"action": "created",
@@ -55,24 +49,17 @@ description: Creates a new test event fixture directory under tests/events/{even
    ```
    Must print `0`.
 
-4. **Generate the binary and Discord files using the test harness.**
-   In `tests/EventTest.php`, uncomment the two generation lines (lines 27 and 38):
-   ```php
-   file_put_contents( $Path . '/expected.bin', $Message . "\n" );
-   // and
-   file_put_contents( $Path . '/discord.json', json_encode( $Discord, JSON_PRETTY_PRINT ) . "\n" );
-   ```
-   Run only the new fixture:
+4. **Generate `expected_text.txt` using the test suite.**
+   Run the tests — the new fixture will fail and print the actual output. Use that output as the content of `expected_text.txt`, then re-run to confirm it passes:
    ```bash
-   vendor/bin/phpunit --filter testEvent --group default tests/EventTest.php
+   vendor/bin/phpunit tests/GithubMessageBuilderTest.php
    ```
-   This writes the real IRC-formatted output (with color codes) to `tests/events/deployment/expected.bin` and the Discord embed to `tests/events/deployment/discord.json`. **Re-comment both lines immediately after**; leaving them uncommented will overwrite all fixtures on every test run.
 
 5. **Verify the fixture passes.**
    ```bash
-   vendor/bin/phpunit tests/EventTest.php
+   vendor/bin/phpunit tests/GithubMessageBuilderTest.php
    ```
-   All tests must pass. If the new fixture is listed as a failure, inspect the generated `tests/events/deployment/expected.bin` content and compare against `web/github.php`'s handler for that event type.
+   All tests must pass.
 
 ## Examples
 
@@ -82,19 +69,14 @@ description: Creates a new test event fixture directory under tests/events/{even
 1. Create `tests/events/deployment/`
 2. Write `tests/events/deployment/type.txt` → `deployment`
 3. Write `tests/events/deployment/payload.json` with a real GitHub deployment payload
-4. Uncomment lines 27 & 38 in `tests/EventTest.php`, run `vendor/bin/phpunit tests/EventTest.php`, re-comment
-5. Verify `tests/events/deployment/expected.bin` and `tests/events/deployment/discord.json` were written and tests pass
+4. Run `vendor/bin/phpunit tests/GithubMessageBuilderTest.php`, capture actual output, write to `tests/events/deployment/expected_text.txt`
+5. Re-run tests to verify they pass
 
-**Result:** `tests/events/deployment/` contains all four files; `vendor/bin/phpunit tests/EventTest.php` exits green.
+**Result:** `tests/events/deployment/` contains all three files; `vendor/bin/phpunit tests/GithubMessageBuilderTest.php` exits green.
 
 ## Common Issues
 
-- **`file_get_contents(...): Failed to open stream`** — one of the four required files is missing. Check `tests/events/deployment/` contains `tests/events/deployment/type.txt`, `tests/events/deployment/payload.json`, `tests/events/deployment/expected.bin`, `tests/events/deployment/discord.json`.
-- **`assertEquals failed: expected '' got '[10GitHub-WebHook]...'`** — `tests/events/deployment/expected.bin` is empty or was hand-written without IRC codes. Re-run Step 4 generation.
-- **`json_decode` returns null for `discord.json`** — `tests/events/deployment/discord.json` was hand-written with invalid JSON. Re-run Step 4 or validate:
-  ```bash
-  php -r "var_dump(json_decode(file_get_contents('tests/events/deployment/discord.json')));"  
-  ```
-  Must not print `NULL`.
-- **New fixture not picked up by test runner** — confirm the directory is directly under `tests/events/` (not nested). `EventTest.php:51` uses a single-level `DirectoryIterator`.
+- **`file_get_contents(...): Failed to open stream`** — one of the three required files is missing. Check `tests/events/deployment/` contains `type.txt`, `payload.json`, `expected_text.txt`.
+- **`assertEquals failed`** — `expected_text.txt` content doesn't match actual output. Re-run the test, capture actual output, update the file.
+- **New fixture not picked up by test runner** — confirm the directory is directly under `tests/events/` (not nested). The test uses a single-level `DirectoryIterator`.
 - **`GetEventType()` assertion fails** — `tests/events/deployment/type.txt` contains extra whitespace or wrong casing. The value must exactly match the GitHub `X-GitHub-Event` header (all lowercase, underscores, e.g. `pull_request` not `Pull-Request`).

CALIBER_LEARNINGS.md

@@ -0,0 +1,10 @@
+# Caliber Learnings
+
+Accumulated patterns and anti-patterns from development sessions.
+Auto-managed by [caliber](https://github.com/caliber-ai-org/ai-setup) — do not edit manually.
+
+- **[gotcha:project]** The existing test files (`tests/EventTest.php`, `tests/IgnoredActionsThrowTest.php`, `tests/UnknownActionTest.php`, `tests/IgnoredEventTest.php`) all reference `IrcConverter` and `DiscordConverter` classes that no longer exist in `src/` — running `vendor/bin/phpunit` produces 61 errors about missing classes. These tests are stale and need to be rewritten against `GithubWebhook` directly.
+- **[fix:project]** `vendor/bin/phpunit` fails with "No such file or directory" if `vendor/` is not present — always run `composer install` first. The vendor directory is gitignored and absent after a fresh clone.
+- **[gotcha:project]** `composer.json` has no `autoload`, `autoload-dev`, or `scripts` sections — there is no PSR-4 autoloader and no `composer test` shortcut. Classes (`GithubWebhook`, `IgnoredEventException`, etc.) are loaded via manual `require` statements. Tests must bootstrap these manually or via a PHPUnit bootstrap file.
+- **[pattern:project]** Real GitHub webhook payloads live in `log/` as JSON files with structure `{"repo": "...", "event": "...", "data": {...payload...}}`. The `data` key holds the raw webhook payload — use these as authoritative source material when creating new fixtures under `tests/events/`.
+- **[gotcha:project]** In the `push` event handler, `$Msg['alias']` is set from `$Message['head_commit']['author']['name']` (commit author name), **not** `$Message['pusher']['name']`. These differ when CI or bots push commits authored by a human. Code that compares commit authors against the pusher must use `$Msg['alias']`, not `$Message['pusher']['name']`.

CLAUDE.md

@@ -15,7 +15,7 @@ vendor/bin/php-cs-fixer fix
 ## Architecture
 
 - **Entry**: `web/github.php` (active) · `web/github-old.php` (legacy, RC-only)
-- **Core**: `src/GithubWebhook.php` · `src/IgnoredEventException.php` · `src/NotImplementedException.php`
+- **Core**: `src/GithubWebhook.php` · `src/GithubMessageBuilder.php` · `src/IgnoredEventException.php` · `src/NotImplementedException.php`
 - **Config**: `src/config.php` (gitignored) — defines `GITHUB_WEBHOOKS_SECRET` and `$chatChannels['rocketchat']` / `$chatChannels['teams']`
 - **Logs**: `log/` — JSON files named `Ymd_His_eventtype_action_user_repo.json`
 - **Tests**: `tests/` via `phpunit.xml` · fixtures in `tests/events/{event_name}/`
@@ -67,8 +67,9 @@ SendToChat(string $Where, array $Payload, bool $useRC = true, bool $useTeams = t
 ## Test Fixtures
 
 Each event type has a directory under `tests/events/{event_name}/` containing:
-- A raw GitHub webhook payload JSON file
-- `type.txt` with the event name (see `tests/events/commit_comment/type.txt`)
+- `payload.json` — raw GitHub webhook payload
+- `type.txt` — event name (e.g. `tests/events/commit_comment/type.txt`)
+- `expected_text.txt` — expected chat message text output from `GithubMessageBuilder`
 
 ## Code Style
 

composer.json

@@ -2,5 +2,11 @@
     "require-dev": {
         "phpunit/phpunit": "^9.0",
         "phpstan/phpstan": "^0.12.53"
+    },
+    "scripts": {
+        "test": "vendor/bin/phpunit",
+        "analyse": "vendor/bin/phpstan analyse",
+        "cs-fix": "vendor/bin/php-cs-fixer fix",
+        "cs-check": "vendor/bin/php-cs-fixer fix --dry-run"
     }
 }

phpunit.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" colors="true" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" colors="true" bootstrap="tests/bootstrap.php" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
 	<testsuites>
 		<testsuite name="Tests">
 			<directory>tests</directory>