Pull Handler threw error but did not track it.

[cambot]

Somehow, I ended up with entries in SourceControl.Git.DeploymentLog where End Timestamp and Status are both blank:

SELECT *
  FROM SourceControl_Git.DeploymentLog
 WHERE EndTimestamp IS NULL

If a pull handler's OnPull() method ever throws an error, that information is not captured in the Deployment Log record, but it is returned and communicated back the call chain.

I do not know if this is related to #907 or not. Also, it is a little confusing that ForModifications() can return either the thrown exception OR the value of %OnSave().

[cambot]

When I fixed this locally, I started seeing an <External Interrupt> error when switching between branches with a lot of changes in the diff and the error appears to have happened 60 seconds after the deployment started.

Not sure if this helps, but here is the stack trace from the error status:

normalizeName+8^%Studio.SourceControl.Interface.1^18
e^NormalizeInternalName+11^SourceControl.Git.Utils.1^1A
e^InternalNameSet+1^SourceControl.Git.PackageManagerContext.1^1A
d^ForInternalName+2^SourceControl.Git.PackageManagerContext.1^12
e^OnBeforeLoad+1^SourceControl.Git.Extension.1^18
e^OnBeforeTimestamp+16^SourceControl.Git.Extension.1^1$
d^Exists+8^%Library.RoutineMgr.1^4$
d^Exists+7^%Library.RoutineMgr.1^2%
e^GetDate+1^%Library.RoutineMgr.1^13
e^SourceControlCheckIn+6^Ens.Deployment.Utils.1^1,
e^DeployCode+145^Ens.Deployment.Deploy.1^10
e^ImportPTD+4^SourceControl.Git.Production.1^1-
e^ImportItem+19^SourceControl.Git.Utils.1^1D
e^OnPull+44^SourceControl.Git.PullEventHandler.IncrementalLoad.1^1>
e^ForModifications+16^SourceControl.Git.PullEventHandler.1^1>
e^SyncIrisWithRepoThroughDiff+42^SourceControl.Git.Utils.1^1:
e^RunGitCommandWithInput+224^SourceControl.Git.Utils.1^1/
e^RunGitCommand+1^SourceControl.Git.Utils.1^10
e^RunGitWithArgs+5^SourceControl.Git.Utils.1^1.
d^SwitchBranch+9^SourceControl.Git.Utils.1^12