Add serial number defines for #159

Author: drebbe-intrepid

include/defines.h

@@ -4,7 +4,9 @@
 
 #define MODULE_NAME "ics.ics"
 #define MODULE_DESCRIPTION "Copyright Intrepid Control Systems, Inc."
-#define VSPY3_BUILD_VERSION 901
+
+#define MIN_BASE36_SERIAL (16796160)
+#define MAX_SERIAL (2176782335)
 
 // https://bugs.python.org/issue28769
 // 2.x     = char* PyString_AsString(return_value);

src/defines.cpp

@@ -7,6 +7,8 @@ int setup_module_defines(PyObject* module)
         return --result;
 
     result += PyModule_AddStringConstant(module, "BUILD_DATETIME", __DATE__ " " __TIME__);
+    result += PyModule_AddObject(module, "MIN_BASE36_SERIAL", PyLong_FromUnsignedLong(MIN_BASE36_SERIAL));
+    result += PyModule_AddObject(module, "MAX_SERIAL", PyLong_FromUnsignedLong(MAX_SERIAL));
 
     if (result == 0) {
         return 1;

src/exceptions.cpp

@@ -92,7 +92,7 @@ PyObject* _set_ics_exception_dev(PyObject* exception, PyObject* obj, char* msg,
         }
         char* b36sn = pyics_base36enc(PyNeoDevice_GetSerialNumber(obj));
         ss << PyNeoDevice_GetSerialNumber(obj);
-        if (b36sn != NULL && PyNeoDevice_GetSerialNumber(obj) >= 16796160 /* "0A0000" */) {
+        if (b36sn != NULL && PyNeoDevice_GetSerialNumber(obj) >= MIN_BASE36_SERIAL /* "0A0000" */) {
             ss << " - " << b36sn << ")";
         } else {
             ss << ")";