Fixed NeoDevice Serial number range check in ics exception (#157)

pierreluctg · Pierre-Luc Tessier Gagné · web-flow · commit 3c3446d58ee9 · 2023-08-29T11:13:45.000-04:00
Co-authored-by: Pierre-Luc Tessier Gagné &lt;ptessie3@ford.com&gt;
diff --git a/src/exceptions.cpp b/src/exceptions.cpp
@@ -92,7 +92,7 @@ PyObject* _set_ics_exception_dev(PyObject* exception, PyObject* obj, char* msg,
         }
         char* b36sn = pyics_base36enc(PyNeoDevice_GetSerialNumber(obj));
         ss << PyNeoDevice_GetSerialNumber(obj);
-        if (b36sn != NULL && PyNeoDevice_GetSerialNumber(obj) >= 604661760 /* "A00000" */) {
+        if (b36sn != NULL && PyNeoDevice_GetSerialNumber(obj) >= 16796160 /* "0A0000" */) {
             ss << " - " << b36sn << ")";
         } else {
             ss << ")";

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ PyObject* _set_ics_exception_dev(PyObject* exception, PyObject* obj, char* msg,`
`92`	`92`	`}`
`93`	`93`	`char* b36sn = pyics_base36enc(PyNeoDevice_GetSerialNumber(obj));`
`94`	`94`	`ss << PyNeoDevice_GetSerialNumber(obj);`
`95`		`- if (b36sn != NULL && PyNeoDevice_GetSerialNumber(obj) >= 604661760 /* "A00000" */) {`
	`95`	`+ if (b36sn != NULL && PyNeoDevice_GetSerialNumber(obj) >= 16796160 /* "0A0000" */) {`
`96`	`96`	`ss << " - " << b36sn << ")";`
`97`	`97`	`} else {`
`98`	`98`	`ss << ")";`