Py_BuildValue with format "s" take in a const char *

pierreluctg · drebbe-intrepid · commit 50ccf9c1f1ae · 2019-07-01T14:33:02.000-04:00
In some cases, this can cause a segmentation fault
diff --git a/src/methods.cpp b/src/methods.cpp
@@ -4138,7 +4138,7 @@ PyObject* meth_get_library_path(PyObject* self)
             char buffer[512];
             return set_ics_exception(exception_runtime_error(), dll_get_error(buffer));
         }
-        return Py_BuildValue("s", lib->getPath());
+        return Py_BuildValue("s", lib->getPath().c_str());
     }
     catch (ice::Exception& ex)
     {

Original file line number	Diff line number	Diff line change
`@@ -4138,7 +4138,7 @@ PyObject* meth_get_library_path(PyObject* self)`
`4138`	`4138`	`char buffer[512];`
`4139`	`4139`	`return set_ics_exception(exception_runtime_error(), dll_get_error(buffer));`
`4140`	`4140`	`}`
`4141`		`- return Py_BuildValue("s", lib->getPath());`
	`4141`	`+ return Py_BuildValue("s", lib->getPath().c_str());`
`4142`	`4142`	`}`
`4143`	`4143`	`catch (ice::Exception& ex)`
`4144`	`4144`	`{`