Fixed _PyMem_DebugMalloc: Python memory allocator called without holding the GIL

Author: drebbe-intrepid

README.md

@@ -83,10 +83,15 @@ PS > python -m pip install .
         - `.\.venv\Scripts\Activate.ps1`
     - Install dependencies:
         - `python -m pip install -r requirements.txt`
-    - Build in debug (`-g` flag):
-        - `python setup.py build -g`
-    - Install into our virtual environment:
-        - `python setup.py install --force`
+    - Set DEBUG environment variable:
+        - $env:DEBUG = "1"
+    - Build the extension:
+        - `python_d setup.py build --debug install --force`
+        - OUTDATED:
+            - Build in debug (`-g` flag):
+                - `python setup.py build -g`
+            - Install into our virtual environment:
+                - `python setup.py install --force`
     - Inside visual studio code:
         - Open the root python_ics directory
             - `code C:\Path\To\python_ics`

pyproject.toml

@@ -7,7 +7,7 @@ description = "Python wrapper for interfacing to IntrepidCS Hardware."
 keywords = ["intrepidcs", "CAN", "Ethernet", "Automotive", "ICS"]
 readme = { file = "README.md", content-type = "text/markdown" }
 requires-python = ">=3.9"
-license = "MIT"
+license = { file = "LICENSE.md" }
 classifiers = [
   "Development Status :: 5 - Production/Stable",
   "Intended Audience :: Developers",

setup.py

@@ -69,10 +69,15 @@ def run(self):
 
 def get_ics_extension_compiler_arguments() -> List[str]:
     """Return a list of compiler arguments to append for compiling the ics extension module"""
+    # Debug arguments
+    is_debug = True if os.environ.get("DEBUG") else False
     # gcc and clang arguments
     GCC_COMPILE_ARGS = [
         "-Wno-unknown-pragmas",
     ]
+    if is_debug:
+        print("NOTICE: Building for DEBUG!")
+        GCC_COMPILE_ARGS.extend(["-g", "-O0"])
     # Set compiler flags here
     if "WINDOWS" in platform.system().upper():
         compile_args = [
@@ -86,6 +91,8 @@ def get_ics_extension_compiler_arguments() -> List[str]:
             "/wd5045",
             "/std:c++17",
         ]
+        if is_debug:
+            compile_args.extend(["CL=/Zi", "/Od", "/DEBUG"])
         # mingw and clang python builds won't have MSC in the version string
         if "MSC" not in sys.version:
             compile_args = GCC_COMPILE_ARGS

src/main.cpp

@@ -69,15 +69,14 @@ extern "C"
 
     PyMODINIT_FUNC PyInit_ics(void)
     {
-        initialize_ics_library();
-
         PyObject* module = PyModule_Create(&IcsModule);
-
         if (!module) {
             return module;
         }
         PyDateTime_IMPORT;
 
+        initialize_ics_library();
+
 #ifdef Py_GIL_DISABLED
         // Enable the experimental free threaded introduced in 3.13
         PyUnstable_Module_SetGIL(module, Py_MOD_GIL_NOT_USED);