another fix for python > 3.7.

drebbe-intrepid · drebbe-intrepid · commit 6131c297bb25 · 2022-11-03T17:37:50.000-04:00
Signed-off-by: David Rebbe &lt;drebbe@intrepidcs.com&gt;
diff --git a/src/methods.cpp b/src/methods.cpp
@@ -3819,11 +3819,12 @@ PyObject* meth_uart_read(PyObject* self, PyObject* args)
                 return set_ics_exception(exception_runtime_error(), "icsneoUartRead() Failed");
             }
         Py_END_ALLOW_THREADS
-        PyObject* value = Py_BuildValue("y#", buffer, bytesActuallyRead);
+        PyObject* ba_result = PyByteArray_FromStringAndSize((const char*)buffer, bytesActuallyRead);
+        PyObject* value = Py_BuildValue("Y", ba_result);
         free(buffer);
         buffer = NULL;
+        Py_DECREF(ba_result);
         return value;
-
     }
     catch (ice::Exception& ex)
     {

Original file line number	Diff line number	Diff line change
`@@ -3819,11 +3819,12 @@ PyObject* meth_uart_read(PyObject* self, PyObject* args)`
`3819`	`3819`	`return set_ics_exception(exception_runtime_error(), "icsneoUartRead() Failed");`
`3820`	`3820`	`}`
`3821`	`3821`	`Py_END_ALLOW_THREADS`
`3822`		`- PyObject* value = Py_BuildValue("y#", buffer, bytesActuallyRead);`
	`3822`	`+ PyObject* ba_result = PyByteArray_FromStringAndSize((const char*)buffer, bytesActuallyRead);`
	`3823`	`+ PyObject* value = Py_BuildValue("Y", ba_result);`
`3823`	`3824`	`free(buffer);`
`3824`	`3825`	`buffer = NULL;`
	`3826`	`+ Py_DECREF(ba_result);`
`3825`	`3827`	`return value;`
`3826`		`-`
`3827`	`3828`	`}`
`3828`	`3829`	`catch (ice::Exception& ex)`
`3829`	`3830`	`{`