Skip to content

Commit a8c5ae9

Browse files
Serial Number checks fixed for real this time. #156
Signed-off-by: David Rebbe <drebbe@intrepidcs.com>
1 parent 853ed23 commit a8c5ae9

7 files changed

Lines changed: 8 additions & 8 deletions

examples/iso15765_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
# Helper Functions ##########################################################
88
def dev_name(device):
9-
if int("AA0000", 36) < device.SerialNumber < int("ZZZZZZ", 36):
9+
if int("0A0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
1010
return device.Name + " " + ics.base36enc(device.SerialNumber)
1111
else:
1212
return device.Name + " " + str(device.SerialNumber)

examples/open_device_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
def dev_name(device):
88
# Return a friendly name of the device (ie. neoVI FIRE2 CY1234)
9-
if int("AA0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
9+
if int("0A0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
1010
return device.Name + " " + ics.base36enc(device.SerialNumber)
1111
else:
1212
return device.Name + " " + str(device.SerialNumber)

examples/transmit_can_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
def dev_name(device):
88
# Return a friendly name of the device (ie. neoVI FIRE2 CY1234)
9-
if int("AA0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
9+
if int("0A0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
1010
return device.Name + " " + ics.base36enc(device.SerialNumber)
1111
else:
1212
return device.Name + " " + str(device.SerialNumber)

examples/transmit_can_xtd_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
def dev_name(device):
88
# Return a friendly name of the device (ie. neoVI FIRE2 CY1234)
9-
if int("AA0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
9+
if int("0A0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
1010
return device.Name + " " + ics.base36enc(device.SerialNumber)
1111
else:
1212
return device.Name + " " + str(device.SerialNumber)

examples/transmit_lin_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
def dev_name(device):
1010
# Return a friendly name of the device (ie. neoVI FIRE2 CY1234)
11-
if int("AA0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
11+
if int("0A0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
1212
return device.Name + " " + ics.base36enc(device.SerialNumber)
1313
else:
1414
return device.Name + " " + str(device.SerialNumber)

examples/transmit_lin_ldf_example.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ def parse_ldf():
1010

1111
def dev_name(device):
1212
# Return a friendly name of the device (ie. neoVI FIRE2 CY1234)
13-
if int("AA0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
13+
if int("0A0000", 36) <= device.SerialNumber <= int("ZZZZZZ", 36):
1414
return device.Name + " " + ics.base36enc(device.SerialNumber)
1515
else:
1616
return device.Name + " " + str(device.SerialNumber)

include/object_neo_device.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,10 @@ static PyObject* neo_device_object_tp_repr(PyObject* o)
143143
{
144144
// example output: <ics.NeoDevice neoVI FIRE2 CY1234>
145145
neo_device_object* nd = (neo_device_object*)(o);
146-
// Check range is A00000-ZZZZZZ
146+
// Check range is 0A0000-ZZZZZZ
147147
PyObject* sn = NULL;
148148
uint32_t serial = (uint32_t)nd->dev.SerialNumber;
149-
if (604661760 <= serial && serial <= 2176782335)
149+
if (16796160 <= serial && serial <= 2176782335)
150150
sn = convert_to_base36(serial);
151151
else
152152
sn = PyUnicode_FromFormat("%lu", nd->dev.SerialNumber);

0 commit comments

Comments
 (0)