Skip to content

Commit c07589f

Browse files
Fixed ics.get_error_messages() (#176)
* updated debugging stuff for linux * Fixed issue #175. GIL issue on error.
1 parent c676c95 commit c07589f

3 files changed

Lines changed: 18 additions & 3 deletions

File tree

.vscode/extensions.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"recommendations": [
3+
"ms-python.python",
4+
"charliermarsh.ruff",
5+
"mikoz.black-py",
6+
"xaver.clang-format",
7+
"webfreak.debug"
8+
]
9+
}

.vscode/launch.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"name": "Python: Debug icsdebug.py",
4242
"type": "debugpy",
4343
"request": "launch",
44-
"program": "src\\icsdebug.py",
44+
"program": "src/icsdebug.py",
4545
"console": "integratedTerminal"
4646
},
4747
{
@@ -50,5 +50,11 @@
5050
"request": "attach",
5151
"pid": "${command:pickProcess}",
5252
}
53+
{
54+
"name": "Debugger Attach lldb",
55+
"type": "lldb",
56+
"request": "attach",
57+
"pid": "${command:pickProcess}",
58+
}
5359
]
5460
}

src/methods.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1150,8 +1150,8 @@ PyObject* meth_get_error_messages(PyObject* self, PyObject* args)
11501150
ice::Function<int __stdcall(ICS_HANDLE, int*, int*)> icsneoGetErrorMessages(lib, "icsneoGetErrorMessages");
11511151
Py_BEGIN_ALLOW_THREADS;
11521152
if (!icsneoGetErrorMessages(handle, errors, &error_count)) {
1153-
Py_UNBLOCK_THREADS return set_ics_exception(exception_runtime_error(),
1154-
"icsneoScriptGetScriptStatusEx() Failed");
1153+
Py_BLOCK_THREADS return set_ics_exception(exception_runtime_error(),
1154+
"icsneoGetErrorMessages() Failed");
11551155
}
11561156
Py_END_ALLOW_THREADS;
11571157
ice::Function<int __stdcall(int, char*, char*, int*, int*, int*, int*)> icsneoGetErrorInfo(

0 commit comments

Comments
 (0)