Merge pull request #49 from junron/master

Fix extension host crash when used with GitHub Copilot

Author: mrexodia

idacode/CHANGELOG.md

@@ -36,4 +36,8 @@
 ### 0.3.0
 
 - Fixed Python 2 support (PR #17)
-- Fixed issue where debugpy would attempt to spawn the current process (Issue #23)
+- Fixed issue where debugpy would attempt to spawn the current process (Issue #23)
+
+### 0.3.1
+
+- Fixed unnecessary global prototype pollution that broke other extensions (eg GitHub Copilot)

idacode/README.md

@@ -73,4 +73,8 @@ IDACode doesn't support host to VM communication unless the VM uses a shared vol
 ### 0.3.0
 
 - Fixed Python 2 support (PR #17)
-- Fixed issue where debugpy would attempt to spawn the current process (Issue #23)
+- Fixed issue where debugpy would attempt to spawn the current process (Issue #23)
+
+### 0.3.1
+
+- Fixed unnecessary global prototype pollution that broke other extensions (eg GitHub Copilot)

idacode/package.json

@@ -3,7 +3,7 @@
     "displayName": "IDACode",
     "description": "Run and debug your IDA scripts from VS Code",
     "icon": "images/icon.png",
-    "version": "0.3.0",
+    "version": "0.3.1",
     "publisher": "Layle",
     "license": "SEE LICENSE IN LICENSE.md",
     "preview": true,

idacode/src/extension.ts

@@ -2,7 +2,6 @@ import * as vscode from 'vscode';
 import * as path from 'path';
 import * as WebSocket from 'ws';
 import { Event } from './utils/events';
-import './utils/extensions';
 
 var socket: WebSocket;
 
@@ -15,13 +14,17 @@ function getCurrentDocument(): string {
     return vscode.window.activeTextEditor?.document.uri.fsPath as string;
 }
 
+function toBuffer(obj: Object): Buffer {
+    return Buffer.from(JSON.stringify(obj));
+}
+
 function executeScriptInIDA() {
     const currentDocument = getCurrentDocument();
     const name = path.parse(currentDocument).base;
-    socket.send({
+    socket.send(toBuffer({
         event: Event.ExecuteScript,
         path: currentDocument
-    }.toBuffer());
+    }));
     vscode.window.showInformationMessage(`Sent ${name} to IDA`);
 }
 
@@ -47,10 +50,10 @@ function connectToIDA() {
                 prompt: 'Enter the path to the folder containing the script',
                 value: currentFolder
             });
-            socket.send({
+            socket.send(toBuffer({
                 event: Event.SetWorkspace,
                 path: workspaceFolder
-            }.toBuffer());
+            }));
             vscode.window.showInformationMessage(`Set workspace folder to ${workspaceFolder}`);
             resolve();
         });
@@ -81,9 +84,9 @@ function connectToIDA() {
 }
 
 function attachToIDA() {
-    socket.send({
+    socket.send(toBuffer({
         event: Event.AttachDebugger
-    }.toBuffer());
+    }));
 }
 
 function connectAndAttachToIDA() {