From f6decb4a9ab8c43ecd1b24a930521616557b4124 Mon Sep 17 00:00:00 2001 From: BenOsodrac Date: Mon, 23 Mar 2026 22:15:03 +0000 Subject: [PATCH 1/3] add missing rule on ionic theme --- core/src/css/ionic/typography.ionic.scss | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/core/src/css/ionic/typography.ionic.scss b/core/src/css/ionic/typography.ionic.scss index cb746952ecf..48ad11a1fd7 100644 --- a/core/src/css/ionic/typography.ionic.scss +++ b/core/src/css/ionic/typography.ionic.scss @@ -1,10 +1,18 @@ @use "../../themes/ionic/ionic.globals.scss" as globals; -// TODO(ROU-10833): add font loading solution here, as a @font-face, base64 or cdn html { font-family: globals.$ion-font-family; } +// Dynamic Type is an iOS-only feature, so +// this should only be enabled on iOS devices. +@supports (-webkit-touch-callout: none) { + html { + font: var(--ionic-dynamic-font, 16px #{globals.$ion-font-family}); + font-family: globals.$ion-font-family; + } +} + body { @include globals.typography(globals.$ion-body-md-regular); } From bce711c221f5d6acd5d2f232e1ce2784ac395977 Mon Sep 17 00:00:00 2001 From: BenOsodrac Date: Mon, 23 Mar 2026 22:23:39 +0000 Subject: [PATCH 2/3] fix lint --- core/src/css/ionic/typography.ionic.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/css/ionic/typography.ionic.scss b/core/src/css/ionic/typography.ionic.scss index 48ad11a1fd7..87dff4a8cab 100644 --- a/core/src/css/ionic/typography.ionic.scss +++ b/core/src/css/ionic/typography.ionic.scss @@ -8,8 +8,8 @@ html { // this should only be enabled on iOS devices. @supports (-webkit-touch-callout: none) { html { - font: var(--ionic-dynamic-font, 16px #{globals.$ion-font-family}); - font-family: globals.$ion-font-family; + font: var(--ionic-dynamic-font, 16px #{globals.$ion-font-family}); + font-family: globals.$ion-font-family; } } From 0eff320444a2a9b9a518dd7574293c73df6cad12 Mon Sep 17 00:00:00 2001 From: BenOsodrac Date: Mon, 23 Mar 2026 22:39:00 +0000 Subject: [PATCH 3/3] rename var --- core/src/css/ionic/core.ionic.scss | 2 +- core/src/css/ionic/typography.ionic.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/css/ionic/core.ionic.scss b/core/src/css/ionic/core.ionic.scss index 2d6b3d27f5d..358edf48e59 100644 --- a/core/src/css/ionic/core.ionic.scss +++ b/core/src/css/ionic/core.ionic.scss @@ -22,7 +22,7 @@ } html { - --ionic-dynamic-font: -apple-system-body; + --ion-dynamic-font: -apple-system-body; } body { diff --git a/core/src/css/ionic/typography.ionic.scss b/core/src/css/ionic/typography.ionic.scss index 87dff4a8cab..703579f366c 100644 --- a/core/src/css/ionic/typography.ionic.scss +++ b/core/src/css/ionic/typography.ionic.scss @@ -8,7 +8,7 @@ html { // this should only be enabled on iOS devices. @supports (-webkit-touch-callout: none) { html { - font: var(--ionic-dynamic-font, 16px #{globals.$ion-font-family}); + font: var(--ion-dynamic-font, 16px #{globals.$ion-font-family}); font-family: globals.$ion-font-family; } }