Revert "Improve tests by also adding a header"

This reverts commit df530a4.

If you would call that route, you would get extra arguments that the function can not handle. I.e. if you use the approach of changing the signature, you should rather just remove optional parameters than trying to add more.

Author: Joakim Nordling

openapi_to_fastapi/tests/test_router.py

@@ -609,21 +609,13 @@ def handler_1(request, x_my_header: Optional[str] = Header(None)):
     def handler_2(request, x_my_header: Optional[str] = Header(None)):
         return {}
 
-    # Remove the header from handler_2 and add another header instead
+    # Remove the header from handler_2
     sig = inspect.signature(handler_2)
     params = sig.parameters
-    modified_params = [
+    filtered_params = [
         param for param_name, param in params.items() if param_name != "x_my_header"
     ]
-    modified_params.append(
-        inspect.Parameter(
-            "x_other_header",
-            kind=inspect.Parameter.KEYWORD_ONLY,
-            annotation=Optional[str],
-            default=Header(None),
-        )
-    )
-    handler_2.__signature__ = sig.replace(parameters=modified_params)
+    handler_2.__signature__ = sig.replace(parameters=filtered_params)
 
     # Add handlers to router (non-decorator syntax)
     spec_router.post("/TestValidation_v0.1")(handler_1)
@@ -642,5 +634,5 @@ def handler_2(request, x_my_header: Optional[str] = Header(None)):
     headers_1 = {p.get("name") for p in parameters_1 if p.get("in") == "header"}
     headers_2 = {p.get("name") for p in parameters_2 if p.get("in") == "header"}
 
-    assert headers_1 == {"x-my-header"}
-    assert headers_2 == {"x-other-header"}
+    assert "x-my-header" in headers_1
+    assert "x-my-header" not in headers_2