[_522][_523] review suggestions

Author: d-w-moore

irods/connection.py

@@ -488,6 +488,8 @@ def _login_pam(self):
             if getattr(self,'DISALLOWING_PAM_PLAINTEXT',True):
                 raise PlainTextPAMPasswordError
 
+        # In general authentication API, a ';' and '=' in the password would be misinterpreted due to those
+        # characters' special meaning in the context string parameter.
         use_dedicated_pam_api = len(ctx) >= MAX_NAME_LEN or \
                                 {';','='}.intersection(set(new_pam_password))
 

irods/test/PRC_issue_362.bats

@@ -4,15 +4,8 @@
 . $BATS_TEST_DIRNAME/scripts/funcs
 
 setup() {
-  local -A chars=(
-    [semicolon]=";"
-    [atsymbol]="@"
-    [equals]="="
-    [ampersand]="&"
-  )
   [ $BATS_TEST_NUMBER = 1 ] && echo "---" >/tmp/PRC_test_issue_362
   local name=${BATS_TEST_DESCRIPTION##*_}
-  CHR="${chars[$name]}"
 
   ## Arrange for secrets file to be generated internally by the Python client
   cat >~/.python_irodsclient <<-EOF
@@ -43,13 +36,14 @@ setup() {
 
 prc_test()
 {
+  local CHR="$1"
   local USER="alissa"
   local PASSWORD="my${CHR}pass"
   sudo chpasswd <<<"$USER:$PASSWORD"
   env PYTHON_IRODSCLIENT_CONFIGURATION_PATH='' python ~/test_get_home_coll.py
 }
 
-@test "test_with_atsymbol" { prc_test; }
-@test "test_with_semicolon" { prc_test; }
-@test "test_with_equals" { prc_test; }
-@test "test_with_ampersand" { prc_test; }
+@test "test_with_atsymbol" { prc_test "@"; }
+@test "test_with_semicolon" { prc_test ";"; }
+@test "test_with_equals" { prc_test "="; }
+@test "test_with_ampersand" { prc_test "&"; }