Skip to content

Commit 6fc58d9

Browse files
committed
[_502,_697] amendments to harness and github workflows
1 parent 0484190 commit 6fc58d9

57 files changed

Lines changed: 964 additions & 195 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
name: run-bats-tests
2+
3+
on: [push, pull_request]
4+
5+
jobs:
6+
tests:
7+
timeout-minutes: 20
8+
9+
name: Python ${{ matrix.python }}, iRODS ${{ matrix.irods_server }}
10+
runs-on: ubuntu-latest
11+
defaults:
12+
run:
13+
working-directory: ./irods/test/harness
14+
strategy:
15+
matrix:
16+
python: ['3.9','3.13']
17+
irods_server: ['4.3.4','5.0.2']
18+
19+
steps:
20+
- name: Checkout
21+
uses: actions/checkout@v4
22+
23+
- name: Build images
24+
run: ./create_docker_images.sh "${{ matrix.irods_server }}" "${{ matrix.python }}"
25+
26+
- name: run tests
27+
run: |
28+
for script in ../scripts/test00[1-9]*; do
29+
./docker_container_driver.sh -V $script
30+
done
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
name: run-local-suite
2+
3+
on: [push, pull_request]
4+
5+
jobs:
6+
tests:
7+
timeout-minutes: 20
8+
9+
name: Python ${{ matrix.python }}, iRODS ${{ matrix.irods_server }}
10+
runs-on: ubuntu-latest
11+
defaults:
12+
run:
13+
working-directory: ./irods/test/harness
14+
strategy:
15+
matrix:
16+
python: ['3.9','3.13']
17+
irods_server: ['4.3.4','5.0.2']
18+
19+
steps:
20+
- name: Checkout
21+
uses: actions/checkout@v4
22+
23+
- name: Build images
24+
run: ./create_docker_images.sh "${{ matrix.irods_server }}" "${{ matrix.python }}"
25+
26+
- name: run tests
27+
run: |
28+
./docker_container_driver.sh -V ../scripts/run_suite_locally.sh

.github/workflows/run-the-tests.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,22 @@ jobs:
66
tests:
77
timeout-minutes: 20
88

9-
name: ${{ matrix.python }}
9+
name: Python ${{ matrix.python }}, iRODS ${{ matrix.irods_server }}
1010
runs-on: ubuntu-latest
1111
defaults:
1212
run:
1313
working-directory: ./docker-testing
1414
strategy:
1515
matrix:
1616
python: ['3.9','3.13']
17+
irods_server: ['4.3.4','5.0.2']
1718

1819
steps:
1920
- name: Checkout
2021
uses: actions/checkout@v4
2122

2223
- name: Start containers
23-
run: ./start_containers.sh "${{ matrix.python }}"
24+
run: ./start_containers.sh "${{ matrix.irods_server }}" "${{ matrix.python }}"
2425

2526
- name: run test
2627
run: |
@@ -34,4 +35,4 @@ jobs:
3435
3536
- name: Stop containers
3637
if: always()
37-
run: docker compose -f harness-docker-compose.yml down
38+
run: ./stop_containers.sh "${{ matrix.irods_server }}" "${{ matrix.python }}"

Dockerfile.prc_test.centos

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,5 @@ RUN python${py_N} repo/docker_build/iinit.py \
2424
password rods
2525
SHELL ["/bin/bash","-c"]
2626
CMD echo "Waiting on iRODS server... " ; \
27-
python${PY_N} repo/docker_build/recv_oneshot -h irods-provider -p 8888 -t 360 && \
2827
sudo groupadd -o -g $(stat -c%g /irods_shared) irods && sudo usermod -aG irods user && \
2928
newgrp irods < repo/run_python_tests.sh

Dockerfile.prc_test.ubuntu

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,5 @@ SHELL ["/bin/bash","-c"]
3131
# 3. run python tests as the new group
3232

3333
CMD echo "Waiting on iRODS server... " ; \
34-
python${PY_N} repo/docker_build/recv_oneshot -h irods-provider -p 8888 -t 360 && \
3534
sudo groupadd -o -g $(stat -c%g /irods_shared) irods && sudo usermod -aG irods user && \
3635
newgrp irods < repo/run_python_tests.sh
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
harness-docker-compose.yml
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
harness-docker-compose.yml

docker-testing/harness-docker-compose.yml

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ version: '3'
33
services:
44
irods-catalog:
55
build:
6-
context: irods_catalog
6+
context: irods_catalog_${irods_major}
77
# 5432 is exposed by default and can conflict with other postgres containers.
88
# When the metalnx-db service is no longer needed, this stanza can be removed.
99
ports:
@@ -15,26 +15,31 @@ services:
1515
build:
1616
context: python_client
1717
args:
18-
- python_version
18+
python_version: ${python_version}
1919
command:
2020
tail -f /dev/null
2121
volumes:
2222
- ${repo_external}:/repo_root:ro
23-
- /tmp/irods-client-share.py-${python_version}-${parent_pid}:/irods_shared
23+
- /tmp/irods-client-share.py-${python_version}:/irods_shared
24+
depends_on:
25+
irods-catalog-provider:
26+
condition: service_healthy
2427

2528
irods-catalog-provider:
2629
volumes:
27-
- /tmp/irods-client-share.py-${python_version}-${parent_pid}:/irods_shared
30+
- /tmp/irods-client-share.py-${python_version}:/irods_shared
2831
build:
29-
context: irods_catalog_provider
32+
context: irods_catalog_provider_${irods_major}
33+
args:
34+
irods_version: ${irods_version}
3035
shm_size: 500mb
31-
# healthcheck:
32-
# test: ["CMD", "su", "-", "irods", "-c", "ils || exit 1"]
33-
# interval: 10s
34-
# timeout: 10s
35-
# retries: 3
36-
# start_period: 20s
37-
# start_interval: 2s
36+
healthcheck:
37+
test: ["CMD", "su", "-", "irods", "-c", "ils || exit 1"]
38+
interval: 10s
39+
timeout: 10s
40+
retries: 3
41+
#start_period: 20s
42+
#start_interval: 2s
3843
ports:
3944
- "1247:1247"
4045
depends_on:
File renamed without changes.

0 commit comments

Comments
 (0)