Skip to content

Commit 8c6064e

Browse files
d-w-moorealanking
authored andcommitted
[#3] allow genquery2_test to work under all Python2/3 versions
import os
1 parent 9b3c7b3 commit 8c6064e

1 file changed

Lines changed: 23 additions & 14 deletions

File tree

irods/test/genquery2_test.py

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import os
2+
import sys
13
import unittest
24

35
import irods.test.helpers as helpers
@@ -6,27 +8,28 @@
68
class TestGenQuery2(unittest.TestCase):
79

810
@classmethod
9-
def setUpClass(self):
10-
self.sess = helpers.make_session()
11+
def setUpClass(cls):
12+
# cls.sess will be available to instance (test_*) methods as self.sess
13+
cls.sess = helpers.make_session()
1114

12-
if self.sess.server_version < (4, 3, 2):
13-
self.skipTest(
15+
if cls.sess.server_version < (4, 3, 2):
16+
raise unittest.SkipTest(
1417
'GenQuery2 is not available by default in iRODS before v4.3.2.')
1518

16-
self.coll_path_a = '/{}/home/{}/test_query2_coll_a'.format(
17-
self.sess.zone, self.sess.username)
18-
self.coll_path_b = '/{}/home/{}/test_query2_coll_b'.format(
19-
self.sess.zone, self.sess.username)
20-
self.sess.collections.create(self.coll_path_a)
21-
self.sess.collections.create(self.coll_path_b)
19+
cls.coll_path_a = '/{}/home/{}/test_query2_coll_a'.format(
20+
cls.sess.zone, cls.sess.username)
21+
cls.coll_path_b = '/{}/home/{}/test_query2_coll_b'.format(
22+
cls.sess.zone, cls.sess.username)
23+
cls.sess.collections.create(cls.coll_path_a)
24+
cls.sess.collections.create(cls.coll_path_b)
2225

2326
@classmethod
24-
def tearDownClass(self):
27+
def tearDownClass(cls):
2528
'''Remove test data and close connections
2629
'''
27-
self.sess.collections.remove(self.coll_path_a, force=True)
28-
self.sess.collections.remove(self.coll_path_b, force=True)
29-
self.sess.cleanup()
30+
cls.sess.collections.remove(cls.coll_path_a, force=True)
31+
cls.sess.collections.remove(cls.coll_path_b, force=True)
32+
cls.sess.cleanup()
3033

3134
def test_select(self):
3235
query = "SELECT COLL_NAME WHERE COLL_NAME = '{}'".format(self.coll_path_a)
@@ -85,3 +88,9 @@ def test_column_mappings(self):
8588
self.assertIn("DATA_ID", result.keys())
8689
self.assertIn("RESC_ID", result.keys())
8790
self.assertIn("USER_ID", result.keys())
91+
92+
93+
if __name__ == '__main__':
94+
# let the tests find the parent irods lib
95+
sys.path.insert(0, os.path.abspath('../..'))
96+
unittest.main()

0 commit comments

Comments
 (0)