Skip to content

Commit bfbc25b

Browse files
d-w-moorealanking
authored andcommitted
[irods/irods#844] fix access_test
Strings describing permissions were changed to substitute spaces with underscores in this commit: c425d80f26f53309591764b67424cee44badfe6c . Here, we just update PRC for that change.
1 parent af16978 commit bfbc25b

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

irods/test/access_test.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ def setUp(self):
2020
# Create test collection
2121
self.coll_path = '/{}/home/{}/test_dir'.format(self.sess.zone, self.sess.username)
2222
self.coll = helpers.make_collection(self.sess, self.coll_path)
23+
VERSION_DEPENDENT_STRINGS = { 'MODIFY':'modify_object', 'READ':'read_object' } if self.sess.server_version >= (4,3) \
24+
else { 'MODIFY':'modify object', 'READ':'read object' }
25+
self.mapping = dict( [(i,i) for i in ( 'own', VERSION_DEPENDENT_STRINGS['MODIFY'], VERSION_DEPENDENT_STRINGS['READ'])] +
26+
[('write',VERSION_DEPENDENT_STRINGS['MODIFY']), ('read', VERSION_DEPENDENT_STRINGS['READ'])] )
2327

2428
def tearDown(self):
2529
'''Remove test data and close connections
@@ -180,7 +184,7 @@ def test_set_data_acl(self):
180184
acl = self.sess.permissions.get(obj)[0] # owner's write access
181185

182186
# check values
183-
self.assertEqual(acl.access_name, 'modify object')
187+
self.assertEqual(acl.access_name, self.mapping['write'])
184188
self.assertEqual(acl.user_zone, user.zone)
185189
self.assertEqual(acl.user_name, user.name)
186190

@@ -206,21 +210,16 @@ def test_set_collection_acl(self):
206210
acl = self.sess.permissions.get(coll)[0] # owner's write access
207211

208212
# check values
209-
self.assertEqual(acl.access_name, 'modify object')
213+
self.assertEqual(acl.access_name, self.mapping['write'])
210214
self.assertEqual(acl.user_zone, user.zone)
211215
self.assertEqual(acl.user_name, user.name)
212216

213217
# reset permission to own
214218
acl1 = iRODSAccess('own', coll.path, user.name, user.zone)
215219
self.sess.permissions.set(acl1)
216220

217-
mapping = dict( [ (i,i) for i in ('modify object', 'read object', 'own') ] +
218-
[ ('write','modify object') , ('read', 'read object') ]
219-
)
220-
221-
@classmethod
222-
def perms_lists_symm_diff ( cls, a_iter, b_iter ):
223-
fields = lambda perm: (cls.mapping[perm.access_name], perm.user_name, perm.user_zone)
221+
def perms_lists_symm_diff ( self, a_iter, b_iter ):
222+
fields = lambda perm: (self.mapping[perm.access_name], perm.user_name, perm.user_zone)
224223
A = set (map(fields,a_iter))
225224
B = set (map(fields,b_iter))
226225
return (A-B) | (B-A)

0 commit comments

Comments
 (0)