Skip to content

Commit 287d27d

Browse files
committed
REFACTOR: CHANGED NAME OF JWTUTILS
1 parent b84481c commit 287d27d

8 files changed

Lines changed: 15 additions & 42 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
<groupId>io.github.isa-group</groupId>
99
<artifactId>Pricing4Java</artifactId>
10-
<version>3.3.0</version>
10+
<version>4.0.0</version>
1111

1212
<name>${project.groupId}:${project.artifactId}</name>
1313
<description>A pricing driven feature toggling library for java</description>

src/main/java/io/github/isagroup/PricingContext.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,6 @@ public Boolean userAffectedByPricing(){
7878
*/
7979
public abstract String getUserPlan();
8080

81-
/**
82-
* This method should return the object used inside the application to determine
83-
* the authority of the user inside the JWT.
84-
*
85-
* @return Current user's authorities object
86-
*/
87-
public abstract Object getUserAuthorities();
88-
8981
/**
9082
* This method returns the plan context of the current user, represented by a
9183
* {@link Map}. It's used to evaluate the pricing plan.

src/main/java/io/github/isagroup/PricingEvaluatorUtil.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import io.github.isagroup.models.FeatureStatus;
1616
import io.github.isagroup.models.PlanContextManager;
1717
import io.github.isagroup.models.PricingManager;
18-
import io.github.isagroup.services.jwt.JwtUtils;
18+
import io.github.isagroup.services.jwt.PricingJwtUtils;
1919
import io.jsonwebtoken.Jwts;
2020
import io.jsonwebtoken.SignatureAlgorithm;
2121

@@ -27,14 +27,14 @@
2727
public class PricingEvaluatorUtil {
2828

2929
@Autowired
30-
private JwtUtils jwtUtils;
30+
private PricingJwtUtils jwtUtils;
3131

3232
@Autowired
3333
private PricingContext pricingContext;
3434

3535
public PricingEvaluatorUtil(PricingContext pricingContext) {
3636
this.pricingContext = pricingContext;
37-
this.jwtUtils = new JwtUtils(pricingContext);
37+
this.jwtUtils = new PricingJwtUtils(pricingContext);
3838
}
3939

4040
Logger logger = Logger.getLogger(PricingEvaluatorUtil.class.getName());
@@ -50,8 +50,6 @@ public PricingEvaluatorUtil(PricingContext pricingContext) {
5050
public String generateUserToken() {
5151

5252
Map<String, Object> claims = new HashMap<>();
53-
54-
claims.put("authorities", pricingContext.getUserAuthorities());
5553

5654
String subject = "Default";
5755

@@ -176,7 +174,6 @@ private String buildJwtToken(Map<String, Map<String, Object>> features, String s
176174

177175
Map<String, Object> claims = new HashMap<>();
178176

179-
claims.put("authorities", pricingContext.getUserAuthorities());
180177
claims.put("features", features);
181178
claims.put("userContext", pricingContext.getUserContext());
182179
claims.put("planContext", pricingContext.getPlanContext());

src/main/java/io/github/isagroup/filters/RenewTokenFilter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414

1515
import io.github.isagroup.PricingContext;
1616
import io.github.isagroup.PricingEvaluatorUtil;
17-
import io.github.isagroup.services.jwt.JwtUtils;
17+
import io.github.isagroup.services.jwt.PricingJwtUtils;
1818

1919
import java.util.Map;
2020

2121
public class RenewTokenFilter extends OncePerRequestFilter {
2222

2323
@Autowired
24-
private JwtUtils jwtUtils;
24+
private PricingJwtUtils jwtUtils;
2525

2626
@Value("${petclinic.app.jwtSecret}")
2727
private String jwtSecret;

src/main/java/io/github/isagroup/services/jwt/JwtUtils.java renamed to src/main/java/io/github/isagroup/services/jwt/PricingJwtUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,16 @@
2222
* Utility class that provides methods to generate and manage JWT.
2323
*/
2424
@Component
25-
public class JwtUtils {
25+
public class PricingJwtUtils {
2626

2727
@Autowired
2828
private PricingContext pricingContext;
2929

30-
public JwtUtils(PricingContext pricingContext) {
30+
public PricingJwtUtils(PricingContext pricingContext) {
3131
this.pricingContext = pricingContext;
3232
}
3333

34-
private static final Logger logger = LoggerFactory.getLogger(JwtUtils.class);
34+
private static final Logger logger = LoggerFactory.getLogger(PricingJwtUtils.class);
3535

3636
/**
3737
* Extracts the subject from the given JWT.

src/test/java/io/github/isagroup/PricingContextTestImpl.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,6 @@ public void setUserPlan(String userPlan) {
6161
this.userPlan = userPlan;
6262
}
6363

64-
@Override
65-
public Object getUserAuthorities() {
66-
67-
return this.userAuthorities;
68-
}
69-
7064
public void setUserAuthorities(Map<String, Object> userAuthorities) {
7165
this.userAuthorities = userAuthorities;
7266
}

src/test/java/io/github/isagroup/PricingEvaluatorUtilTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import org.junit.jupiter.api.BeforeEach;
1111
import org.junit.jupiter.api.Test;
1212

13-
import io.github.isagroup.services.jwt.JwtUtils;
13+
import io.github.isagroup.services.jwt.PricingJwtUtils;
1414

1515
public class PricingEvaluatorUtilTests {
1616

@@ -26,7 +26,7 @@ public class PricingEvaluatorUtilTests {
2626

2727
private PricingEvaluatorUtil pricingEvaluatorUtil;
2828

29-
private JwtUtils jwtUtils;
29+
private PricingJwtUtils jwtUtils;
3030

3131
@BeforeEach
3232
public void setUp() {
@@ -51,7 +51,7 @@ public void setUp() {
5151

5252
this.pricingContext = pricingContext;
5353
this.pricingEvaluatorUtil = new PricingEvaluatorUtil(pricingContext);
54-
this.jwtUtils = new JwtUtils(pricingContext);
54+
this.jwtUtils = new PricingJwtUtils(pricingContext);
5555
}
5656

5757
@Test

src/test/java/io/github/isagroup/PricingPlanAwareTests.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@
2424
import io.github.isagroup.annotations.PricingPlanAwareAspect;
2525
import io.github.isagroup.exceptions.FilepathException;
2626
import io.github.isagroup.exceptions.PricingPlanEvaluationException;
27-
import io.github.isagroup.services.jwt.JwtUtils;
27+
import io.github.isagroup.services.jwt.PricingJwtUtils;
2828

2929
@ExtendWith(SpringExtension.class)
3030
@SpringBootTest
3131
@Import({ io.github.isagroup.annotations.PricingPlanAwareAspect.class, io.github.isagroup.PricingEvaluatorUtil.class,
32-
io.github.isagroup.services.jwt.JwtUtils.class })
32+
io.github.isagroup.services.jwt.PricingJwtUtils.class })
3333
public class PricingPlanAwareTests {
3434

3535
private static final String JWT_SECRET_TEST = "secret";
@@ -98,16 +98,6 @@ public String getUserPlan() {
9898
return "BASIC";
9999
}
100100

101-
@Override
102-
public Object getUserAuthorities() {
103-
Map<String, String> userAuthorities = new HashMap<>();
104-
userAuthorities.put("role", "admin");
105-
userAuthorities.put("username", "admin1");
106-
userAuthorities.put("password", "4dm1n");
107-
108-
return userAuthorities;
109-
}
110-
111101
}
112102

113103
}
@@ -122,7 +112,7 @@ public Object getUserAuthorities() {
122112
private PricingEvaluatorUtil pricingEvaluatorUtil;
123113

124114
@Autowired
125-
private JwtUtils jwtUtils;
115+
private PricingJwtUtils jwtUtils;
126116

127117
@Mock
128118
private ProceedingJoinPoint joinPoint;

0 commit comments

Comments
 (0)