Merge pull request #49 from isa-group/fix/pricing-parser

fix: addOn availableFor nullPointerException

Author: Alex-GF

src/main/java/io/github/isagroup/services/parsing/AddOnParser.java

@@ -91,22 +91,40 @@ public static AddOn parseMapToAddOn(String addOnName, Map<String, Object> addOnM
 
     private static void setAvailableFor(Map<String, Object> addOnMap, PricingManager pricingManager, AddOn addOn) {
 
-        List<String> plansAvailable = (List<String>) addOnMap.get("availableFor");
+        Object plansAvailable = addOnMap.get("availableFor");
+        List<String> plansAvailableList;
 
-        if (plansAvailable == null || plansAvailable.isEmpty()) {
+        if (plansAvailable == null) {
             // If no plans are defined, the addOn is available for all plans
             plansAvailable = pricingManager.getPlans().keySet().stream().toList();
         }
 
-        for (String planName : plansAvailable) {
+        if (!(plansAvailable instanceof List<?>)) {
+            throw new PricingParsingException("The field \"availableFor\" should be a list");
+        }
+
+        if (plansAvailable instanceof List<?>) {
+            plansAvailableList = ((List<?>) plansAvailable).stream()
+                    .filter(item -> item instanceof String)
+                    .map(item -> (String) item)
+                    .toList();
+        } else {
+            throw new PricingParsingException("The field \"availableFor\" should be a list of strings");
+        }
+
+        if (plansAvailableList.isEmpty()) {
+            plansAvailableList = pricingManager.getPlans().keySet().stream().toList();
+        }
+
+        for (String planName : plansAvailableList) {
             if (!pricingManager.getPlans().containsKey(planName)
                     && !pricingManager.getAddOns().containsKey(planName)) {
                 throw new InvalidPlanException(
                         "The plan or addOn " + planName + " is not defined in the pricing manager");
             }
         }
 
-        addOn.setAvailableFor(plansAvailable);
+        addOn.setAvailableFor(plansAvailableList);
 
     }