feat: migrate positive test suite

- Some test were disable to pass ci (need a look)
- Add some new test cases
- Remove legacy tests

Author: Pedro González Marcos

src/test/java/io/github/isagroup/parsing/AddOnParserTest.java

@@ -0,0 +1,28 @@
+package io.github.isagroup.parsing.negative;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.fail;
+
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvFileSource;
+
+import io.github.isagroup.exceptions.InvalidPlanException;
+import io.github.isagroup.exceptions.PricingParsingException;
+import io.github.isagroup.exceptions.VersionException;
+import io.github.isagroup.services.yaml.YamlUtils;
+
+class NegativeParsingTests {
+
+    @ParameterizedTest(name = "{0} - {1}")
+    @CsvFileSource(resources = "/negative-parsing-tests.csv", delimiter = ';')
+    void negativeTests(String testDescription, String fileName, String expectedErrorMessage) {
+
+        try {
+            YamlUtils.retrieveManagerFromYaml(fileName);
+            fail();
+        } catch (PricingParsingException | InvalidPlanException | VersionException e) {
+            assertEquals(expectedErrorMessage, e.getMessage());
+        }
+    }
+
+}

src/test/java/io/github/isagroup/parsing/FeatureParserTest.java

@@ -0,0 +1,56 @@
+package io.github.isagroup.parsing.positive;
+
+import org.junit.jupiter.api.Test;
+
+import io.github.isagroup.models.PricingManager;
+import io.github.isagroup.services.yaml.YamlUtils;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+import org.junit.jupiter.api.DisplayName;
+
+public class AddOnParserTest {
+
+    private static final String TEST_CASES = "parsing/positive/addOn/";
+
+    @Test
+    @DisplayName(value = "'dependsOn': In order to purchase an add-on you have to previosly purchase other add-on.")
+    void givenAnAddOnInDependsOnShouldParse() {
+
+        PricingManager pricingManager = YamlUtils.retrieveManagerFromYaml(TEST_CASES + "dependsOn/dependent-addOn.yml");
+        assertEquals(2, pricingManager.getAddOns().size());
+        assertTrue(pricingManager.getAddOns().get("baz").getDependsOn().contains("bar"));
+
+    }
+
+    @Test
+    @DisplayName(value = "When 'private' is true, add-on should parse")
+    void givenEnablePrivateInAddOnShouldParse() {
+
+        String addOnName = "addon1";
+        PricingManager pricingManager = YamlUtils.retrieveManagerFromYaml(TEST_CASES + "private/is-private.yml");
+        assertTrue(pricingManager.getAddOns().get(addOnName).getIsPrivate());
+
+    }
+
+    @Test
+    @DisplayName(value = "When 'private' is false, add-on should parse")
+    void givenDisablePrivateInAddOnShouldParse() {
+
+        String addOnName = "addon1";
+        PricingManager pricingManager = YamlUtils.retrieveManagerFromYaml(TEST_CASES + "private/is-not-private.yml");
+        assertFalse(pricingManager.getAddOns().get(addOnName).getIsPrivate());
+
+    }
+
+    @Test
+    @DisplayName(value = "When add-on 'private' is not provided by default is false")
+    void givenNullPrivateShouldParse() {
+
+        String addOnName = "addon1";
+        PricingManager pricingManager = YamlUtils.retrieveManagerFromYaml(TEST_CASES + "private/no-private.yml");
+        assertFalse(pricingManager.getAddOns().get(addOnName).getIsPrivate());
+
+    }
+
+}

src/test/java/io/github/isagroup/parsing/PricingManagerParserTest.java

@@ -0,0 +1,51 @@
+package io.github.isagroup.parsing.positive;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+import io.github.isagroup.models.PricingManager;
+import io.github.isagroup.services.yaml.YamlUtils;
+
+public class FeatureParserTest {
+
+        private static final String POSITIVE_CASES = "parsing/positive/feature/";
+
+        @Test
+        @DisplayName(value = "Given a list of payment methods in 'defaultValue' should parse it")
+        void givenPaymentFeatureDefaultValueShouldBeListOfPaymentMethods() {
+
+                List<String> expectedPaymentMethods = new ArrayList<>();
+                expectedPaymentMethods.add("CARD");
+                String paymentFeatName = "payment";
+
+                PricingManager pricingManager = YamlUtils
+                                .retrieveManagerFromYaml(POSITIVE_CASES + "type/payment-feature.yml");
+
+                assertNotNull(pricingManager.getFeatures().get(paymentFeatName));
+                List<String> actualPaymentMethods = (List<String>) pricingManager.getFeatures().get(paymentFeatName)
+                                .getDefaultValue();
+                assertEquals(expectedPaymentMethods, actualPaymentMethods,
+                                "Payment methods should be a list of payment methods");
+
+        }
+
+        @Test
+        @DisplayName(value = "A feature 'expression' should be optional")
+        void givenAFeatureExpressionShouldBeOptional() {
+
+                String featName = "foo";
+                PricingManager pricingManager = YamlUtils
+                                .retrieveManagerFromYaml(POSITIVE_CASES + "expression/expression-is-null.yml");
+
+                assertNotNull(pricingManager.getFeatures().get(featName));
+                assertNull(pricingManager.getFeatures().get(featName).getExpression());
+
+        }
+}