Added max length for sender and checks for context being correctly set

Author: jekuaitk

modules/os2forms_digital_post/src/EventSubscriber/Os2formsDigitalPostSubscriber.php

@@ -32,8 +32,16 @@ public function onPrintRender(PrintHtmlAlterEvent $event): void {
       if ($submission instanceof WebformSubmissionInterface) {
         // Check whether generation is for digital post.
         if ($context = $this->getDigitalPostContext($submission)) {
-          $lookupResult = $context['lookupResult'];
-          $senderAddress = $context['senderAddress'];
+          $lookupResult = $context['lookupResult'] ?? NULL;
+          $senderAddress = $context['senderAddress'] ?? '';
+
+          if (!$lookupResult instanceof CprLookupResult && !$lookupResult instanceof CompanyLookupResult) {
+            return;
+          }
+
+          if (!is_string($senderAddress)) {
+            $senderAddress = '';
+          }
 
           // Combine address parts.
           $streetAddress = $lookupResult->getStreet();

modules/os2forms_digital_post/src/Plugin/WebformHandler/WebformHandlerSF1601.php

@@ -38,6 +38,11 @@ final class WebformHandlerSF1601 extends WebformHandlerBase {
    */
   private const SENDER_LABEL_MAX_LENGTH = 64;
 
+  /**
+   * Maximum length of sender address.
+   */
+  private const SENDER_ADDRESS_MAX_LENGTH = 70;
+
   /**
    * Maximum length of header label.
    */
@@ -135,9 +140,10 @@ public function buildConfigurationForm(array $form, FormStateInterface $formStat
     $form[self::MEMO_MESSAGE][self::SENDER_ADDRESS] = [
       '#type' => 'textfield',
       '#title' => $this->t('Sender address'),
-      '#description' => $this->t('Optional sender address shown on the printed document. Displayed as a single line above the recipient name.'),
+      '#description' => $this->t('Optional sender address shown on the printed document. Displayed as a single line above the recipient name. Maximum 70 characters.'),
       '#required' => FALSE,
       '#default_value' => $this->configuration[self::MEMO_MESSAGE][self::SENDER_ADDRESS] ?? NULL,
+      '#maxlength' => self::SENDER_ADDRESS_MAX_LENGTH,
     ];
 
     $form[self::MEMO_ACTIONS] = [