Use TCHAR types for GetShellFolderPath

Change GetShellFolderPath signatures from char* to LPCTSTR/LPTSTR in CColorCopApp and CColorCopDlg to use TCHAR-based types for Unicode/ANSI compatibility. Update the GetTempFolder call to use _T("AppData") and ensure buffer usage matches the new signatures. Also include minor header tidy-up.

Author: j4y

ColorCop.cpp

@@ -91,7 +91,7 @@ bool CColorCopApp::InstanceRunning() {
     return false;
 }
 
-BOOL CColorCopApp::GetShellFolderPath(char* pShellFolder, char* pShellPath) {
+BOOL CColorCopApp::GetShellFolderPath(LPCTSTR pShellFolder, LPTSTR pShellPath) {
     // pShellFolder can be one of the following
     // AppData, Cache, Cookies, Desktop, Favorites, Fonts, History, NetHood,
     // Personal, Printhood, Programs, Recent, SendTo, Start Menu, Startup,

ColorCop.h

@@ -28,9 +28,8 @@ class CColorCopApp : public CWinApp {
     void CloseApplication();
     void LoadDefaultSettings();
     CString GetTempFolder();
-    BOOL GetShellFolderPath(char * pShellFolder, char * pShellPath);
+    BOOL GetShellFolderPath(LPCTSTR pShellFolder, LPTSTR pShellPath);
     void ClipOrCenterWindowToMonitor(HWND hwnd, UINT flags);
-
     // multi mon
     void ClipOrCenterRectToMonitor(LPRECT prc, UINT flags);
 

ColorCopDlg.cpp

@@ -2040,7 +2040,7 @@ void CColorCopDlg::ParseHTML(CString inst) {
     return;
 }
 
-BOOL CColorCopDlg::GetShellFolderPath(char* pShellFolder, char* pShellPath) {
+BOOL CColorCopDlg::GetShellFolderPath(LPCTSTR pShellFolder, LPTSTR pShellPath) {
     // pShellFolder can be one of the following
     // AppData, Cache, Cookies, Desktop, Favorites, Fonts, History, NetHood,
     // Personal, Printhood, Programs, Recent, SendTo, Start Menu, Startup,
@@ -2068,7 +2068,7 @@ BOOL CColorCopDlg::GetShellFolderPath(char* pShellFolder, char* pShellPath) {
 
 CString CColorCopDlg::GetTempFolder() {
     CString strTmpPath;
-    GetShellFolderPath("AppData", strTmpPath.GetBuffer(MAX_PATH));
+    GetShellFolderPath(_T("AppData"), strTmpPath.GetBuffer(MAX_PATH));
     strTmpPath.ReleaseBuffer();
     return strTmpPath;
 }

ColorCopDlg.h

@@ -180,7 +180,7 @@ class CColorCopDlg : public CDialog {
     HBITMAP CopyBitmap(HBITMAP hBitmapSrc);
     bool isWebsafeColor(int R, int G, int B);
     CString GetTempFolder();
-    BOOL GetShellFolderPath(char* pShellFolder, char* pShellPath);
+    BOOL GetShellFolderPath(LPCTSTR pShellFolder, LPTSTR pShellPath);
 
     void SetStatusBarText(UINT strResource, int toggleVal);