Skip to content

Commit a7535b9

Browse files
authored
Merge pull request #118 from jackdomleo7/workflow-improvements
2 parents 92baa65 + e329b2e commit a7535b9

6 files changed

Lines changed: 1161 additions & 393 deletions

File tree

Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Linting
1+
name: Build
22

33
on:
44
push:
@@ -9,15 +9,19 @@ on:
99
- master
1010

1111
jobs:
12-
lint:
12+
build:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- uses: actions/checkout@v1
15+
- uses: actions/checkout@v2
1616
- name: Install Node
17-
uses: actions/setup-node@v1
17+
uses: actions/setup-node@v2
1818
with:
1919
node-version: '14.x'
2020
- name: Clean install npm dependencies
2121
run: npm ci
22+
- name: Check project can build successfully
23+
run: npm run build
24+
- name: Check git is still clean after building
25+
run: npm run has-no-changes
2226
- name: Check project linting
2327
run: npm run lint:check

.github/workflows/Tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
tests:
1313
runs-on: ubuntu-latest
1414
steps:
15-
- uses: actions/checkout@v1
15+
- uses: actions/checkout@v2
1616
- uses: cypress-io/github-action@v2
1717
with:
1818
browser: chrome

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,8 @@ _This project uses npm8 and Node >= 14 - however any project using this package
176176
5. Edit `src/**/*.scss` and run `npm run build` in the root of the project to regenerate the CSS found at `/checka11y.css` (DO NOT edit this file directly).
177177
6. To add error/warning styles and messages to your features, `@extend` one of the placeholders and `@include contentMessage()` from `src/_base.scss`.
178178
7. Add tests to your features in cypress folder (edit the element file or create a new one if needed)
179-
8. Run tests: `npm run cypress:open` or `npm run cypress:run` (headless)
180-
- You can also run tests for a specific tag/attribute by doing `npm run cypress:run -- --spec cypress/integration/{file-to-test}`
179+
8. Run tests: `npm run cypress:open` or `npm run test` (headless)
180+
- You can also run tests for a specific tag/attribute by doing `npm run test -- --spec cypress/integration/{file-to-test}`
181181
9. Add the feature to the [features.md](./features.md) & [codes.md](./codes.md) with a new error or warning code
182182

183183
---

0 commit comments

Comments
 (0)