Skip to content

Commit 2b2a18b

Browse files
committed
Amend icons
1 parent f127be5 commit 2b2a18b

9 files changed

Lines changed: 17 additions & 15 deletions

File tree

src/components/Button/Button.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ describe('Button', () => {
213213
it('renders a button with an icon before the text', async () => {
214214
// Arrange
215215
const icon: Components.Button.Icon = {
216-
src: new URL('@/docs/assets/duck.svg', import.meta.url).href,
216+
src: new URL('@/docs/assets/ChevronRight.svg', import.meta.url).href,
217217
position: 'before-text'
218218
};
219219
const wrapper = shallowMount(Button, {
@@ -238,7 +238,7 @@ describe('Button', () => {
238238
it('renders a button with an icon after the text', async () => {
239239
// Arrange
240240
const icon: Components.Button.Icon = {
241-
src: new URL('@/docs/assets/duck.svg', import.meta.url).href,
241+
src: new URL('@/docs/assets/ChevronRight.svg', import.meta.url).href,
242242
position: 'after-text'
243243
};
244244
const wrapper = shallowMount(Button, {
@@ -263,7 +263,7 @@ describe('Button', () => {
263263
it('renders a button with only an icon', async () => {
264264
// Arrange
265265
const icon: Components.Button.Icon = {
266-
src: new URL('@/docs/assets/duck.svg', import.meta.url).href,
266+
src: new URL('@/docs/assets/ChevronRight.svg', import.meta.url).href,
267267
position: 'icon-only'
268268
};
269269
const wrapper = shallowMount(Button, {

src/components/Button/Button.stories.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export const IconBefore: Story = {
6464
default: 'Click me',
6565
status: 'info',
6666
icon: {
67-
src: new URL('@/docs/assets/duck.svg', import.meta.url).href,
67+
src: new URL('@/docs/assets/ChevronLeft.svg', import.meta.url).href,
6868
position: 'before-text'
6969
}
7070
}
@@ -75,7 +75,7 @@ export const IconAfter: Story = {
7575
default: 'Click me',
7676
status: 'info',
7777
icon: {
78-
src: new URL('@/docs/assets/duck.svg', import.meta.url).href,
78+
src: new URL('@/docs/assets/ChevronRight.svg', import.meta.url).href,
7979
position: 'after-text'
8080
}
8181
}
@@ -86,7 +86,7 @@ export const IconOnly: Story = {
8686
default: 'Click me',
8787
status: 'info',
8888
icon: {
89-
src: new URL('@/docs/assets/duck.svg', import.meta.url).href,
89+
src: new URL('@/docs/assets/ChevronRight.svg', import.meta.url).href,
9090
position: 'icon-only'
9191
}
9292
}

src/components/Button/Button.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ const defaultSlotContent = computed<string>(() => {
162162
163163
:deep(svg) {
164164
fill: var(--j-btn-color);
165-
height: 75%;
165+
height: 60%;
166166
width: auto;
167167
position: absolute;
168168
}

src/components/Icon/Icon.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ describe('Icon', () => {
77
it('renders a decorative icon', () => {
88
// Arrange
99
const icon: Components.Icon.Icon = {
10-
src: new URL('@/docs/assets/duck.svg', import.meta.url).href
10+
src: new URL('@/docs/assets/ChevronRight.svg', import.meta.url).href
1111
};
1212
const wrapper = shallowMount(Icon, {
1313
props: { icon }
@@ -26,8 +26,8 @@ describe('Icon', () => {
2626
it('renders an informative icon', () => {
2727
// Arrange
2828
const icon: Components.Icon.Icon = {
29-
src: new URL('@/docs/assets/duck.svg', import.meta.url).href,
30-
label: 'Duck'
29+
src: new URL('@/docs/assets/ChevronRight.svg', import.meta.url).href,
30+
label: 'ChevronRight'
3131
};
3232
const wrapper = shallowMount(Icon, {
3333
props: { icon }
@@ -39,7 +39,7 @@ describe('Icon', () => {
3939
'false'
4040
);
4141
expect(wrapper.findComponent(InlineSvg).attributes('aria-label')).toBe(
42-
'Duck'
42+
'ChevronRight'
4343
);
4444
});
4545
});

src/components/Icon/Icon.stories.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,16 @@ type Story = StoryObj<typeof meta>;
1313
export const Decorative: Story = {
1414
args: {
1515
icon: {
16-
src: new URL('@/docs/assets/duck.svg', import.meta.url).href
16+
src: new URL('@/docs/assets/ChevronRight.svg', import.meta.url).href
1717
}
1818
}
1919
};
2020

2121
export const Informative: Story = {
2222
args: {
2323
icon: {
24-
src: new URL('@/docs/assets/duck.svg', import.meta.url).href,
25-
label: 'Duck'
24+
src: new URL('@/docs/assets/ChevronRight.svg', import.meta.url).href,
25+
label: 'ChevronRight'
2626
}
2727
}
2828
};

src/docs/assets/ChevronDown.svg

Lines changed: 1 addition & 0 deletions
Loading

src/docs/assets/ChevronLeft.svg

Lines changed: 1 addition & 0 deletions
Loading

src/docs/assets/ChevronRight.svg

Lines changed: 1 addition & 0 deletions
Loading

src/docs/assets/duck.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)