Skip to content

Commit 66e84d9

Browse files
jared mauchjared mauch
authored andcommitted
Fix duplicate list processing in password upgrade check
Add deduplication by internal_name() to prevent the same list from being processed multiple times when checking for old password formats. This fixes an issue where the same list could appear multiple times in the output with different email addresses.
1 parent ed61977 commit 66e84d9

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

bin/update

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -683,6 +683,7 @@ def check_and_notify_password_upgrades(dry_run=False):
683683

684684
print('Checking for lists with old password formats...')
685685
lists_needing_upgrade = []
686+
seen_lists = {} # Track by internal name to avoid duplicates
686687

687688
# Check all lists for old password formats
688689
listnames = Utils.list_names()
@@ -694,6 +695,13 @@ def check_and_notify_password_upgrades(dry_run=False):
694695
'listname': listname, 'e': e})
695696
continue
696697

698+
# Use internal_name() as key to avoid processing the same list twice
699+
internal_name = mlist.internal_name()
700+
if internal_name in seen_lists:
701+
# Already processed this list, skip
702+
continue
703+
seen_lists[internal_name] = True
704+
697705
needs_upgrade = False
698706
# Check list admin password
699707
if mlist.password and is_old_password_format(mlist.password):

0 commit comments

Comments
 (0)