Fix compiler warnings

- Remove unused variables and parameters
- Fix float-to-int implicit conversions
- Fix variable shadowing
- Fix float-to-bool conversion in argument check

Co-Authored-By: Claude <claude@anthropic.com>

Author: Wentzell

c++/cppdlr2d/dlr2d.cpp

@@ -62,8 +62,6 @@ namespace cppdlr2d {
 
   std::tuple<nda::array<int, 2>, nda::array<int, 2>> build_dlr2d(double lambda, double eps, bool compressgrid, bool compressbasis) {
 
-    int rankmethod = 1;
-
     // Get DLR frequencies
     auto dlr_rf = build_dlr_rf(lambda, eps);
     int r       = dlr_rf.size(); // # DLR basis functions
@@ -101,7 +99,7 @@ namespace cppdlr2d {
     // Extract frequency pairs
     auto dlr2d_rf = nda::array<int, 2>(ncol, 3);
     int idx       = 0;
-    double k = 0, l = 0;
+    int k = 0, l = 0;
     for (int i = 0; i < ncol; ++i) {
       idx = rf_idx(i);
       if (idx < r * r) {
@@ -152,9 +150,9 @@ namespace cppdlr2d {
 
     // Extract imaginary frequency pairs from pivots
     dlr2d_if = nda::array<int, 2>(nrow, 2);
-    for (int k = 0; k < nrow; ++k) {
-      dlr2d_if(k, 0) = prod_if(if_idx(k), 0);
-      dlr2d_if(k, 1) = prod_if(if_idx(k), 1);
+    for (int m = 0; m < nrow; ++m) {
+      dlr2d_if(m, 0) = prod_if(if_idx(m), 0);
+      dlr2d_if(m, 1) = prod_if(if_idx(m), 1);
     }
 
     fmt::print("Fine system matrix shape = {} x {}\n", 3 * r * r + r, 3 * r * r + r);
@@ -207,8 +205,6 @@ namespace cppdlr2d {
       }
     }
 
-    auto nu2d = (2 * nu2didx + 1) * pi * 1i;
-
     // Get system matrix for dense grid
     auto kmat = fmatrix(2 * r * r, 2 * r * r + r);
 
@@ -257,7 +253,6 @@ namespace cppdlr2d {
 
     // Pivoted QR to determine sampling nodes
     auto kmatt = fmatrix(transpose(kmat));
-    auto start = std::chrono::high_resolution_clock::now();
     auto piv   = nda::zeros<int>(2 * r * r);
     auto tau   = nda::vector<dcomplex>(2 * r * r);
     nda::lapack::geqp3(kmatt, piv, tau);
@@ -342,7 +337,6 @@ namespace cppdlr2d {
 
   fmatrix build_cf2if(double beta, nda::vector_const_view<double> dlr_rf, nda::array_const_view<int, 2> dlr2d_if,
                       nda::array_const_view<int, 2> dlr2d_rf) {
-    int r    = dlr_rf.size();
     int n_if = dlr2d_if.shape(0);
     int n_rf = dlr2d_rf.shape(0);
 
@@ -427,7 +421,6 @@ namespace cppdlr2d {
     auto coefreg = nda::zeros<dcomplex>(3, r, r);
     auto coefsng = nda::zeros<dcomplex>(r);
 
-    int idx = 0, j = 0, k = 0, l = 0;
     for (int i = 0; i < n; ++i) {
       if (dlr2d_rf(i, 0) < 3) { // Regular part
         coefreg(dlr2d_rf(i, 0), dlr2d_rf(i, 1), dlr2d_rf(i, 2)) = tmp(i);

c++/cppdlr2d/polarization.cpp

@@ -2,7 +2,7 @@
 
 namespace cppdlr2d {
 
-  nda::vector<dcomplex> polarization(double beta, double lambda, double eps, cppdlr::imtime_ops const &itops, cppdlr::imfreq_ops const &ifops_fer,
+  nda::vector<dcomplex> polarization(double beta, double lambda, double eps, cppdlr::imtime_ops const & /*itops*/, cppdlr::imfreq_ops const &ifops_fer,
                                      cppdlr::imfreq_ops const &ifops_bos, nda::array_const_view<dcomplex, 1> fc,
                                      nda::array_const_view<dcomplex, 1> gc, nda::array_const_view<dcomplex, 3> lambc,
                                      nda::array_const_view<dcomplex, 1> lambc_sing) {
@@ -31,17 +31,11 @@ namespace cppdlr2d {
 
     // Compute 1/(i Omega_m - omega_k)
     auto kkif = nda::array<dcomplex, 2>(r, r);
-    auto iom  = 2 * dlr_if_bos * pi * 1i;
     for (int j = 0; j < r; ++j) {
-      for (int k = 0; k < r; ++k) {
-        // kkif(j, k) = beta / (iom(j) - dlr_rf(k));
-        kkif(j, k) = beta * k_if_boson(dlr_if_bos(j), dlr_rf(k));
-      }
+      for (int k = 0; k < r; ++k) { kkif(j, k) = beta * k_if_boson(dlr_if_bos(j), dlr_rf(k)); }
     }
 
     // Compute F(tau) and G(tau)
-    // auto fit = itops.coefs2vals(fc);
-    // auto git = itops.coefs2vals(gc);
     auto fit = matvecmul(cf2itfine, fc);
     auto git = matvecmul(cf2itfine, gc);
 
@@ -105,11 +99,9 @@ namespace cppdlr2d {
     auto tmp5 = matvecmul(tmp2, lambc_sing);
     auto tmp6 = cffine2if * itops2.vals2coefs(tmp5);
 
-    int m0idx = 0;
     for (int j = 0; j < r; ++j) {
       if (dlr_if_bos(j) == 0) {
         pol(j) += beta * beta * tmp6(j);
-        m0idx = j;
         break;
       }
     }
@@ -122,7 +114,7 @@ namespace cppdlr2d {
     return pol;
   }
 
-  nda::vector<dcomplex> polarization_3term(double beta, double lambda, double eps, cppdlr::imtime_ops const &itops,
+  nda::vector<dcomplex> polarization_3term(double beta, double lambda, double eps, cppdlr::imtime_ops const & /*itops*/,
                                            cppdlr::imfreq_ops const &ifops_fer, cppdlr::imfreq_ops const &ifops_bos,
                                            nda::array_const_view<dcomplex, 1> fc, nda::array_const_view<dcomplex, 1> gc,
                                            nda::array_const_view<dcomplex, 3> lambc, nda::array_const_view<dcomplex, 1> lambc_sing) {
@@ -151,17 +143,11 @@ namespace cppdlr2d {
 
     // Compute 1/(i Omega_m - omega_k)
     auto kkif = nda::array<dcomplex, 2>(r, r);
-    auto iom  = 2 * dlr_if_bos * pi * 1i;
     for (int j = 0; j < r; ++j) {
-      for (int k = 0; k < r; ++k) {
-        // kkif(j, k) = beta / (iom(j) - dlr_rf(k));
-        kkif(j, k) = beta * k_if_boson(dlr_if_bos(j), dlr_rf(k));
-      }
+      for (int k = 0; k < r; ++k) { kkif(j, k) = beta * k_if_boson(dlr_if_bos(j), dlr_rf(k)); }
     }
 
     // Compute F(tau) and G(tau)
-    // auto fit = itops.coefs2vals(fc);
-    // auto git = itops.coefs2vals(gc);
     auto fit = matvecmul(cf2itfine, fc);
     auto git = matvecmul(cf2itfine, gc);
 
@@ -215,11 +201,9 @@ namespace cppdlr2d {
     auto tmp5 = matvecmul(tmp2, lambc_sing);
     auto tmp6 = cffine2if * itops2.vals2coefs(tmp5);
 
-    int m0idx = 0;
     for (int j = 0; j < r; ++j) {
       if (dlr_if_bos(j) == 0) {
         pol(j) += beta * beta * tmp6(j);
-        m0idx = j;
         break;
       }
     }
@@ -243,7 +227,6 @@ namespace cppdlr2d {
     auto dlr_if_fer = ifops_fer.get_ifnodes();
     auto dlr_if_bos = ifops_bos.get_ifnodes();
 
-    auto nu_dlr = ((2 * dlr_if_fer + 1) * pi * 1i) / beta;
     auto om_dlr = (2 * dlr_if_bos * pi * 1i) / beta;
 
     // Prepare some objects
@@ -507,9 +490,8 @@ namespace cppdlr2d {
 
     // Evaluate summand at fermionic DLR imag freq nodes
 
-    auto h                  = nda::vector<dcomplex>(r);
-    std::complex<double> nu = 0;
-    int channel             = 1;
+    auto h      = nda::vector<dcomplex>(r);
+    int channel = 1;
     for (int k = 0; k < r; ++k) {
       // h(k) = hubbg(u, nu1) * hubbg(u, -nu1) * hubbvert(u, beta, nu1, -nu1);
       h(k) = ifops_fer.coefs2eval(beta, fc, dlr_if_fer(k)) * ifops_fer.coefs2eval(beta, gc, -dlr_if_fer(k) - 1)
@@ -524,12 +506,8 @@ namespace cppdlr2d {
     for (int k = 0; k < r; ++k) { pol0 += hc(k) * k_it(0.0, ej(k), beta); }
 
     // Fill in polarization at i omega_n = 0
-    int m0idx = 0;
     for (int m = 0; m < r; ++m) {
-      if (dlr_if_bos(m) == 0) {
-        m0idx  = m;
-        pol(m) = pol0;
-      }
+      if (dlr_if_bos(m) == 0) { pol(m) = pol0; }
     }
 
     return pol;

c++/cppdlr2d/utils.cpp

@@ -70,7 +70,7 @@ namespace cppdlr2d {
       }
     } else if (method == 3) {
 
-      if (!alpha || !nvec) { throw std::invalid_argument("alpha and nvec must be provided for method 3"); }
+      if (alpha == 0 || nvec == 0) { throw std::invalid_argument("alpha and nvec must be provided for method 3"); }
 
       // Set up random number generator
       std::random_device rd;
@@ -116,7 +116,6 @@ namespace cppdlr2d {
       for (int i = 0; i < n; ++i) { ynorm(i, 0) = max_element(ynorm(i, _)); }
 
       // Estimate rank
-      int rank     = 0;
       double epssc = eps / (alpha * sqrt(2 / pi));
       for (int i = 0; i < n - 1; ++i) {
         if (ynorm(i + 1, 0) < epssc * epssc) {