Update reader params and test in io

Author: risenW

danfojs-browser/src/io/reader.js

@@ -47,14 +47,14 @@ export const read_json = async (source) => {
  *
  *  * @param {kwargs} kwargs --> {
  *                        source       : string, URL or local file path to retreive Excel file.
- *                        sheet_name   : string, (Optional) Name of the sheet which u want to parse. Default will be the first sheet.
+ *                        sheet   : string, (Optional) Name of the sheet which u want to parse. Default will be the first sheet.
  *                        header_index : int, (Optional) Index of the row which represents the header(columns) of the data. Default will be the first non empty row.
  *                        data_index   : int, (Optional)Index of the row from which actual data(content) starts. Default will be the next row of `header_index`
  *                    }
  * @returns {Promise} DataFrame structure of parsed Excel data
  */
-export const read_excel = async (kwargs) => {
-  let { source, sheet_name, header_index, data_index } = kwargs;
+export const read_excel = async (source, configs = {}) => {
+  let { sheet, header_index, data_index } = configs;
   let workbook;
   if (!header_index) {
     //default header_index
@@ -72,7 +72,7 @@ export const read_excel = async (kwargs) => {
 
 
     // Parse worksheet from workbook
-    const worksheet = workbook.Sheets[sheet_name || workbook.SheetNames[0]];
+    const worksheet = workbook.Sheets[sheet || workbook.SheetNames[0]];
     let range = XLSX.utils.decode_range(worksheet["!ref"]);
     let column_names = [],
       data = [];

danfojs-browser/tests/io/reader.js

@@ -12,44 +12,25 @@ describe("read_csv", async function () {
   });
 });
 
-// describe("read_json", async function () {
-//   this.timeout(10000); // all tests in this suite get 10 seconds before timeout
-//   it("reads a json file from source over the internet", async function () {
-//     const jUrl =
-//       "https://raw.githubusercontent.com/risenW/Tensorflowjs_Projects/master/recommender-sys/Python-Model/web_book_data.json";
-
-//     dfd.read_json(jUrl).then((df) => {
-//       const num_of_columns = df.column_names.length;
-//       assert.equal(num_of_columns, 4);
-//     });
-//   });
-
-//   it("reads a json file from source from local disk", async function () {
-//     const jUrl = "danfojs/tests/samples/book.json";
+describe("read_json", async function () {
+  this.timeout(10000); // all tests in this suite get 10 seconds before timeout
+  it("reads a json file from source over the internet", async function () {
+    const jUrl =
+      "https://raw.githubusercontent.com/risenW/Tensorflowjs_Projects/master/recommender-sys/Python-Model/web_book_data.json";
 
-//     dfd.read_json(jUrl).then((df) => {
-//       const num_of_columns = df.column_names.length;
-//       assert.equal(num_of_columns, 4);
-//     });
-//   });
-// });
+    const df = await dfd.read_json(jUrl);
+    const num_of_columns = df.column_names.length;
+    assert.equal(num_of_columns, 4);
 
-// describe("read_excel", async function () {
-//   this.timeout(10000); // all tests in this suite get 10 seconds before timeout
-//   it("reads an excel file from source over the internet", async function () {
-//     const remote_url =
-//       "https://file-examples-com.github.io/uploads/2017/02/file_example_XLS_100.xls";
-//     dfd.read_excel({ source: remote_url }).then((df) => {
-//       assert(df.columns.length, 8);
-//     });
-//   });
+  });
+});
 
-//   it("reads an excel file from source from local disk", async function () {
-//     const file_url = "danfojs/tests/samples/SampleData.xlsx";
-//     dfd.read_excel({ source: file_url, header_index: 7, data_index: 8 }).then(
-//       (df) => {
-//         assert(df.columns.length, 4);
-//       }
-//     );
-//   });
-// });
+describe("read_excel", async function () {
+  this.timeout(10000); // all tests in this suite get 10 seconds before timeout
+  it("reads an excel file from source over the internet", async function () {
+    const remote_url =
+      "https://file-examples-com.github.io/uploads/2017/02/file_example_XLS_100.xls";
+    const df = await dfd.read_excel(remote_url);
+    assert(df.columns.length, 8);
+  });
+});