fix bug in fillna

Author: risenW

danfojs/src/core/frame.js

@@ -1256,8 +1256,7 @@ export class DataFrame extends Ndframe {
                 let row_value = values[i]
                 for (let j = 0; j < row_value.length; j++) {
 
-                    let val = row_value[j] == 0 ? 0 : !!row_value[j]
-                    if (!val) {
+                    if (isNaN(row_value[j]) && typeof row_value[j] != "string" ) {
                         temp_data.push(nan_val)
                     } else {
                         temp_data.push(row_value[j])
@@ -1266,8 +1265,12 @@ export class DataFrame extends Ndframe {
                 }
                 data.push(temp_data);
             }
+            if (kwargs['inplace']) {
+                this.__update_frame_in_place(data, null, null, null, null)
+            } else {
+                return new DataFrame(data, { columns: columns, index: this.index })
 
-            return new DataFrame(data, { columns: columns, index: this.index })
+            }
 
         }
 

danfojs/src/plotting/plot.js

@@ -1,5 +1,5 @@
 //perform plotting
-// import { newPlot } from 'plotly.js' //comment out when building for Node Version
+import { newPlot } from 'plotly.js' //comment out when building for Node Version
 import { Utils } from "../core/utils"
 import { Series } from "../core/series"
 

danfojs/tests/core/frame.js

@@ -1390,8 +1390,8 @@ describe("DataFrame", function () {
             let df = new DataFrame(data, { columns: column })
 
             let df_val = [[-999, 1, 2, 3], [3, 4, -999, 9], [5, 6, 7, 8]]
-
-            assert.deepEqual(df.fillna({ values: -999 }).values, df_val)
+            df.fillna({ values: -999, inplace:true})
+            assert.deepEqual(df.values, df_val)
         });
         it("replace all NaN value", function () {
             let data = [[NaN, 1, 2, 3], [3, 4, NaN, 9], [5, 6, 7, 8]]

package.json

@@ -23,7 +23,7 @@
     "table": "^5.4.6"
   },
   "scripts": {
-    "test": "nyc mocha --require @babel/register danfojs/tests/core/frame",
+    "test": "nyc mocha --require @babel/register danfojs/tests/*",
     "dev": "npm run lint && babel ./danfojs/src -d dist --no-comments",
     "build": "babel ./danfojs/src -d ./dist --no-comments",
     "lint": "eslint ./danfojs/src",