[groupby][m]: uncomment all failed test and ensure they pass

Author: steveoni

danfojs-browser/tests/core/groupby.js

@@ -65,7 +65,7 @@ describe("groupby", function () {
       [ 20, 30, 1 ],
       [ 39, 89, 1 ]
     ];
-
+    
     assert.deepEqual(group_df.col([ "C" ]).count().values, new_data);
   });
   it("sum column element in group", function () {
@@ -130,38 +130,38 @@ describe("groupby", function () {
 
     assert.deepEqual(group_df.col([ "B", "C" ]).cumsum().values, new_data);
   });
-  // it("cummulative max for groupby", function () {
-
-  //   let data = [ [ 1, 2, 3 ], [ 4, 5, 6 ], [ 20, 30, 40 ], [ 39, 89, 78 ] ];
-  //   let cols = [ "A", "B", "C" ];
-  //   let df = new dfd.DataFrame(data, { columns: cols });
-  //   let group_df = df.groupby([ "A" ]);
-  //   let new_data = [ [ 1, 3 ], [ 4, 6 ], [ 20, 40 ], [ 39, 78 ] ];
+  it("cummulative max for groupby", function () {
 
+    let data = [ [ 1, 2, 3 ], [ 4, 5, 6 ], [ 20, 30, 40 ], [ 39, 89, 78 ] ];
+    let cols = [ "A", "B", "C" ];
+    let df = new dfd.DataFrame(data, { columns: cols });
+    let group_df = df.groupby([ "A" ]);
+    let new_data = [ [ 1, 3 ], [ 4, 6 ], [ 20, 40 ], [ 39, 78 ] ];
+    
 
-  //   assert.deepEqual(group_df.col([ "C" ]).cummax().values, new_data);
-  // });
-  // it("cummulative min for groupby", function () {
+    assert.deepEqual(group_df.col([ "C" ]).cummax().values, new_data);
+  });
+  it("cummulative min for groupby", function () {
 
-  //   let data = [ [ 1, 2, 3 ], [ 4, 5, 6 ], [ 20, 30, 40 ], [ 39, 89, 78 ] ];
-  //   let cols = [ "A", "B", "C" ];
-  //   let df = new dfd.DataFrame(data, { columns: cols });
-  //   let group_df = df.groupby([ "A" ]);
-  //   let new_data = [ [ 1, 3 ], [ 4, 6 ], [ 20, 40 ], [ 39, 78 ] ];
+    let data = [ [ 1, 2, 3 ], [ 4, 5, 6 ], [ 20, 30, 40 ], [ 39, 89, 78 ] ];
+    let cols = [ "A", "B", "C" ];
+    let df = new dfd.DataFrame(data, { columns: cols });
+    let group_df = df.groupby([ "A" ]);
+    let new_data = [ [ 1, 3 ], [ 4, 6 ], [ 20, 40 ], [ 39, 78 ] ];
 
-  //   assert.deepEqual(group_df.col([ "C" ]).cummin().values, new_data);
-  // });
+    assert.deepEqual(group_df.col([ "C" ]).cummin().values, new_data);
+  });
 
-  // it("cummulative prod for groupby", function () {
+  it("cummulative prod for groupby", function () {
 
-  //   let data = [ [ 1, 2, 3 ], [ 4, 5, 6 ], [ 20, 30, 40 ], [ 39, 89, 78 ] ];
-  //   let cols = [ "A", "B", "C" ];
-  //   let df = new dfd.DataFrame(data, { columns: cols });
-  //   let group_df = df.groupby([ "A" ]);
-  //   let new_data = [ [ 1, 3 ], [ 4, 6 ], [ 20, 40 ], [ 39, 78 ] ];
+    let data = [ [ 1, 2, 3 ], [ 4, 5, 6 ], [ 20, 30, 40 ], [ 39, 89, 78 ] ];
+    let cols = [ "A", "B", "C" ];
+    let df = new dfd.DataFrame(data, { columns: cols });
+    let group_df = df.groupby([ "A" ]);
+    let new_data = [ [ 1, 3 ], [ 4, 6 ], [ 20, 40 ], [ 39, 78 ] ];
 
-  //   assert.deepEqual(group_df.col([ "C" ]).cumprod().values, new_data);
-  // });
+    assert.deepEqual(group_df.col([ "C" ]).cumprod().values, new_data);
+  });
   it("mean for groupby", function () {
 
     let data = [ [ 1, 2, 3 ], [ 4, 5, 6 ], [ 20, 30, 40 ], [ 39, 89, 78 ] ];
@@ -178,31 +178,31 @@ describe("groupby", function () {
     assert.deepEqual(group_df.col([ "B", "C" ]).mean().values, new_data);
   });
 
-  // it("printing multiindex table, example with cumsum operation for dataframe group by one column", function(){
-  //   let data = { 'A': [ 'foo', 'bar', 'foo', 'bar',
-  //     'foo', 'bar', 'foo', 'foo' ],
-  //   'B': [ 'one', 'one', 'two', 'three',
-  //     'two', 'two', 'one', 'three' ],
-  //   'C': [ 1, 3, 2, 4, 5, 2, 6, 7 ],
-  //   'D': [ 3, 2, 4, 1, 5, 6, 7, 8 ] };
-
-
-  //   let df = new dfd.DataFrame(data);
-
-  //   let grp = df.groupby([ "A" ]);
-  //   let rslt = [
-  //     [ 'foo', 1 ],
-  //     [ 'foo', 3 ],
-  //     [ 'foo', 8 ],
-  //     [ 'foo', 14 ],
-  //     [ 'foo', 21 ],
-  //     [ 'bar', 3 ],
-  //     [ 'bar', 7 ],
-  //     [ 'bar', 9 ]
-  //   ];
-  //   assert.deepEqual(grp.col([ "C" ]).cumsum().values, rslt);
-
-  // });
+  it("printing multiindex table, example with cumsum operation for dataframe group by one column", function(){
+    let data = { 'A': [ 'foo', 'bar', 'foo', 'bar',
+      'foo', 'bar', 'foo', 'foo' ],
+    'B': [ 'one', 'one', 'two', 'three',
+      'two', 'two', 'one', 'three' ],
+    'C': [ 1, 3, 2, 4, 5, 2, 6, 7 ],
+    'D': [ 3, 2, 4, 1, 5, 6, 7, 8 ] };
+
+
+    let df = new dfd.DataFrame(data);
+
+    let grp = df.groupby([ "A" ]);
+    let rslt = [
+      [ 'foo', 1 ],
+      [ 'foo', 3 ],
+      [ 'foo', 8 ],
+      [ 'foo', 14 ],
+      [ 'foo', 21 ],
+      [ 'bar', 3 ],
+      [ 'bar', 7 ],
+      [ 'bar', 9 ]
+    ];
+    assert.deepEqual(grp.col([ "C" ]).cumsum().values, rslt);
+
+  });
   it("printing multiindex table, example with cumsum operation for dataframe group by one column", function(){
     let data = { 'A': [ 'foo', 'bar', 'foo', 'bar',
       'foo', 'bar', 'foo', 'foo' ],