Revert "Apply StringUtilities.getChars() across java-util charAt() hot loops"

This reverts commit 0c00f88.

Author: jdereg

changelog.md

@@ -1,7 +1,7 @@
 ### Revision History
 
 #### 4.99.0 (Unreleased)
-* **FEATURE**: New `StringUtilities.getChars(String s)` — public API that returns a ThreadLocal `char[]` buffer populated via `String.getChars()` (SIMD-optimized bulk copy). Callers replace `str.charAt(i)` loops with direct `buf[i]` array access, avoiding per-character method call and JDK 9+ coder check overhead. Applied across `StringUtilities` (`trimLength`, `hexStringToByteArray`, `count`, `levenshteinDistance`, `damerauLevenshteinDistance`, `snakeToCamel`, `camelToSnake`, `isNumeric`), `ByteUtilities.decode`, `MathUtilities.smartNumberParse`, and `DateUtilities` (`validateSecure`, `parseNanosecond`, `parseTimeZone`, `removeDateMarkerCharacters`).
+* **FEATURE**: New `StringUtilities.getChars(String s)` — public API that returns a ThreadLocal `char[]` buffer populated via `String.getChars()` (SIMD-optimized bulk copy). Callers can replace `str.charAt(i)` loops with direct `buf[i]` array access, avoiding per-character method call and JDK 9+ coder check overhead. Use `s.length()` for the valid range. Buffer is shared per-thread — valid until the next `getChars()` call on the same thread.
 * **PERFORMANCE**: `StringUtilities.hashCodeIgnoreCase(String)` — uses `StringUtilities.getChars()` (SIMD-optimized bulk copy) into a ThreadLocal `char[]` buffer, then hashes from the array directly. Avoids `charAt()`'s per-character method call and JDK 9+ compact-string coder check overhead. No reflection, no VarHandle, no `--add-opens` — works on all JDK versions (8-25+). Benchmark shows CaseInsensitiveMap GET improved **70-75%** (230 → 58-69 ns/op), PUT improved **48-52%** (135 → 65-71 ns/op), and MIXED-CASE GET improved **68%** (302 → 93-97 ns/op) on 100K entries.
 * **PERFORMANCE**: New `FastReader.readLine(char[] dest, int off, int maxLen)` — dedicated line-reading method optimized for TOON's line-oriented parsing. Combines scanning, copying, and line-ending consumption (`\n`, `\r`, `\r\n`) into a single call. Uses a `c <= '\r'` range guard so printable characters (the vast majority) require only one comparison per character instead of two. Eliminates the per-line overhead of separate `readUntil()` + `read()` + pushback round-trip. JFR shows TOON line-reading samples dropped from 173 to 125 (28% reduction), and `FastReader.read()` calls halved (53 → 25 samples).
 * **PERFORMANCE**: `FastReader.readUntil()` pushback drain loop now uses a local variable for `pushbackPosition` instead of repeated member field access, avoiding load/store through `this` on each iteration. JFR shows 14.8% reduction in aggregate FastReader CPU share.

src/main/java/com/cedarsoftware/util/ByteUtilities.java

@@ -255,10 +255,9 @@ private static byte[] decodeInternal(final CharSequence s, boolean enforceSecuri
             return null;
         }
         byte[] bytes = new byte[len >> 1];
-        char[] buf = (s instanceof String) ? StringUtilities.getChars((String) s) : s.toString().toCharArray();
         for (int i = 0, j = 0; i < len; i += 2) {
-            char c1 = buf[i];
-            char c2 = buf[i + 1];
+            char c1 = s.charAt(i);
+            char c2 = s.charAt(i + 1);
             // Check if the characters are within ASCII range
             if (c1 >= HEX_LOOKUP.length || c2 >= HEX_LOOKUP.length) {
                 return null;

src/main/java/com/cedarsoftware/util/DateUtilities.java

@@ -336,10 +336,8 @@ private static void validateMalformedInput(String input) {
         // Check for excessive nested grouping
         int openParens = 0;
         int maxNesting = 0;
-        int inputLen = input.length();
-        char[] inputBuf = StringUtilities.getChars(input);
-        for (int i = 0; i < inputLen; i++) {
-            char c = inputBuf[i];
+        for (int i = 0; i < input.length(); i++) {
+            char c = input.charAt(i);
             if (c == '(') {
                 openParens++;
                 maxNesting = Math.max(maxNesting, openParens);
@@ -874,9 +872,8 @@ private static long convertFractionToNanos(String fracSec) {
         int len = digits.length();
 
         // Validate all characters are digits
-        char[] digitBuf = StringUtilities.getChars(digits);
         for (int i = 0; i < len; i++) {
-            char c = digitBuf[i];
+            char c = digits.charAt(i);
             if (c < '0' || c > '9') {
                 throw new IllegalArgumentException("Invalid fractional second: " + fracSec);
             }
@@ -917,9 +914,8 @@ private static ZoneId getTimeZone(String tz) {
         }
 
         // Additional security validation: prevent control characters and null bytes
-        char[] tzBuf = StringUtilities.getChars(tz);
         for (int i = 0; i < tz.length(); i++) {
-            char c = tzBuf[i];
+            char c = tz.charAt(i);
             if (c < 32 || c == 127) { // Control characters including null byte
                 throw new IllegalArgumentException("Invalid timezone string contains control characters");
             }
@@ -1020,11 +1016,9 @@ private static void verifyNoGarbageLeft(String remnant) {
     }
 
     private static String removeDateMarkerCharacters(String input) {
-        int inputLen = input.length();
-        char[] buf = StringUtilities.getChars(input);
         StringBuilder builder = null;
-        for (int i = 0; i < inputLen; i++) {
-            char c = buf[i];
+        for (int i = 0; i < input.length(); i++) {
+            char c = input.charAt(i);
             if (c == 'T' || c == ',') {
                 if (builder == null) {
                     builder = new StringBuilder(input.length() - 1);

src/main/java/com/cedarsoftware/util/MathUtilities.java

@@ -502,19 +502,18 @@ public static Number parseToMinimalNumericType(CharSequence numStr)
         }
 
         final int len = text.length();
-        char[] buf = StringUtilities.getChars(text);
         int start = 0;
         if (len > 0) {
-            char first = buf[0];
+            char first = text.charAt(0);
             if (first == '-' || first == '+') {
                 start = 1;
             }
         }
 
         // Trim integer leading zeros (keeping one zero before non-digit, e.g., "000.1" -> "0.1")
         while (start + 1 < len
-                && buf[start] == '0'
-                && Character.isDigit(buf[start + 1]))
+                && text.charAt(start) == '0'
+                && Character.isDigit(text.charAt(start + 1)))
         {
             start++;
         }
@@ -530,7 +529,7 @@ public static Number parseToMinimalNumericType(CharSequence numStr)
         boolean exponentOverflow = false;
 
         for (int i = start; i < len; i++) {
-            char c = buf[i];
+            char c = text.charAt(i);
             if (c == '.') {
                 hasDecimalPoint = true;
                 inExponent = false;

src/main/java/com/cedarsoftware/util/StringUtilities.java

@@ -480,11 +480,10 @@ public static int trimLength(String s) {
         }
         int start = 0;
         int end = s.length();
-        char[] buf = getChars(s);
-        while (start < end && buf[start] <= ' ') {
+        while (start < end && s.charAt(start) <= ' ') {
             start++;
         }
-        while (end > start && buf[end - 1] <= ' ') {
+        while (end > start && s.charAt(end - 1) <= ' ') {
             end--;
         }
         return end - start;
@@ -528,10 +527,9 @@ public static byte[] decode(String s) {
         byte[] bytes = new byte[len / 2];
         int pos = 0;
 
-        char[] buf = getChars(s);
         for (int i = 0; i < len; i += 2) {
-            int hi = Character.digit(buf[i], 16);
-            int lo = Character.digit(buf[i + 1], 16);
+            int hi = Character.digit(s.charAt(i), 16);
+            int lo = Character.digit(s.charAt(i + 1), 16);
             if (hi == -1 || lo == -1) {
                 return null;
             }
@@ -580,9 +578,8 @@ public static int count(String s, char c) {
 
         int answer = 0;
         int len = s.length();
-        char[] buf = getChars(s);
         for (int i = 0; i < len; i++) {
-            if (buf[i] == c) {
+            if (s.charAt(i) == c) {
                 answer++;
             }
         }
@@ -743,8 +740,6 @@ public static int levenshteinDistance(CharSequence s, CharSequence t) {
 
         int sLen = s.length();
         int tLen = t.length();
-        char[] sBuf = (s instanceof String) ? getChars((String) s) : charSequenceToArray(s);
-        char[] tBuf = (t instanceof String) ? ((String) t).toCharArray() : charSequenceToArray(t);
         for (int i = 0; i < sLen; i++) {
             // calculate v1 (current row distances) from the previous row v0
 
@@ -754,7 +749,7 @@ public static int levenshteinDistance(CharSequence s, CharSequence t) {
 
             // use formula to fill in the rest of the row
             for (int j = 0; j < tLen; j++) {
-                int cost = (sBuf[i] == tBuf[j]) ? 0 : 1;
+                int cost = (s.charAt(i) == t.charAt(j)) ? 0 : 1;
                 int left = v1[j] + 1;
                 int up = v0[j + 1] + 1;
                 int diagonal = v0[j] + cost;
@@ -822,12 +817,10 @@ public static int damerauLevenshteinDistance(CharSequence source, CharSequence t
             distanceMatrix[0][targetIndex] = targetIndex;
         }
 
-        char[] srcBuf = (source instanceof String) ? getChars((String) source) : charSequenceToArray(source);
-        char[] tgtBuf = (target instanceof String) ? ((String) target).toCharArray() : charSequenceToArray(target);
         for (int srcIndex = 1; srcIndex <= srcLen; srcIndex++) {
             for (int targetIndex = 1; targetIndex <= targetLen; targetIndex++) {
                 // If the current characters in both strings are equal
-                int cost = srcBuf[srcIndex - 1] == tgtBuf[targetIndex - 1] ? 0 : 1;
+                int cost = source.charAt(srcIndex - 1) == target.charAt(targetIndex - 1) ? 0 : 1;
 
                 // Find the current distance by determining the shortest path to a
                 // match (hence the 'minimum' calculation on distances).
@@ -845,7 +838,7 @@ public static int damerauLevenshteinDistance(CharSequence source, CharSequence t
 
                 // transposition check (if the current and previous
                 // character are switched around (e.g.: t[se]t and t[es]t)...
-                if (srcBuf[srcIndex - 1] == tgtBuf[targetIndex - 2] && srcBuf[srcIndex - 2] == tgtBuf[targetIndex - 1]) {
+                if (source.charAt(srcIndex - 1) == target.charAt(targetIndex - 2) && source.charAt(srcIndex - 2) == target.charAt(targetIndex - 1)) {
                     // What's the minimum cost between the current distance
                     // and a transposition.
                     int transpositionCost = distanceMatrix[srcIndex - 2][targetIndex - 2] + cost;
@@ -1023,16 +1016,6 @@ public static char[] getChars(String s) {
         return buf;
     }
 
-    /** Convert a CharSequence to a char array (for non-String CharSequences). */
-    private static char[] charSequenceToArray(CharSequence cs) {
-        int n = cs.length();
-        char[] arr = new char[n];
-        for (int i = 0; i < n; i++) {
-            arr[i] = cs.charAt(i);
-        }
-        return arr;
-    }
-
     /** Internal: get a reusable char buffer from ThreadLocal, growing if needed. */
     private static char[] getCharBuf(int minSize) {
         char[] buf = TL_CHAR_BUF.get();
@@ -1196,11 +1179,10 @@ public static String snakeToCamel(String snake) {
             return null;
         }
         int len = snake.length();
-        char[] buf = getChars(snake);
         StringBuilder result = new StringBuilder(len);
         boolean upper = false;
         for (int i = 0; i < len; i++) {
-            char c = buf[i];
+            char c = snake.charAt(i);
             if (c == '_') {
                 upper = true;
                 continue;
@@ -1221,11 +1203,9 @@ public static String camelToSnake(String camel) {
         if (camel == null) {
             return null;
         }
-        int len = camel.length();
-        char[] buf = getChars(camel);
         StringBuilder result = new StringBuilder();
-        for (int i = 0; i < len; i++) {
-            char c = buf[i];
+        for (int i = 0; i < camel.length(); i++) {
+            char c = camel.charAt(i);
             if (Character.isUpperCase(c) && i > 0) {
                 result.append('_');
             }
@@ -1244,9 +1224,8 @@ public static boolean isNumeric(String s) {
         if (s == null || s.isEmpty()) {
             return false;
         }
-        char[] buf = getChars(s);
         for (int i = 0; i < s.length(); i++) {
-            if (!Character.isDigit(buf[i])) {
+            if (!Character.isDigit(s.charAt(i))) {
                 return false;
             }
         }