code improvements

Author: jeevatkm

src/main/java/com/myjeeva/digitalocean/DigitalOcean.java

@@ -1589,19 +1589,19 @@ Snapshot getSnaphotInfo(String snapshotId)
   Delete deleteSnapshot(String snapshotId)
       throws DigitalOceanException, RequestUnsuccessfulException;
 
-
   // ===========================================
   // Load balancers manipulation methods
   // ===========================================
 
   /**
    * Method allows you to add a new load balancer to distribute traffic across multiple Droplets.
    *
-   * The LoadBalancer object passed in param can have a list of dropletIds set as dropletIds attribute.
-   * In this case, given Droplets will be assigned to the Load Balancer.
+   * The LoadBalancer object passed in param can have a list of dropletIds set as dropletIds
+   * attribute. In this case, given Droplets will be assigned to the Load Balancer.
    *
-   * You may also use a Droplet tag to assign a group of Droplets to Load Balancer in place of a list of Droplet IDs.
-   * In this case, set the tag attribute of the LoadBalancer object passed in param.
+   * You may also use a Droplet tag to assign a group of Droplets to Load Balancer in place of a
+   * list of Droplet IDs. In this case, set the tag attribute of the LoadBalancer object passed in
+   * param.
    *
    * @param loadBalancer the instance of the loadBalancer class
    * @return {@link LoadBalancer}
@@ -1614,7 +1614,6 @@ Delete deleteSnapshot(String snapshotId)
   LoadBalancer createLoadBalancer(LoadBalancer loadBalancer) throws DigitalOceanException,
       RequestUnsuccessfulException;
 
-
   /**
    * Method returns complete information for given load balancer ID.
    *
@@ -1630,8 +1629,8 @@ LoadBalancer getLoadBalancerInfo(String loadBalancerId)
       throws DigitalOceanException, RequestUnsuccessfulException;
 
   /**
-   * Method returns all active loadbalancers that are currently running in your account. All available
-   * API information is presented for each loadbalancer.
+   * Method returns all active loadbalancers that are currently running in your account. All
+   * available API information is presented for each loadbalancer.
    *
    * @param pageNo for pagination
    * @param perPage no. of items per page
@@ -1646,10 +1645,10 @@ LoadBalancers getAvailableLoadBalancers(Integer pageNo, Integer perPage)
       throws DigitalOceanException, RequestUnsuccessfulException;
 
   /**
-   * Method allows you to update an existign load balancer.
-   * The LoadBalancer object passed in param should contain a full representation of the Load Balancer including existing attributes.
-   * It may contain one of the dropletIds or tag parameter as they are mutually exclusive.
-   * Note that any attribute that is not provided will be reset to its default value.
+   * Method allows you to update an existign load balancer. The LoadBalancer object passed in param
+   * should contain a full representation of the Load Balancer including existing attributes. It may
+   * contain one of the dropletIds or tag parameter as they are mutually exclusive. Note that any
+   * attribute that is not provided will be reset to its default value.
    *
    * @param loadBalancer the instance of the loadBalancer class
    * @return {@link LoadBalancer}
@@ -1666,64 +1665,73 @@ LoadBalancer updateLoadBalancer(LoadBalancer loadBalancer) throws DigitalOceanEx
    * Method allows you to assign a Droplet to a Load Balancer instance.
    *
    * @param loadBalancerId the id of the loadBalancer
-   * @param dropletIds an array containing the IDs of the Droplets to be assigned to the Load Balancer instance.
+   * @param dropletIds an array containing the IDs of the Droplets to be assigned to the Load
+   *        Balancer instance.
    * @return {@link Response}
    * @throws DigitalOceanException if request had interruption [
    *         <code>HTTP status code &gt;= 400 &amp;&amp; &lt; 510</code>]
    * @throws RequestUnsuccessfulException if any RESTful request unsuccessful from wrapper method
    *
    * @since v2.11
    */
-  Response addDropletsToLoadBalancer(String loadBalancerId, List<Integer> dropletIds) throws DigitalOceanException,
+  Response addDropletsToLoadBalancer(String loadBalancerId, List<Integer> dropletIds)
+      throws DigitalOceanException,
       RequestUnsuccessfulException;
 
   /**
    * Method allows you to remove a Droplet from a Load Balancer instance.
    *
    * @param loadBalancerId the id of the loadBalancer
-   * @param dropletIds an array containing the IDs of the Droplets to be removed from the Load Balancer instance.
+   * @param dropletIds an array containing the IDs of the Droplets to be removed from the Load
+   *        Balancer instance.
    * @return {@link Delete}
    * @throws DigitalOceanException if request had interruption [
    *         <code>HTTP status code &gt;= 400 &amp;&amp; &lt; 510</code>]
    * @throws RequestUnsuccessfulException if any RESTful request unsuccessful from wrapper method
    *
    * @since v2.11
    */
-  Delete removeDropletsFromLoadBalancer(String loadBalancerId, List<Integer> dropletIds) throws DigitalOceanException,
+  Delete removeDropletsFromLoadBalancer(String loadBalancerId, List<Integer> dropletIds)
+      throws DigitalOceanException,
       RequestUnsuccessfulException;
 
   /**
    * Method allows you to add an additional forwarding rule to a Load Balancer instance.
    *
    * @param loadBalancerId the id of the loadBalancer
-   * @param forwardingRules an array containing the Forwarding Rules to add to the Load Balancer instance.
+   * @param forwardingRules an array containing the Forwarding Rules to add to the Load Balancer
+   *        instance.
    * @return {@link Response}
    * @throws DigitalOceanException if request had interruption [
    *         <code>HTTP status code &gt;= 400 &amp;&amp; &lt; 510</code>]
    * @throws RequestUnsuccessfulException if any RESTful request unsuccessful from wrapper method
    *
    * @since v2.11
    */
-  Response addForwardingRulesToLoadBalancer(String loadBalancerId, List<ForwardingRules> forwardingRules) throws DigitalOceanException,
+  Response addForwardingRulesToLoadBalancer(String loadBalancerId,
+      List<ForwardingRules> forwardingRules) throws DigitalOceanException,
       RequestUnsuccessfulException;
 
   /**
    * Method allows you to remove forwarding rules from a Load Balancer instance.
    *
    * @param loadBalancerId the id of the loadBalancer
-   * @param forwardingRules an array containing the Forwarding Rules to remove from the Load Balancer instance.
+   * @param forwardingRules an array containing the Forwarding Rules to remove from the Load
+   *        Balancer instance.
    * @return {@link Delete}
    * @throws DigitalOceanException if request had interruption [
    *         <code>HTTP status code &gt;= 400 &amp;&amp; &lt; 510</code>]
    * @throws RequestUnsuccessfulException if any RESTful request unsuccessful from wrapper method
    *
    * @since v2.11
    */
-  Delete removeForwardingRulesFromLoadBalancer(String loadBalancerId, List<ForwardingRules> forwardingRules) throws DigitalOceanException,
+  Delete removeForwardingRulesFromLoadBalancer(String loadBalancerId,
+      List<ForwardingRules> forwardingRules) throws DigitalOceanException,
       RequestUnsuccessfulException;
 
   /**
-   * Method allows you to delete a Load Balancer instance, disassociating any Droplets assigned to it and removing it from your account.
+   * Method allows you to delete a Load Balancer instance, disassociating any Droplets assigned to
+   * it and removing it from your account.
    *
    * @param loadBalancerId the id of the loadBalancer
    * @return {@link Delete}

src/main/java/com/myjeeva/digitalocean/common/ActionStatus.java

@@ -21,6 +21,8 @@
 
 package com.myjeeva.digitalocean.common;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.google.gson.annotations.SerializedName;
 
 /**
@@ -43,7 +45,7 @@ public enum ActionStatus {
 
   private String value;
 
-  ActionStatus(String value) {
+  private ActionStatus(String value) {
     this.value = value;
   }
 
@@ -53,7 +55,7 @@ public String toString() {
   }
 
   public static ActionStatus fromValue(String value) {
-    if (null == value || "".equals(value)) {
+    if (StringUtils.isBlank(value)) {
       throw new IllegalArgumentException("Value cannot be null or empty!");
     }
 

src/main/java/com/myjeeva/digitalocean/common/ActionType.java

@@ -21,6 +21,8 @@
 
 package com.myjeeva.digitalocean.common;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.google.gson.annotations.SerializedName;
 
 /**
@@ -118,7 +120,7 @@ public enum ActionType {
 
   private String value;
 
-  ActionType(String value) {
+  private ActionType(String value) {
     this.value = value;
   }
 
@@ -128,7 +130,7 @@ public String toString() {
   }
 
   public static ActionType fromValue(String value) {
-    if (null == value || "".equals(value)) {
+    if (StringUtils.isBlank(value)) {
       throw new IllegalArgumentException("Value cannot be null or empty!");
     }
 

src/main/java/com/myjeeva/digitalocean/common/DropletStatus.java

@@ -21,6 +21,8 @@
 
 package com.myjeeva.digitalocean.common;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.google.gson.annotations.SerializedName;
 
 /**
@@ -57,7 +59,7 @@ public String toString() {
   }
 
   public static DropletStatus fromValue(String value) {
-    if (null == value || "".equals(value)) {
+    if (StringUtils.isBlank(value)) {
       throw new IllegalArgumentException("Value cannot be null or empty!");
     }
 

src/main/java/com/myjeeva/digitalocean/common/ImageType.java

@@ -21,6 +21,8 @@
 
 package com.myjeeva.digitalocean.common;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.google.gson.annotations.SerializedName;
 
 /**
@@ -48,7 +50,7 @@ public enum ImageType {
 
   private String value;
 
-  ImageType(String value) {
+  private ImageType(String value) {
     this.value = value;
   }
 
@@ -58,7 +60,7 @@ public String toString() {
   }
 
   public static ImageType fromValue(String value) {
-    if (null == value || "".equals(value)) {
+    if (StringUtils.isBlank(value)) {
       throw new IllegalArgumentException("Value cannot be null or empty!");
     }
 

src/main/java/com/myjeeva/digitalocean/common/LoadBalancerStatus.java

@@ -21,6 +21,8 @@
 
 package com.myjeeva.digitalocean.common;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.google.gson.annotations.SerializedName;
 
 /**
@@ -48,7 +50,7 @@ private LoadBalancerStatus(String value) {
     }
 
     public static LoadBalancerStatus fromValue(String value) {
-        if (null == value || "".equals(value)) {
+        if (StringUtils.isBlank(value)) {
             throw new IllegalArgumentException("Value cannot be null or empty!");
         }
 

src/main/java/com/myjeeva/digitalocean/common/LoadBalancingAlgorithm.java

@@ -21,6 +21,8 @@
 
 package com.myjeeva.digitalocean.common;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.google.gson.annotations.SerializedName;
 
 /**
@@ -45,7 +47,7 @@ private LoadBalancingAlgorithm(String value) {
     }
 
     public static LoadBalancingAlgorithm fromValue(String value) {
-        if (null == value || "".equals(value)) {
+        if (StringUtils.isBlank(value)) {
             throw new IllegalArgumentException("Value cannot be null or empty!");
         }
 

src/main/java/com/myjeeva/digitalocean/common/Protocol.java

@@ -21,6 +21,8 @@
 
 package com.myjeeva.digitalocean.common;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.google.gson.annotations.SerializedName;
 
 /**
@@ -48,7 +50,7 @@ private Protocol(String value) {
     }
 
     public static Protocol fromValue(String value) {
-        if (null == value || "".equals(value)) {
+        if (StringUtils.isBlank(value)) {
             throw new IllegalArgumentException("Value cannot be null or empty!");
         }
 

src/main/java/com/myjeeva/digitalocean/common/ResourceType.java

@@ -21,6 +21,8 @@
 
 package com.myjeeva.digitalocean.common;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.google.gson.annotations.SerializedName;
 
 /**
@@ -53,7 +55,7 @@ public enum ResourceType {
 
   private String value;
 
-  ResourceType(String value) {
+  private ResourceType(String value) {
     this.value = value;
   }
 
@@ -63,7 +65,7 @@ public String toString() {
   }
 
   public static ResourceType fromValue(String value) {
-    if (null == value || "".equals(value)) {
+    if (StringUtils.isBlank(value)) {
       throw new IllegalArgumentException("Value cannot be null or empty!");
     }
 

src/main/java/com/myjeeva/digitalocean/common/StickySessionType.java

@@ -21,6 +21,8 @@
 
 package com.myjeeva.digitalocean.common;
 
+import org.apache.commons.lang3.StringUtils;
+
 import com.google.gson.annotations.SerializedName;
 
 /**
@@ -45,7 +47,7 @@ private StickySessionType(String value) {
     }
 
     public static StickySessionType fromValue(String value) {
-        if (null == value || "".equals(value)) {
+        if (StringUtils.isBlank(value)) {
             throw new IllegalArgumentException("Value cannot be null or empty!");
         }