Fail early if WebHook secret is blank

jessety · jessety · commit af931080e60b · 2020-08-14T15:02:40.000-04:00
diff --git a/src/WebHook.js b/src/WebHook.js
@@ -22,7 +22,7 @@ class GitHubWebhook extends EventEmitter2 {
       throw new Error('GitHub WebHook requires a port to run on');
     }
 
-    if (typeof options.secret !== 'string') {
+    if (typeof options.secret !== 'string' || options.secret === '') {
       throw new Error('GitHub WebHook requires a "secret"');
     }
 

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ class GitHubWebhook extends EventEmitter2 {`
`22`	`22`	`throw new Error('GitHub WebHook requires a port to run on');`
`23`	`23`	`}`
`24`	`24`
`25`		`- if (typeof options.secret !== 'string') {`
	`25`	`+ if (typeof options.secret !== 'string' \|\| options.secret === '') {`
`26`	`26`	`throw new Error('GitHub WebHook requires a "secret"');`
`27`	`27`	`}`
`28`	`28`