Fixed stale REQUEST_TIME during cron by refreshing before cron->run().

Author: AlexSkrypnyk

src/Drupal/Driver/Cores/Drupal8.php

@@ -120,6 +120,8 @@ public function nodeDelete($node) {
    * {@inheritdoc}
    */
   public function runCron() {
+    $_SERVER['REQUEST_TIME'] = time();
+    \Drupal::request()->server->set('REQUEST_TIME', $_SERVER['REQUEST_TIME']);
     return \Drupal::service('cron')->run();
   }
 

tests/Drupal/Tests/Driver/Drupal8Test.php

@@ -0,0 +1,76 @@
+<?php
+
+namespace Drupal\Tests\Driver;
+
+use Drupal;
+use Drupal\Core\CronInterface;
+use Drupal\Driver\Cores\Drupal8;
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\RequestStack;
+
+/**
+ * Tests for the Drupal 8+ core driver.
+ */
+class Drupal8Test extends TestCase {
+
+  /**
+   * The original REQUEST_TIME value.
+   *
+   * @var int
+   */
+  protected $originalRequestTime;
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp(): void {
+    parent::setUp();
+    $this->originalRequestTime = $_SERVER['REQUEST_TIME'] ?? NULL;
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function tearDown(): void {
+    if ($this->originalRequestTime !== NULL) {
+      $_SERVER['REQUEST_TIME'] = $this->originalRequestTime;
+    }
+    parent::tearDown();
+  }
+
+  /**
+   * Tests that `runCron()` refreshes `REQUEST_TIME` before running cron.
+   */
+  public function testRunCronRefreshesRequestTime() {
+    $before = time();
+    $stale_time = $before - 60;
+
+    // Create a real Symfony Request with a stale REQUEST_TIME.
+    $request = new Request();
+    $request->server->set('REQUEST_TIME', $stale_time);
+    $_SERVER['REQUEST_TIME'] = $stale_time;
+
+    // Mock the cron service.
+    $cron = $this->createMock(CronInterface::class);
+    $cron->method('run')->willReturn(TRUE);
+
+    // Wire a container with request_stack and cron service.
+    $request_stack = new RequestStack();
+    $request_stack->push($request);
+    $container = new ContainerBuilder();
+    $container->set('request_stack', $request_stack);
+    $container->set('cron', $cron);
+    Drupal::setContainer($container);
+
+    // Use __DIR__ as a dummy drupal root (runCron does not use it).
+    $core = new Drupal8(__DIR__, 'default');
+    $result = $core->runCron();
+
+    $this->assertTrue($result);
+    $this->assertGreaterThanOrEqual($before, $_SERVER['REQUEST_TIME'], '$_SERVER[REQUEST_TIME] was not refreshed.');
+    $this->assertGreaterThanOrEqual($before, $request->server->get('REQUEST_TIME'), 'Request server bag REQUEST_TIME was not refreshed.');
+  }
+
+}