Simplify fieldsByTraversal, ptrs is always true

Author: kszafran

sqlx.go

@@ -622,7 +622,7 @@ func (r *Rows) StructScan(dest interface{}) error {
 	}
 
 	octx := newObjectContext()
-	err := fieldsByTraversal(octx, v, r.fields, r.values, true)
+	err := fieldsByTraversal(octx, v, r.fields, r.values)
 	if err != nil {
 		return err
 	}
@@ -784,7 +784,7 @@ func (r *Row) scanAny(dest interface{}, structOnly bool) error {
 
 	octx := newObjectContext()
 
-	err = fieldsByTraversal(octx, v, fields, values, true)
+	err = fieldsByTraversal(octx, v, fields, values)
 	if err != nil {
 		return err
 	}
@@ -958,7 +958,7 @@ func scanAll(rows rowsi, dest interface{}, structOnly bool) error {
 			vp = reflect.New(base)
 			v = reflect.Indirect(vp)
 
-			err = fieldsByTraversal(octx, v, fields, values, true)
+			err = fieldsByTraversal(octx, v, fields, values)
 			if err != nil {
 				return err
 			}
@@ -1024,7 +1024,7 @@ func baseType(t reflect.Type, expected reflect.Kind) (reflect.Type, error) {
 // when iterating over many rows.  Empty traversals will get an interface pointer.
 // Because of the necessity of requesting ptrs or values, it's considered a bit too
 // specialized for inclusion in reflectx itself.
-func fieldsByTraversal(octx *objectContext, v reflect.Value, traversals [][]int, values []interface{}, ptrs bool) error {
+func fieldsByTraversal(octx *objectContext, v reflect.Value, traversals [][]int, values []interface{}) error {
 	v = reflect.Indirect(v)
 	if v.Kind() != reflect.Struct {
 		return errors.New("argument not a struct")
@@ -1038,11 +1038,7 @@ func fieldsByTraversal(octx *objectContext, v reflect.Value, traversals [][]int,
 			continue
 		}
 		f := octx.FieldForIndexes(traversal)
-		if ptrs {
-			values[i] = f.Addr().Interface()
-		} else {
-			values[i] = f.Interface()
-		}
+		values[i] = f.Addr().Interface()
 	}
 	return nil
 }