Skip to content

Cannot parse import {type A, type B} from ... #185

@stackptr

Description

@stackptr

flowgen does not parse comma-separated type imports correctly. The following diff shows the imports.spec.ts updated with this style of import and the resulting malformed import:

diff --git a/src/__tests__/imports.spec.ts b/src/__tests__/imports.spec.ts
index 3694123..90f5b87 100644
--- a/src/__tests__/imports.spec.ts
+++ b/src/__tests__/imports.spec.ts
@@ -42,6 +42,7 @@ it("should handle type imports", () => {
   const ts = `import type { GeneratorOptions } from "@babel/generator";
 import type traverse from "@babel/traverse";
 import type { Visitor as NewVisitor } from "@babel/traverse";
+import { type Node, type Directive} from "@babel/types";
 `;
   const result = compiler.compileDefinitionString(ts, { quiet: true });
   expect(beautify(result)).toMatchSnapshot();
diff --git a/src/__tests__/__snapshots__/imports.spec.ts.snap b/src/__tests__/__snapshots__/imports.spec.ts.snap
index c0c285e..1372726 100644
--- a/src/__tests__/__snapshots__/imports.spec.ts.snap
+++ b/src/__tests__/__snapshots__/imports.spec.ts.snap
@@ -36,5 +36,6 @@ exports[`should handle type imports 1`] = `
 "import type { GeneratorOptions } from \\"@babel/generator\\";
 import traverse from \\"@babel/traverse\\";
 import type { Visitor as NewVisitor } from \\"@babel/traverse\\";
+import { type, Node, type, Directive } from \\"@babel/types\\";
 "
 `;

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions