Update to Unity 2019.1.0f2 and LWRP 5.13.0#3
Open
aholkner wants to merge 1 commit into
Open
Conversation
- GrabBlurPass and PerObjectBloom components converted to ScriptableRenderFeature - These must be in a namespace to workaround editor inspector bug - Custom renderer asset added to contain ScriptableRenderFeatures - Miscellaneous changes to catch up to LWRP API changes - TODO: PerObjectBloomTarget adding itself to a static list instead of using render layers; so far I have not been able to get context.DrawRenderers to draw anything.
Author
|
Additionally, these warnings are printed to the console while the frame debugger is enabled, but I'm not sure what to do about them: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incomplete
LWRP 5.13.0 has a significantly different API to 4.0.1; this PR fixes gets the samples working and compiling, however I would like some help from the Unity developers in fixing the final issue: I was not able to get
context.DrawRenderersto draw anything, regardless of render layers or filter settings.NullReferenceExceptiontrying to determine if they're in anExperimentalnamespace.using render layers; so far I have not been able to get
context.DrawRenderers to draw anything.