Skip to content

Commit 9042a22

Browse files
committed
Don't follow symlinks for idb
1 parent 1f93217 commit 9042a22

1 file changed

Lines changed: 20 additions & 18 deletions

File tree

internal/forks/http/fs.go

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -225,24 +225,26 @@ func DirList(w http.ResponseWriter, r *http.Request, fsys FileSystem, prefix str
225225
case "R":
226226
fullName := path.Join(dir, v)
227227
apks[fullName] = owner
228-
got, err := fsys.Open(fullName)
229-
if err != nil {
230-
log.Printf("apk open: %v", err)
231-
continue
232-
}
233-
fi, err := got.Stat()
234-
if err != nil {
235-
log.Printf("apk stat: %v", err)
236-
continue
237-
}
238-
header, ok := fi.Sys().(*tar.Header)
239-
if !ok {
240-
continue
241-
}
242-
if header.Name != fullName {
243-
log.Printf("apk name: %q != %q", header.Name, fullName)
244-
apks[header.Name] = owner
245-
}
228+
// This is annoyingly slow, for large images,
229+
// so sometimes symlinks might not work as expected.
230+
// got, err := fsys.Open(fullName)
231+
// if err != nil {
232+
// log.Printf("apk open: %v", err)
233+
// continue
234+
// }
235+
// fi, err := got.Stat()
236+
// if err != nil {
237+
// log.Printf("apk stat: %v", err)
238+
// continue
239+
// }
240+
// header, ok := fi.Sys().(*tar.Header)
241+
// if !ok {
242+
// continue
243+
// }
244+
// if header.Name != fullName {
245+
// log.Printf("apk name: %q != %q", header.Name, fullName)
246+
// apks[header.Name] = owner
247+
// }
246248

247249
case "F":
248250
dir = v

0 commit comments

Comments
 (0)