Merge pull request #120 from joomcode/feat/selector-find-accept-selectors

feat: add global warnings for TestUnhandledRejection instead of errors

Author: uid11

autotests/tests/switchingPagesForResponses.ts

@@ -63,6 +63,7 @@ test(
 
     await expect(
       numberOfSentRequests === numberOfCaughtResponses ||
+        numberOfSentRequests === numberOfCaughtResponses + 2 ||
         numberOfSentRequests === numberOfCaughtResponses + 1 ||
         numberOfSentRequests === numberOfCaughtResponses - 1,
       `almost all responses were caught (${numberOfCaughtResponses} of ${numberOfSentRequests})`,

package-lock.json

@@ -25,26 +25,26 @@
     "url": "git+https://github.com/joomcode/e2ed.git"
   },
   "dependencies": {
-    "@playwright/test": "1.52.0",
+    "@playwright/test": "1.53.2",
     "create-locator": "0.0.27",
     "get-modules-graph": "0.0.11",
     "sort-json-keys": "1.0.3"
   },
   "devDependencies": {
-    "@playwright/browser-chromium": "1.52.0",
-    "@types/node": "22.15.21",
+    "@playwright/browser-chromium": "1.53.2",
+    "@types/node": "24.0.8",
     "@typescript-eslint/eslint-plugin": "7.18.0",
     "@typescript-eslint/parser": "7.18.0",
     "assert-modules-support-case-insensitive-fs": "1.0.1",
     "assert-package-lock-is-consistent": "1.0.0",
     "eslint": "8.57.1",
     "eslint-config-airbnb-base": "15.0.0",
     "eslint-config-prettier": "10.1.5",
-    "eslint-plugin-import": "2.31.0",
+    "eslint-plugin-import": "2.32.0",
     "eslint-plugin-simple-import-sort": "12.1.1",
     "eslint-plugin-typescript-sort-keys": "3.3.0",
     "husky": "9.1.7",
-    "prettier": "3.5.3",
+    "prettier": "3.6.2",
     "typescript": "5.8.3"
   },
   "peerDependencies": {

package.json

@@ -13,14 +13,12 @@ export abstract class ApiRoute<
   /**
    * Request type of API route.
    */
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  declare readonly __REQUEST_KEY: SomeRequest;
+  declare readonly Request: SomeRequest;
 
   /**
    * Response type of API route.
    */
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  declare readonly __RESPONSE_KEY: SomeResponse;
+  declare readonly Response: SomeResponse;
 
   /**
    * Returns `true`, if the request body is in JSON format.

src/ApiRoute.ts

@@ -16,14 +16,12 @@ export abstract class WebSocketRoute<
   /**
    * Request type of WebSocket route.
    */
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  declare readonly __REQUEST_KEY: SomeRequest;
+  declare readonly Request: SomeRequest;
 
   /**
    * Response type of WebSocket route.
    */
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  declare readonly __RESPONSE_KEY: SomeResponse;
+  declare readonly Response: SomeResponse;
 
   /**
    * Returns `true`, if the request body is in JSON format.

src/WebSocketRoute.ts

@@ -29,9 +29,9 @@ export const setHeadersAndNavigateToUrl = async (
         return route.fallback();
       }
 
-      const {navigationTimeout} = getFullPackConfig();
+      const timeout = navigateToUrlOptions?.timeout ?? getFullPackConfig().navigationTimeout;
 
-      const response = await route.fetch({timeout: navigationTimeout});
+      const response = await route.fetch({timeout});
       const headers = response.headers();
 
       applyHeadersMapper(headers, mapResponseHeaders);

src/actions/setHeadersAndNavigateToUrl.ts

@@ -53,6 +53,7 @@ export {
   EVENTS_DIRECTORY_PATH,
   EXPECTED_SCREENSHOTS_DIRECTORY_PATH,
   GLOBAL_ERRORS_PATH,
+  GLOBAL_WARNINGS_PATH,
   INSTALLED_E2ED_DIRECTORY_PATH,
   INTERNAL_DIRECTORY_NAME,
   INTERNAL_REPORTS_DIRECTORY_PATH,
@@ -63,7 +64,7 @@ export {
   TMP_DIRECTORY_PATH,
 } from './paths';
 /** @internal */
-export {TEST_ENDED_ERROR_MESSAGE} from './playwright';
+export {TARGET_CLOSED_ERROR_MESSAGE, TEST_ENDED_ERROR_MESSAGE} from './playwright';
 /** @internal */
 export {RESOLVED_PROMISE} from './promise';
 /** @internal */

src/constants/internal.ts

@@ -128,6 +128,15 @@ export const EXPECTED_SCREENSHOTS_DIRECTORY_PATH = join(
  */
 export const GLOBAL_ERRORS_PATH = join(TMP_DIRECTORY_PATH, 'globalErrors.txt') as FilePathFromRoot;
 
+/**
+ * Relative (from root) path to file with global warnings of run.
+ * @internal
+ */
+export const GLOBAL_WARNINGS_PATH = join(
+  TMP_DIRECTORY_PATH,
+  'globalWarnings.txt',
+) as FilePathFromRoot;
+
 /**
  * Relative (from root) path to directory with tests screenshots.
  * @internal

src/constants/paths.ts

@@ -1,3 +1,9 @@
+/**
+ * Playwright error message for already closed target (`TargetClosedError`).
+ * @internal
+ */
+export const TARGET_CLOSED_ERROR_MESSAGE = 'Target page, context or browser has been closed';
+
 /**
  * Playwright error message for already ended test.
  * @internal

src/constants/playwright.ts

@@ -1,4 +1,4 @@
-import {TEST_ENDED_ERROR_MESSAGE} from './constants/internal';
+import {TARGET_CLOSED_ERROR_MESSAGE, TEST_ENDED_ERROR_MESSAGE} from './constants/internal';
 import {getTestIdleTimeout} from './context/testIdleTimeout';
 import {E2edError} from './utils/error';
 import {setCustomInspectOnFunction} from './utils/fn';
@@ -13,7 +13,6 @@ import type {ClientFunction} from './types/internal';
 type Options = Readonly<{name?: string; retries?: number; timeout?: number}>;
 
 const contextErrorMessage = 'Execution context was destroyed';
-const targetErrorMessage = 'Target page, context or browser has been closed';
 
 /**
  * Creates a client function.
@@ -48,7 +47,7 @@ export const createClientFunction = <Args extends readonly unknown[], Result>(
 
         if (
           errorString.includes(contextErrorMessage) ||
-          errorString.includes(targetErrorMessage) ||
+          errorString.includes(TARGET_CLOSED_ERROR_MESSAGE) ||
           errorString.includes(TEST_ENDED_ERROR_MESSAGE)
         ) {
           await page.waitForLoadState();
@@ -58,7 +57,7 @@ export const createClientFunction = <Args extends readonly unknown[], Result>(
 
             if (
               suberrorString.includes(contextErrorMessage) ||
-              suberrorString.includes(targetErrorMessage) ||
+              suberrorString.includes(TARGET_CLOSED_ERROR_MESSAGE) ||
               suberrorString.includes(TEST_ENDED_ERROR_MESSAGE)
             ) {
               return new Promise(() => {});
@@ -80,7 +79,7 @@ export const createClientFunction = <Args extends readonly unknown[], Result>(
 
                 if (
                   suberrorString.includes(contextErrorMessage) ||
-                  suberrorString.includes(targetErrorMessage) ||
+                  suberrorString.includes(TARGET_CLOSED_ERROR_MESSAGE) ||
                   suberrorString.includes(TEST_ENDED_ERROR_MESSAGE)
                 ) {
                   return new Promise(() => {});